Merge remote-tracking branch 'upstream/pull/4706'

[rails.git] / test / abilities / abilities_test.rb

diff --git a/test/abilities/abilities_test.rb b/test/abilities/abilities_test.rb
index f43b6bf50de811b2f5b5fcc66fdca7d82e99b299..139f270feee4d274d402f84630632e6bbde1dc41 100644 (file)
--- a/test/abilities/abilities_test.rb
+++ b/test/abilities/abilities_test.rb
@@ -9,8 +9,8 @@ class GuestAbilityTest < AbilityTest
   test "geocoder permission for a guest" do
     ability = Ability.new nil
 
   test "geocoder permission for a guest" do
     ability = Ability.new nil
 

-    [:search, :search_latlon, :search_ca_postcode, :search_osm_nominatim,
-     :search_geonames, :search_osm_nominatim_reverse, :search_geonames_reverse].each do |action|
+    [:search, :search_latlon, :search_osm_nominatim,
+     :search_osm_nominatim_reverse].each do |action|

       assert ability.can?(action, :geocoder), "should be able to #{action} geocoder"
     end
   end
       assert ability.can?(action, :geocoder), "should be able to #{action} geocoder"
     end
   end


@@ -23,14 +23,13 @@ class GuestAbilityTest < AbilityTest
 
     [:create, :edit, :comment, :subscribe, :unsubscribe, :hide, :hidecomment].each do |action|
       assert ability.cannot?(action, DiaryEntry), "should not be able to #{action} DiaryEntries"
 
     [:create, :edit, :comment, :subscribe, :unsubscribe, :hide, :hidecomment].each do |action|
       assert ability.cannot?(action, DiaryEntry), "should not be able to #{action} DiaryEntries"

-      assert ability.cannot?(action, DiaryComment), "should not be able to #{action} DiaryEntries"

     end
   end
 
   test "note permissions for a guest" do
     ability = Ability.new nil
 
     end
   end
 
   test "note permissions for a guest" do
     ability = Ability.new nil
 

-    [:mine].each do |action|
+    [:index].each do |action|

       assert ability.can?(action, Note), "should be able to #{action} Notes"
     end
   end
       assert ability.can?(action, Note), "should be able to #{action} Notes"
     end
   end


@@ -54,7 +53,6 @@ class UserAbilityTest < AbilityTest
 
     [:hide, :hidecomment].each do |action|
       assert ability.cannot?(action, DiaryEntry), "should not be able to #{action} DiaryEntries"
 
     [:hide, :hidecomment].each do |action|
       assert ability.cannot?(action, DiaryEntry), "should not be able to #{action} DiaryEntries"

-      assert ability.cannot?(action, DiaryComment), "should not be able to #{action} DiaryEntries"

     end
 
     [:index, :show, :resolve, :ignore, :reopen].each do |action|
     end
 
     [:index, :show, :resolve, :ignore, :reopen].each do |action|


@@ -78,6 +76,10 @@ class ModeratorAbilityTest < AbilityTest
     [:grant, :revoke].each do |action|
       assert ability.cannot?(action, UserRole), "should not be able to #{action} UserRoles"
     end
     [:grant, :revoke].each do |action|
       assert ability.cannot?(action, UserRole), "should not be able to #{action} UserRoles"
     end

+
+    [:hide, :hidecomment].each do |action|
+      assert ability.can?(action, DiaryEntry), "should be able to #{action} DiaryEntries"
+    end

   end
 end
 
   end
 end
 


@@ -87,10 +89,6 @@ class AdministratorAbilityTest < AbilityTest
     [:index, :rss, :show, :comments, :create, :edit, :comment, :subscribe, :unsubscribe, :hide, :hidecomment].each do |action|
       assert ability.can?(action, DiaryEntry), "should be able to #{action} DiaryEntries"
     end
     [:index, :rss, :show, :comments, :create, :edit, :comment, :subscribe, :unsubscribe, :hide, :hidecomment].each do |action|
       assert ability.can?(action, DiaryEntry), "should be able to #{action} DiaryEntries"
     end

-
-    [:hide, :hidecomment].each do |action|
-      assert ability.can?(action, DiaryComment), "should be able to #{action} DiaryComment"
-    end

   end
 
   test "User Roles permissions for an administrator" do
   end
 
   test "User Roles permissions for an administrator" do