Merge remote-tracking branch 'upstream/pull/2182'

[rails.git] / script / update-spam-blocks

diff --git a/script/update-spam-blocks b/script/update-spam-blocks
index c21b17cff0ca0293bd3962fabc1f78a2714f6919..f14905b90cae1c183a7d62e8d36c96c307f1def2 100755 (executable)
--- a/script/update-spam-blocks
+++ b/script/update-spam-blocks
@@ -1,45 +1,40 @@
 #!/usr/bin/env ruby
 
 #!/usr/bin/env ruby
 

-require File.dirname(__FILE__) + '/../config/environment'
-require 'generator'
+require File.dirname(__FILE__) + "/../config/environment"
+require "generator"

 
 addresses = User.count(
   :conditions => {
 
 addresses = User.count(
   :conditions => {

-    :status => ["suspended", "deleted"],
-    :creation_time => Time.now - 28.days .. Time.now
+    :status => %w[suspended deleted],
+    :creation_time => Time.now - 28.days..Time.now

   },
   :group => :creation_ip
 )
 
   },
   :group => :creation_ip
 )
 

-addresses.each do |address,count|
-  if count > 1
-    acl = Acl.find(:first, :conditions => {
-      :address => address,
-    })
-
-    unless acl
-      Acl.create({
-        :address => address,
-        :k => "no_account_creation",
-        :v => "auto_spam_block"
-      }, :without_protection => true)
-
-      puts "Blocked #{address}"
-    end
-  end
+addresses.each do |address, count|
+  next unless count > 1
+  next if Acl.where(:address => address).exists?
+
+  Acl.create({
+               :address => address,
+               :k => "no_account_creation",
+               :v => "auto_spam_block"
+             }, { :without_protection => true })
+
+  puts "Blocked #{address}"

 end
 
 acls = Acl.find(:all, :conditions => {
 end
 
 acls = Acl.find(:all, :conditions => {

-  :k => "no_account_creation",
-  :v => "auto_spam_block"
-})
+                  :k => "no_account_creation",
+                  :v => "auto_spam_block"
+                })

 
 acls.each do |acl|
 
 acls.each do |acl|

-  unless addresses[acl.address]
-    acl.delete
+  next if addresses[acl.address]
+
+  acl.delete

 
 

-    puts "Unblocked #{acl.address}"
-  end
+  puts "Unblocked #{acl.address}"

 end
 
 exit 0
 end
 
 exit 0