Move some javascript functions out of global scope

[rails.git] / app / controllers / user_roles_controller.rb

diff --git a/app/controllers/user_roles_controller.rb b/app/controllers/user_roles_controller.rb
index 7dad891e2197a36b28f2fd69ba37b708ceaa89ee..8b1c2e8c0b738f820a27bb227b30917d3dbcb59c 100644 (file)
--- a/app/controllers/user_roles_controller.rb
+++ b/app/controllers/user_roles_controller.rb
@@ -1,5 +1,5 @@
 class UserRolesController < ApplicationController
 class UserRolesController < ApplicationController

-  layout 'site'
+  layout "site"

 
   before_filter :authorize_web
   before_filter :require_user
 
   before_filter :authorize_web
   before_filter :require_user


@@ -10,36 +10,35 @@ class UserRolesController < ApplicationController
   before_filter :in_role, :only => [:revoke]
 
   def grant
   before_filter :in_role, :only => [:revoke]
 
   def grant

-    @this_user.roles.create({
-      :role => @role, :granter_id => @user.id
-    }, :without_protection => true)
-    redirect_to :controller => 'user', :action => 'view', :display_name => @this_user.display_name
+    @this_user.roles.create(:role => @role, :granter_id => @user.id)
+    redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name

   end
 
   def revoke
   end
 
   def revoke

-    UserRole.delete_all({:user_id => @this_user.id, :role => @role})
-    redirect_to :controller => 'user', :action => 'view', :display_name => @this_user.display_name
+    UserRole.delete_all(:user_id => @this_user.id, :role => @role)
+    redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name

   end
 
   private
   end
 
   private

+

   ##
   # require that the user is an administrator, or fill out a helpful error message
   # and return them to theuser page.
   def require_administrator
     unless @user.administrator?
   ##
   # require that the user is an administrator, or fill out a helpful error message
   # and return them to theuser page.
   def require_administrator
     unless @user.administrator?

-      flash[:error] = t'user_role.filter.not_an_administrator'
-      redirect_to :controller => 'user', :action => 'view', :display_name => @this_user.display_name
+      flash[:error] = t "user_role.filter.not_an_administrator"
+      redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name

     end
   end
 
   ##
     end
   end
 
   ##

-  # require that the given role is valid. the role is a URL 
+  # require that the given role is valid. the role is a URL

   # parameter, so should always be present.
   def require_valid_role
     @role = params[:role]
     unless UserRole::ALL_ROLES.include?(@role)
   # parameter, so should always be present.
   def require_valid_role
     @role = params[:role]
     unless UserRole::ALL_ROLES.include?(@role)

-      flash[:error] = t('user_role.filter.not_a_role', :role => @role)
-      redirect_to :controller => 'user', :action => 'view', :display_name => @this_user.display_name
+      flash[:error] = t("user_role.filter.not_a_role", :role => @role)
+      redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name

     end
   end
 
     end
   end
 


@@ -47,8 +46,8 @@ class UserRolesController < ApplicationController
   # checks that the user doesn't already have this role
   def not_in_role
     if @this_user.has_role? @role
   # checks that the user doesn't already have this role
   def not_in_role
     if @this_user.has_role? @role

-      flash[:error] = t('user_role.filter.already_has_role', :role => @role)
-      redirect_to :controller => 'user', :action => 'view', :display_name => @this_user.display_name
+      flash[:error] = t("user_role.filter.already_has_role", :role => @role)
+      redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name

     end
   end
 
     end
   end
 


@@ -56,8 +55,8 @@ class UserRolesController < ApplicationController
   # checks that the user already has this role
   def in_role
     unless @this_user.has_role? @role
   # checks that the user already has this role
   def in_role
     unless @this_user.has_role? @role

-      flash[:error] = t('user_role.filter.doesnt_have_role', :role => @role)
-      redirect_to :controller => 'user', :action => 'view', :display_name => @this_user.display_name
+      flash[:error] = t("user_role.filter.doesnt_have_role", :role => @role)
+      redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name

     end
   end
 end
     end
   end
 end