Fix new rubocop warnings

[rails.git] / app / helpers / browse_helper.rb

diff --git a/app/helpers/browse_helper.rb b/app/helpers/browse_helper.rb
index ffc638cdf491a6c7a22d57f420568f0ed173faa7..69a8f8fa2e57eb5b76a717f98506c5f4752c33da 100644 (file)
--- a/app/helpers/browse_helper.rb
+++ b/app/helpers/browse_helper.rb
@@ -1,121 +1,119 @@
 module BrowseHelper
 module BrowseHelper

-  def link_to_page(page, page_param)
-    return link_to(page, page_param => page)
+  def element_single_current_link(type, object)
+    link_to object, { :class => element_class(type, object), :title => element_title(object), :rel => (link_follow(object) if type == "node") } do
+      element_strikethrough object do
+        printable_element_name object
+      end
+    end

   end
 
   end
 

-  def printable_name(object, version=false)
-    if object.id.is_a?(Array)
-      id = object.id[0]
-    else
-      id = object.id
-    end
-    name = t 'printable_name.with_id', :id => id.to_s
-    if version
-      name = t 'printable_name.with_version', :id => name, :version => object.version.to_s
+  def element_list_item(type, object, &block)
+    tag.li :class => element_class(type, object), :title => element_title(object) do
+      element_strikethrough object, &block

     end
     end

+  end
+
+  def printable_element_name(object)
+    id = if object.id.is_a?(Array)
+           object.id[0]
+         else
+           object.id
+         end
+    name = id.to_s

 
 

-    # don't look at object tags if redacted, so as to avoid giving 
+    # don't look at object tags if redacted, so as to avoid giving

     # away redacted version tag information.
     unless object.redacted?
     # away redacted version tag information.
     unless object.redacted?

-      if object.tags.include? "name:#{I18n.locale}"
-        name = t 'printable_name.with_name',  :name => object.tags["name:#{I18n.locale}"].to_s, :id => name
-      elsif object.tags.include? 'name'
-        name = t 'printable_name.with_name',  :name => object.tags['name'].to_s, :id => name
+      available_locales = Locale.list(name_locales(object))
+
+      locale = available_locales.preferred(preferred_languages, :default => nil)
+
+      if object.tags.include? "name:#{locale}"
+        name = t "printable_name.with_name_html", :name => tag.bdi(object.tags["name:#{locale}"].to_s), :id => tag.bdi(name)
+      elsif object.tags.include? "name"
+        name = t "printable_name.with_name_html", :name => tag.bdi(object.tags["name"].to_s), :id => tag.bdi(name)
+      elsif object.tags.include? "ref"
+        name = t "printable_name.with_name_html", :name => tag.bdi(object.tags["ref"].to_s), :id => tag.bdi(name)

       end
     end
 
       end
     end
 

-    return name
+    name

   end
 
   end
 

-  def link_class(type, object)
-    if object.redacted?
-      type + " deleted"
+  def printable_element_version(object)
+    t "printable_name.version", :version => object.version
+  end
+
+  def element_strikethrough(object, &)
+    if object.redacted? || !object.visible?
+      tag.s(&)

     else
     else

-      type + " " + h(icon_tags(object).join(' ')) + (object.visible == false ? ' deleted' : '')
+      yield

     end
   end
 
     end
   end
 

-  def link_title(object)
+  def element_class(type, object)
+    classes = [type]
+    classes += icon_tags(object).flatten.map { |t| h(t) } unless object.redacted?
+    classes.join(" ")
+  end
+
+  def element_title(object)

     if object.redacted?
       ""
     else
     if object.redacted?
       ""
     else

-      h(icon_tags(object).map { |k,v| k + '=' + v }.to_sentence)
+      h(icon_tags(object).map { |k, v| "#{k}=#{v}" }.to_sentence)

     end
   end
 
     end
   end
 

-  def format_key(key)
-    if url = wiki_link("key", key)
-      link_to h(key), url, :title => t('browse.tag_details.wiki_link.key', :key => key)
-    else
-      h(key)
-    end
+  def link_follow(object)
+    "nofollow" if object.tags.empty?

   end
 
   end
 

-  def format_value(key, value)
-    if wp = wikipedia_link(key, value)
-      link_to h(wp[:title]), wp[:url], :title => t('browse.tag_details.wikipedia_link', :page => wp[:title])
-    elsif url = wiki_link("tag", "#{key}=#{value}")
-      link_to h(value), url, :title => t('browse.tag_details.wiki_link.tag', :key => key, :value => value)
+  def type_and_paginated_count(type, pages, selected_page = pages.current_page)
+    if pages.page_count == 1
+      t ".#{type.pluralize}",
+        :count => pages.item_count

     else
     else

-      linkify h(value)
+      t ".#{type.pluralize}_paginated",
+        :x => selected_page.first_item,
+        :y => selected_page.last_item,
+        :count => pages.item_count

     end
   end
 
     end
   end
 

-private
-
-  ICON_TAGS = [ 
-    "aeroway", "amenity", "barrier", "building", "highway", "historic", "landuse",
-    "leisure", "man_made", "natural", "railway", "shop", "tourism", "waterway"
-  ]
+  def sidebar_classic_pagination(pages, page_param)
+    max_width_for_default_padding = 35

 
 

-  def icon_tags(object)
-    object.tags.find_all { |k,v| ICON_TAGS.include? k }
+    width = 0
+    pagination_items(pages, {}).each do |(body)|
+      width += 2 # padding width
+      width += body.length
+    end
+    link_classes = ["page-link", { "px-1" => width > max_width_for_default_padding }]
+
+    tag.ul :class => "pagination pagination-sm mb-2" do
+      pagination_items(pages, {}).each do |body, page_or_class|
+        linked = !(page_or_class.is_a? String)
+        link = if linked
+                 link_to body, url_for(page_param => page_or_class.number), :class => link_classes, **yield(page_or_class)
+               else
+                 tag.span body, :class => link_classes
+               end
+        concat tag.li link, :class => ["page-item", { page_or_class => !linked }]
+      end
+    end

   end
 
   end
 

-  def wiki_link(type, lookup)
-    locale = I18n.locale.to_s
+  private

 
 

-    # update-wiki-pages does s/ /_/g on keys before saving them, we
-    # have to replace spaces with underscore so we'll link
-    # e.g. `source=Isle of Man Government aerial imagery (2001)' to
-    # the correct page.
-    lookup_us = lookup.tr(" ", "_")
+  ICON_TAGS = %w[aeroway amenity barrier building highway historic landuse leisure man_made natural office railway shop tourism waterway].freeze

 
 

-    if page = WIKI_PAGES[locale][type][lookup_us] rescue nil
-      url = "http://wiki.openstreetmap.org/wiki/#{page}?uselang=#{locale}"
-    elsif page = WIKI_PAGES["en"][type][lookup_us] rescue nil
-      url = "http://wiki.openstreetmap.org/wiki/#{page}?uselang=#{locale}"
-    end
-
-    return url
+  def icon_tags(object)
+    object.tags.find_all { |k, _v| ICON_TAGS.include? k }.sort

   end
 
   end
 

-  def wikipedia_link(key, value)
-    # Some k/v's are wikipedia=http://en.wikipedia.org/wiki/Full%20URL
-    return nil if value =~ /^https?:\/\//
-
-    if key == "wikipedia"
-      # This regex should match Wikipedia language codes, everything
-      # from de to zh-classical
-      if value =~ /^([a-z-]{2,12}):(.+)$/
-        # Value is <lang>:<title> so split it up
-        lang  = $1
-        value = $2
-      else
-        # Value is <title> so default to English Wikipedia
-        lang = 'en'
-      end
-    elsif key =~ /^wikipedia:(\S+)$/
-      # Language is in the key, so assume value is a simple title
-      lang = $1
-    else
-      # Not a wikipedia key!
-      return nil
-    end
-
-    return {
-      :url => "http://#{lang}.wikipedia.org/wiki/#{value}?uselang=#{I18n.locale}",
-      :title => value
-    }
+  def name_locales(object)
+    object.tags.keys.map { |k| Regexp.last_match(1) if k =~ /^name:(.*)$/ }.flatten

   end
 end
   end
 end