Merge remote-tracking branch 'upstream/pull/4050'

[rails.git] / lib / nominatim.rb

diff --git a/lib/nominatim.rb b/lib/nominatim.rb
index 33a0c3e26ac04e7297355414a29916effb4f2871..adb041da43857799d2bdbea0a8a1c018e1d536e6 100644 (file)
--- a/lib/nominatim.rb
+++ b/lib/nominatim.rb
@@ -1,23 +1,25 @@
 module Nominatim
 module Nominatim

+  require "timeout"
+

   extend ActionView::Helpers::NumberHelper
 
   def self.describe_location(lat, lon, zoom = nil, language = nil)
   extend ActionView::Helpers::NumberHelper
 
   def self.describe_location(lat, lon, zoom = nil, language = nil)

-    zoom = zoom || 14
-    language = language || http_accept_language.user_preferred_languages.join(',')
+    zoom ||= 14
+    language ||= http_accept_language.user_preferred_languages.join(",")

 
     Rails.cache.fetch "/nominatim/location/#{lat}/#{lon}/#{zoom}/#{language}" do
 
     Rails.cache.fetch "/nominatim/location/#{lat}/#{lon}/#{zoom}/#{language}" do

-      url = "http://nominatim.openstreetmap.org/reverse?lat=#{lat}&lon=#{lon}&zoom=#{zoom}&accept-language=#{language}"
+      url = "#{Settings.nominatim_url}reverse?lat=#{lat}&lon=#{lon}&zoom=#{zoom}&accept-language=#{language}"

 
       begin
 
       begin

-        response = OSM::Timer.timeout(4) do
+        response = Timeout.timeout(4) do

           REXML::Document.new(Net::HTTP.get(URI.parse(url)))
         end
           REXML::Document.new(Net::HTTP.get(URI.parse(url)))
         end

-      rescue Exception
+      rescue StandardError

         response = nil
       end
 
         response = nil
       end
 

-      if response and result = response.get_text("reversegeocode/result")
-        result.to_s
+      if response && result = response.get_text("reversegeocode/result")
+        result.value

       else
         "#{number_with_precision(lat, :precision => 3)}, #{number_with_precision(lon, :precision => 3)}"
       end
       else
         "#{number_with_precision(lat, :precision => 3)}, #{number_with_precision(lon, :precision => 3)}"
       end