Fix rubocop warnings

[rails.git] / app / controllers / search_controller.rb

diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb
index b3e7ca97b63a2068ba18e7ff206e52b3b1893862..8a632e6a2c2cebd9526afec79371a91cddc6e0fb 100644 (file)
--- a/app/controllers/search_controller.rb
+++ b/app/controllers/search_controller.rb
@@ -2,93 +2,97 @@ class SearchController < ApplicationController
   # Support searching for nodes, ways, or all
   # Can search by tag k, v, or both (type->k,value->v)
   # Can search by name (k=name,v=....)
-
-  after_filter :compress_output
+  skip_before_action :verify_authenticity_token
 
   def search_all
-    do_search(true,true)
+    do_search(true, true, true)
   end
 
   def search_ways
-    do_search(true,false)
+    do_search(true, false, false)
   end
+
   def search_nodes
-    do_search(false,true)
+    do_search(false, true, false)
   end
 
+  def search_relations
+    do_search(false, false, true)
+  end
 
-  def do_search(do_ways,do_nodes)
-    type = params['type']
-    value = params['value']
-    unless type or value
-      name = params['name']
+  def do_search(do_ways, do_nodes, do_relations)
+    type = params["type"]
+    value = params["value"]
+    unless type || value
+      name = params["name"]
       if name
-        type = 'name'
+        type = "name"
         value = name
       end
     end
 
-    way_ids = Array.new
-    ways = Array.new
-    nodes = Array.new
-
-    # Matching for tags table
-    cond_tbl = Array.new
-    sql = 'id IN (SELECT id FROM current_way_tags WHERE 1=1'
-    if type
-      sql += ' AND k=?'
-      cond_tbl += [type]
+    if do_nodes
+      response.headers["Error"] = "Searching of nodes is currently unavailable"
+      render :text => "", :status => :service_unavailable
+      return false
     end
-    if value
-      sql += ' AND v=?'
-      cond_tbl += [value]
+
+    unless value
+      response.headers["Error"] = "Searching for a key without value is currently unavailable"
+      render :text => "", :status => :service_unavailable
+      return false
     end
-    sql += ')'
-    cond_tbl = [sql] + cond_tbl
 
-    # Matching for tags column
-    if type and value
-      cond_tags = ['tags LIKE ? OR tags LIKE ? OR tags LIKE ? OR tags LIKE ?', 
-      ''+type+'='+value+'',
-      ''+type+'='+value+';%',
-      '%;'+type+'='+value+';%',
-      '%;'+type+'='+value+'' ]
-    elsif type
-      cond_tags = ['tags LIKE ? OR tags LIKE ?',
-      ''+type+'=%',
-      '%;'+type+'=%' ]
-    elsif value
-      cond_tags = ['tags LIKE ? OR tags LIKE ?',
-      '%='+value+';%',
-      '%='+value+'' ]
+    # Matching for node tags table
+    if do_nodes
+      nodes = Node.joins(:node_tags)
+      nodes = nodes.where(:current_node_tags => { :k => type }) if type
+      nodes = nodes.where(:current_node_tags => { :v => value }) if value
+      nodes = nodes.limit(100)
     else
-      cond_tags = ['1=1']
+      nodes = []
     end
 
-
-    # First up, look for the ways we want
+    # Matching for way tags table
     if do_ways
-      ways = Way.find(:all, :conditions => cond_tbl, :limit => 100)
+      ways = Way.joins(:way_tags)
+      ways = ways.where(:current_way_tags => { :k => type }) if type
+      ways = ways.where(:current_way_tags => { :v => value }) if value
+      ways = ways.limit(100)
+    else
+      ways = []
     end
 
-    # Now, nodes
-    if do_nodes
-      nodes = Node.find(:all, :conditions => cond_tags, :limit => 2000)
+    # Matching for relation tags table
+    if do_relations
+      relations = Relation.joins(:relation_tags)
+      relations = relations.where(:current_relation_tags => { :k => type }) if type
+      relations = relations.where(:current_relation_tags => { :v => value }) if value
+      relations = relations.limit(2000)
+    else
+      relations = []
     end
 
     # Fetch any node needed for our ways (only have matching nodes so far)
-    nodes += Node.find(ways.collect { |w| w.nds }.uniq)
+    nodes += Node.find(ways.collect(&:nds).uniq)
 
     # Print
+    visible_nodes = {}
+    changeset_cache = {}
     user_display_name_cache = {}
     doc = OSM::API.new.get_xml_doc
     nodes.each do |node|
-      doc.root << node.to_xml_node(user_display_name_cache)
+      doc.root << node.to_xml_node(changeset_cache, user_display_name_cache)
+      visible_nodes[node.id] = node
     end
 
     ways.each do |way|
-      doc.root << way.to_xml_node(user_display_name_cache)
-    end 
+      doc.root << way.to_xml_node(visible_nodes, changeset_cache, user_display_name_cache)
+    end
+
+    relations.each do |rel|
+      doc.root << rel.to_xml_node(nil, changeset_cache, user_display_name_cache)
+    end
 
     render :text => doc.to_s, :content_type => "text/xml"
   end