Merge pull request #5558 from tomhughes/var-let-const

[rails.git] / app / assets / javascripts / index.js

diff --git a/app/assets/javascripts/index.js b/app/assets/javascripts/index.js
index c3ee1e3bc9b47729faab64ad478d6a7818cbabb4..194ed82f7451098bd318d63a661a2b35221087c0 100644 (file)
--- a/app/assets/javascripts/index.js
+++ b/app/assets/javascripts/index.js
@@ -21,10 +21,11 @@
 //= require index/directions
 //= require index/changeset
 //= require index/query
 //= require index/directions
 //= require index/changeset
 //= require index/query

+//= require index/home

 //= require router
 
 $(document).ready(function () {
 //= require router
 
 $(document).ready(function () {

-  var map = new L.OSM.Map("map", {
+  const map = new L.OSM.Map("map", {

     zoomControl: false,
     layerControl: false,
     contextmenu: true,
     zoomControl: false,
     layerControl: false,
     contextmenu: true,


@@ -32,12 +33,20 @@ $(document).ready(function () {
   });
 
   OSM.loadSidebarContent = function (path, callback) {
   });
 
   OSM.loadSidebarContent = function (path, callback) {

-    var content_path = path;
+    let content_path = path;

 
     map.setSidebarOverlaid(false);
 
     $("#sidebar_loader").show().addClass("delayed-fade-in");
 
 
     map.setSidebarOverlaid(false);
 
     $("#sidebar_loader").show().addClass("delayed-fade-in");
 

+    // Prevent caching the XHR response as a full-page URL
+    // https://github.com/openstreetmap/openstreetmap-website/issues/5663
+    if (content_path.indexOf("?") >= 0) {
+      content_path += "&xhr=1";
+    } else {
+      content_path += "?xhr=1";
+    }
+

     $("#sidebar_content")
       .empty();
 
     $("#sidebar_content")
       .empty();
 


@@ -69,7 +78,7 @@ $(document).ready(function () {
       });
   };
 
       });
   };
 

-  var params = OSM.mapParams();
+  const params = OSM.mapParams();

 
   map.attributionControl.setPrefix("");
 
 
   map.attributionControl.setPrefix("");
 


@@ -81,19 +90,19 @@ $(document).ready(function () {
     }
   });
 
     }
   });
 

-  var sidebar = L.OSM.sidebar("#map-ui")
+  const sidebar = L.OSM.sidebar("#map-ui")

     .addTo(map);
 
     .addTo(map);
 

-  var position = $("html").attr("dir") === "rtl" ? "topleft" : "topright";
+  const position = $("html").attr("dir") === "rtl" ? "topleft" : "topright";

 
   function addControlGroup(controls) {
     for (const control of controls) control.addTo(map);
 
 
   function addControlGroup(controls) {
     for (const control of controls) control.addTo(map);
 

-    var firstContainer = controls[0].getContainer();
+    const firstContainer = controls[0].getContainer();

     $(firstContainer).find(".control-button").first()
       .addClass("control-button-first");
 
     $(firstContainer).find(".control-button").first()
       .addClass("control-button-first");
 

-    var lastContainer = controls[controls.length - 1].getContainer();
+    const lastContainer = controls[controls.length - 1].getContainer();

     $(lastContainer).find(".control-button").last()
       .addClass("control-button-last");
   }
     $(lastContainer).find(".control-button").last()
       .addClass("control-button-last");
   }


@@ -157,7 +166,7 @@ $(document).ready(function () {
 
   $(".leaflet-control .control-button").tooltip({ placement: "left", container: "body" });
 
 
   $(".leaflet-control .control-button").tooltip({ placement: "left", container: "body" });
 

-  var expiry = new Date();
+  const expiry = new Date();

   expiry.setYear(expiry.getFullYear() + 10);
 
   map.on("moveend baselayerchange overlayadd overlayremove", function () {
   expiry.setYear(expiry.getFullYear() + 10);
 
   map.on("moveend baselayerchange overlayadd overlayremove", function () {


@@ -179,11 +188,11 @@ $(document).ready(function () {
     Cookies.set("_osm_welcome", "hide", { secure: true, expires: expiry, path: "/", samesite: "lax" });
   });
 
     Cookies.set("_osm_welcome", "hide", { secure: true, expires: expiry, path: "/", samesite: "lax" });
   });
 

-  var bannerExpiry = new Date();
+  const bannerExpiry = new Date();

   bannerExpiry.setYear(bannerExpiry.getFullYear() + 1);
 
   $("#banner .btn-close").on("click", function (e) {
   bannerExpiry.setYear(bannerExpiry.getFullYear() + 1);
 
   $("#banner .btn-close").on("click", function (e) {

-    var cookieId = e.target.id;
+    const cookieId = e.target.id;

     $("#banner").hide();
     e.preventDefault();
     if (cookieId) {
     $("#banner").hide();
     e.preventDefault();
     if (cookieId) {


@@ -194,7 +203,7 @@ $(document).ready(function () {
   if (OSM.MATOMO) {
     map.on("baselayerchange overlayadd", function (e) {
       if (e.layer.options) {
   if (OSM.MATOMO) {
     map.on("baselayerchange overlayadd", function (e) {
       if (e.layer.options) {

-        var goal = OSM.MATOMO.goals[e.layer.options.layerId];
+        const goal = OSM.MATOMO.goals[e.layer.options.layerId];

 
         if (goal) {
           $("body").trigger("matomogoal", goal);
 
         if (goal) {
           $("body").trigger("matomogoal", goal);


@@ -213,25 +222,15 @@ $(document).ready(function () {
     L.marker([params.mlat, params.mlon]).addTo(map);
   }
 
     L.marker([params.mlat, params.mlon]).addTo(map);
   }
 

-  $("#homeanchor").on("click", function (e) {
-    e.preventDefault();
-
-    var data = $(this).data(),
-        center = L.latLng(data.lat, data.lon);
-
-    map.setView(center, data.zoom);
-    L.marker(center, { icon: OSM.getUserIcon() }).addTo(map);
-  });
-

   function remoteEditHandler(bbox, object) {
   function remoteEditHandler(bbox, object) {

-    var remoteEditHost = "http://127.0.0.1:8111",
-        osmHost = location.protocol + "//" + location.host,
-        query = new URLSearchParams({
-          left: bbox.getWest() - 0.0001,
-          top: bbox.getNorth() + 0.0001,
-          right: bbox.getEast() + 0.0001,
-          bottom: bbox.getSouth() - 0.0001
-        });
+    const remoteEditHost = "http://127.0.0.1:8111",
+          osmHost = location.protocol + "//" + location.host,
+          query = new URLSearchParams({
+            left: bbox.getWest() - 0.0001,
+            top: bbox.getNorth() + 0.0001,
+            right: bbox.getEast() + 0.0001,
+            bottom: bbox.getSouth() - 0.0001
+          });

 
     if (object && object.type !== "note") query.set("select", object.type + object.id); // can't select notes
     sendRemoteEditCommand(remoteEditHost + "/load_and_zoom?" + query, function () {
 
     if (object && object.type !== "note") query.set("select", object.type + object.id); // can't select notes
     sendRemoteEditCommand(remoteEditHost + "/load_and_zoom?" + query, function () {


@@ -254,7 +253,7 @@ $(document).ready(function () {
   }
 
   $("a[data-editor=remote]").click(function (e) {
   }
 
   $("a[data-editor=remote]").click(function (e) {

-    var params = OSM.mapParams(this.search);
+    const params = OSM.mapParams(this.search);

     remoteEditHandler(map.getBounds(), params.object);
     e.preventDefault();
   });
     remoteEditHandler(map.getBounds(), params.object);
     e.preventDefault();
   });


@@ -274,7 +273,7 @@ $(document).ready(function () {
   }
 
   OSM.Index = function (map) {
   }
 
   OSM.Index = function (map) {

-    var page = {};
+    const page = {};

 
     page.pushstate = page.popstate = function () {
       map.setSidebarOverlaid(true);
 
     page.pushstate = page.popstate = function () {
       map.setSidebarOverlaid(true);


@@ -296,7 +295,7 @@ $(document).ready(function () {
   };
 
   OSM.Browse = function (map, type) {
   };
 
   OSM.Browse = function (map, type) {

-    var page = {};
+    const page = {};

 
     page.pushstate = page.popstate = function (path, id) {
       OSM.loadSidebarContent(path, function () {
 
     page.pushstate = page.popstate = function (path, id) {
       OSM.loadSidebarContent(path, function () {


@@ -309,8 +308,9 @@ $(document).ready(function () {
     };
 
     function addObject(type, id, center) {
     };
 
     function addObject(type, id, center) {

+      const hashParams = OSM.parseHash(window.location.hash);

       map.addObject({ type: type, id: parseInt(id, 10) }, function (bounds) {
       map.addObject({ type: type, id: parseInt(id, 10) }, function (bounds) {

-        if (!window.location.hash && bounds.isValid() &&
+        if (!hashParams.center && bounds.isValid() &&

             (center || !map.getBounds().contains(bounds))) {
           OSM.router.withoutMoveListener(function () {
             map.fitBounds(bounds);
             (center || !map.getBounds().contains(bounds))) {
           OSM.router.withoutMoveListener(function () {
             map.fitBounds(bounds);


@@ -327,7 +327,7 @@ $(document).ready(function () {
   };
 
   OSM.OldBrowse = function () {
   };
 
   OSM.OldBrowse = function () {

-    var page = {};
+    const page = {};

 
     page.pushstate = page.popstate = function (path) {
       OSM.loadSidebarContent(path);
 
     page.pushstate = page.popstate = function (path) {
       OSM.loadSidebarContent(path);


@@ -336,7 +336,7 @@ $(document).ready(function () {
     return page;
   };
 
     return page;
   };
 

-  var history = OSM.History(map);
+  const history = OSM.History(map);

 
   OSM.router = OSM.Router(map, {
     "/": OSM.Index(map),
 
   OSM.router = OSM.Router(map, {
     "/": OSM.Index(map),


@@ -356,7 +356,8 @@ $(document).ready(function () {
     "/relation/:id(/history)": OSM.Browse(map, "relation"),
     "/relation/:id/history/:version": OSM.OldBrowse(),
     "/changeset/:id": OSM.Changeset(map),
     "/relation/:id(/history)": OSM.Browse(map, "relation"),
     "/relation/:id/history/:version": OSM.OldBrowse(),
     "/changeset/:id": OSM.Changeset(map),

-    "/query": OSM.Query(map)
+    "/query": OSM.Query(map),
+    "/account/home": OSM.Home(map)

   });
 
   if (OSM.preferred_editor === "remote" && document.location.pathname === "/edit") {
   });
 
   if (OSM.preferred_editor === "remote" && document.location.pathname === "/edit") {