Merge pull request #5093 from AntonKhorev/diary-comments-shallow-paths

[rails.git] / app / models / changeset.rb

diff --git a/app/models/changeset.rb b/app/models/changeset.rb
index 47f03c79544111eff476896c076d2cae2b6c31fb..e6bde19a50d8562f63e12e44be146a72e5905ac9 100644 (file)
--- a/app/models/changeset.rb
+++ b/app/models/changeset.rb
@@ -14,18 +14,19 @@
 #
 # Indexes
 #
 #
 # Indexes
 #

-#  changesets_bbox_idx                (min_lat,max_lat,min_lon,max_lon) USING gist
-#  changesets_closed_at_idx           (closed_at)
-#  changesets_created_at_idx          (created_at)
-#  changesets_user_id_created_at_idx  (user_id,created_at)
-#  changesets_user_id_id_idx          (user_id,id)
+#  changesets_bbox_idx                        (min_lat,max_lat,min_lon,max_lon) USING gist
+#  changesets_closed_at_idx                   (closed_at)
+#  changesets_created_at_idx                  (created_at)
+#  changesets_user_id_created_at_idx          (user_id,created_at)
+#  changesets_user_id_id_idx                  (user_id,id)
+#  index_changesets_on_user_id_and_closed_at  (user_id,closed_at)

 #
 # Foreign Keys
 #
 #  changesets_user_id_fkey  (user_id => users.id)
 #
 
 #
 # Foreign Keys
 #
 #  changesets_user_id_fkey  (user_id => users.id)
 #
 

-class Changeset < ActiveRecord::Base
+class Changeset < ApplicationRecord

   require "xml/libxml"
 
   belongs_to :user, :counter_cache => true
   require "xml/libxml"
 
   belongs_to :user, :counter_cache => true


@@ -44,8 +45,6 @@ class Changeset < ActiveRecord::Base
 
   validates :id, :uniqueness => true, :presence => { :on => :update },
                  :numericality => { :on => :update, :only_integer => true }
 
   validates :id, :uniqueness => true, :presence => { :on => :update },
                  :numericality => { :on => :update, :only_integer => true }

-  validates :user_id, :presence => true,
-                      :numericality => { :only_integer => true }

   validates :num_changes, :presence => true,
                           :numericality => { :only_integer => true,
                                              :greater_than_or_equal_to => 0 }
   validates :num_changes, :presence => true,
                           :numericality => { :only_integer => true,
                                              :greater_than_or_equal_to => 0 }


@@ -67,35 +66,37 @@ class Changeset < ActiveRecord::Base
   # Use a method like this, so that we can easily change how we
   # determine whether a changeset is open, without breaking code in at
   # least 6 controllers
   # Use a method like this, so that we can easily change how we
   # determine whether a changeset is open, without breaking code in at
   # least 6 controllers

-  def is_open?
+  def open?

     # a changeset is open (that is, it will accept further changes) when
     # it has not yet run out of time and its capacity is small enough.
     # note that this may not be a hard limit - due to timing changes and
     # concurrency it is possible that some changesets may be slightly
     # longer than strictly allowed or have slightly more changes in them.
     # a changeset is open (that is, it will accept further changes) when
     # it has not yet run out of time and its capacity is small enough.
     # note that this may not be a hard limit - due to timing changes and
     # concurrency it is possible that some changesets may be slightly
     # longer than strictly allowed or have slightly more changes in them.

-    ((closed_at > Time.now.getutc) && (num_changes <= MAX_ELEMENTS))
+    (closed_at > Time.now.utc) && (num_changes <= MAX_ELEMENTS)

   end
 
   def set_closed_time_now
   end
 
   def set_closed_time_now

-    self.closed_at = Time.now.getutc if is_open?
+    self.closed_at = Time.now.utc if open?

   end
 
   end
 

-  def self.from_xml(xml, create = false)
+  def self.from_xml(xml, create: false)

     p = XML::Parser.string(xml, :options => XML::Parser::Options::NOERROR)
     doc = p.parse
     p = XML::Parser.string(xml, :options => XML::Parser::Options::NOERROR)
     doc = p.parse

+    pt = doc.find_first("//osm/changeset")

 
 

-    doc.find("//osm/changeset").each do |pt|
-      return Changeset.from_xml_node(pt, create)
+    if pt
+      Changeset.from_xml_node(pt, :create => create)
+    else
+      raise OSM::APIBadXMLError.new("changeset", xml, "XML doesn't contain an osm/changeset element.")

     end
     end

-    raise OSM::APIBadXMLError.new("changeset", xml, "XML doesn't contain an osm/changeset element.")

   rescue LibXML::XML::Error, ArgumentError => e
     raise OSM::APIBadXMLError.new("changeset", xml, e.message)
   end
 
   rescue LibXML::XML::Error, ArgumentError => e
     raise OSM::APIBadXMLError.new("changeset", xml, e.message)
   end
 

-  def self.from_xml_node(pt, create = false)
+  def self.from_xml_node(pt, create: false)

     cs = Changeset.new
     if create
     cs = Changeset.new
     if create

-      cs.created_at = Time.now.getutc
+      cs.created_at = Time.now.utc

       # initial close time is 1h ahead, but will be increased on each
       # modification.
       cs.closed_at = cs.created_at + IDLE_TIMEOUT
       # initial close time is 1h ahead, but will be increased on each
       # modification.
       cs.closed_at = cs.created_at + IDLE_TIMEOUT


@@ -120,7 +121,7 @@ class Changeset < ActiveRecord::Base
     @bbox ||= BoundingBox.new(min_lon, min_lat, max_lon, max_lat)
   end
 
     @bbox ||= BoundingBox.new(min_lon, min_lat, max_lon, max_lat)
   end
 

-  def has_valid_bbox?
+  def bbox_valid?

     bbox.complete?
   end
 
     bbox.complete?
   end
 


@@ -129,6 +130,8 @@ class Changeset < ActiveRecord::Base
   def update_bbox!(bbox_update)
     bbox.expand!(bbox_update)
 
   def update_bbox!(bbox_update)
     bbox.expand!(bbox_update)
 

+    raise OSM::APISizeLimitExceeded if bbox.linear_size > size_limit
+

     # update active record. rails 2.1's dirty handling should take care of
     # whether this object needs saving or not.
     self.min_lon, self.min_lat, self.max_lon, self.max_lat = @bbox.to_a.collect(&:round) if bbox.complete?
     # update active record. rails 2.1's dirty handling should take care of
     # whether this object needs saving or not.
     self.min_lon, self.min_lat, self.max_lon, self.max_lat = @bbox.to_a.collect(&:round) if bbox.complete?


@@ -170,7 +173,7 @@ class Changeset < ActiveRecord::Base
       save!
 
       tags = self.tags
       save!
 
       tags = self.tags

-      ChangesetTag.where(:changeset_id => id).delete_all
+      ChangesetTag.where(:changeset => id).delete_all

 
       tags.each do |k, v|
         tag = ChangesetTag.new
 
       tags.each do |k, v|
         tag = ChangesetTag.new


@@ -187,11 +190,11 @@ class Changeset < ActiveRecord::Base
   # that would make it more than 24h long, in which case clip to
   # 24h, as this has been decided is a reasonable time limit.
   def update_closed_at
   # that would make it more than 24h long, in which case clip to
   # 24h, as this has been decided is a reasonable time limit.
   def update_closed_at

-    if is_open?
+    if open?

       self.closed_at = if (closed_at - created_at) > (MAX_TIME_OPEN - IDLE_TIMEOUT)
                          created_at + MAX_TIME_OPEN
                        else
       self.closed_at = if (closed_at - created_at) > (MAX_TIME_OPEN - IDLE_TIMEOUT)
                          created_at + MAX_TIME_OPEN
                        else

-                         Time.now.getutc + IDLE_TIMEOUT
+                         Time.now.utc + IDLE_TIMEOUT

                        end
     end
   end
                        end
     end
   end


@@ -205,11 +208,29 @@ class Changeset < ActiveRecord::Base
     raise OSM::APIUserChangesetMismatchError unless user.id == user_id
 
     # can't change a closed changeset
     raise OSM::APIUserChangesetMismatchError unless user.id == user_id
 
     # can't change a closed changeset

-    raise OSM::APIChangesetAlreadyClosedError, self unless is_open?
+    raise OSM::APIChangesetAlreadyClosedError, self unless open?

 
     # copy the other's tags
     self.tags = other.tags
 
     save_with_tags!
   end
 
     # copy the other's tags
     self.tags = other.tags
 
     save_with_tags!
   end

+
+  def subscribe(user)
+    subscribers << user
+  end
+
+  def unsubscribe(user)
+    subscribers.delete(user)
+  end
+
+  def subscribed?(user)
+    subscribers.exists?(user.id)
+  end
+
+  def size_limit
+    @size_limit ||= ActiveRecord::Base.connection.select_value(
+      "SELECT api_size_limit($1)", "api_size_limit", [user_id]
+    )
+  end

 end
 end