Merge remote-tracking branch 'upstream/pull/2136'

[rails.git] / test / models / trace_test.rb

diff --git a/test/models/trace_test.rb b/test/models/trace_test.rb
index 1cb94aeef247eb1e3b4b7d28cc1ad4cb1415bc2b..2ab1a3d5a4da50c3e770b1183c30d0b5de2f6c07 100644 (file)
--- a/test/models/trace_test.rb
+++ b/test/models/trace_test.rb
@@ -1,19 +1,19 @@
 require "test_helper"
 require "test_helper"

-require "digest"

 require "minitest/mock"
 
 class TraceTest < ActiveSupport::TestCase
 require "minitest/mock"
 
 class TraceTest < ActiveSupport::TestCase

-  fixtures :users
-

   def setup
     @gpx_trace_dir = Object.send("remove_const", "GPX_TRACE_DIR")
   def setup
     @gpx_trace_dir = Object.send("remove_const", "GPX_TRACE_DIR")

-    Object.const_set("GPX_TRACE_DIR", File.dirname(__FILE__) + "/../traces")
+    Object.const_set("GPX_TRACE_DIR", Rails.root.join("test", "gpx", "traces"))

 
     @gpx_image_dir = Object.send("remove_const", "GPX_IMAGE_DIR")
 
     @gpx_image_dir = Object.send("remove_const", "GPX_IMAGE_DIR")

-    Object.const_set("GPX_IMAGE_DIR", File.dirname(__FILE__) + "/../traces")
+    Object.const_set("GPX_IMAGE_DIR", Rails.root.join("test", "gpx", "images"))

   end
 
   def teardown
   end
 
   def teardown

+    File.unlink(*Dir.glob(File.join(GPX_TRACE_DIR, "*.gpx")))
+    File.unlink(*Dir.glob(File.join(GPX_IMAGE_DIR, "*.gif")))
+

     Object.send("remove_const", "GPX_TRACE_DIR")
     Object.const_set("GPX_TRACE_DIR", @gpx_trace_dir)
 
     Object.send("remove_const", "GPX_TRACE_DIR")
     Object.const_set("GPX_TRACE_DIR", @gpx_trace_dir)
 


@@ -28,21 +28,25 @@ class TraceTest < ActiveSupport::TestCase
   end
 
   def test_visible_to
   end
 
   def test_visible_to

-    public_trace_file = create(:trace, :visibility => "public", :user => users(:normal_user))
-    anon_trace_file = create(:trace, :visibility => "private", :user => users(:public_user))
-    identifiable_trace_file = create(:trace, :visibility => "identifiable", :user => users(:normal_user))
-    pending_trace_file = create(:trace, :visibility => "public", :user => users(:public_user), :inserted => false)
-    trackable_trace_file = create(:trace, :visibility => "trackable", :user => users(:public_user))
-    _other_trace_file = create(:trace, :visibility => "private", :user => users(:second_public_user))
-
-    check_query(Trace.visible_to(users(:normal_user).id), [
+    first_user = create(:user)
+    second_user = create(:user)
+    third_user = create(:user)
+    fourth_user = create(:user)
+    public_trace_file = create(:trace, :visibility => "public", :user => first_user)
+    anon_trace_file = create(:trace, :visibility => "private", :user => second_user)
+    identifiable_trace_file = create(:trace, :visibility => "identifiable", :user => first_user)
+    pending_trace_file = create(:trace, :visibility => "public", :user => second_user, :inserted => false)
+    trackable_trace_file = create(:trace, :visibility => "trackable", :user => second_user)
+    _other_trace_file = create(:trace, :visibility => "private", :user => third_user)
+
+    check_query(Trace.visible_to(first_user), [

                   public_trace_file, identifiable_trace_file, pending_trace_file
                 ])
                   public_trace_file, identifiable_trace_file, pending_trace_file
                 ])

-    check_query(Trace.visible_to(users(:public_user)), [
+    check_query(Trace.visible_to(second_user), [

                   public_trace_file, anon_trace_file, trackable_trace_file,
                   identifiable_trace_file, pending_trace_file
                 ])
                   public_trace_file, anon_trace_file, trackable_trace_file,
                   identifiable_trace_file, pending_trace_file
                 ])

-    check_query(Trace.visible_to(users(:inactive_user)), [
+    check_query(Trace.visible_to(fourth_user), [

                   public_trace_file, identifiable_trace_file, pending_trace_file
                 ])
   end
                   public_trace_file, identifiable_trace_file, pending_trace_file
                 ])
   end


@@ -132,44 +136,41 @@ class TraceTest < ActiveSupport::TestCase
 
   def test_mime_type
     # The ids refer to the .gpx fixtures in test/traces
 
   def test_mime_type
     # The ids refer to the .gpx fixtures in test/traces

-    check_mime_type(1, "application/gpx+xml")
-    check_mime_type(2, "application/gpx+xml")
-    check_mime_type(3, "application/x-bzip2")
-    check_mime_type(4, "application/x-gzip")
-    check_mime_type(6, "application/x-zip")
-    check_mime_type(7, "application/x-tar")
-    check_mime_type(8, "application/x-gzip")
-    check_mime_type(9, "application/x-bzip2")
+    check_mime_type("a", "application/gpx+xml")
+    check_mime_type("b", "application/gpx+xml")
+    check_mime_type("c", "application/x-bzip2")
+    check_mime_type("d", "application/x-gzip")
+    check_mime_type("f", "application/x-zip")
+    check_mime_type("g", "application/x-tar")
+    check_mime_type("h", "application/x-gzip")
+    check_mime_type("i", "application/x-bzip2")

   end
 
   def test_extension_name
     # The ids refer to the .gpx fixtures in test/traces
   end
 
   def test_extension_name
     # The ids refer to the .gpx fixtures in test/traces

-    check_extension_name(1, ".gpx")
-    check_extension_name(2, ".gpx")
-    check_extension_name(3, ".gpx.bz2")
-    check_extension_name(4, ".gpx.gz")
-    check_extension_name(6, ".zip")
-    check_extension_name(7, ".tar")
-    check_extension_name(8, ".tar.gz")
-    check_extension_name(9, ".tar.bz2")
+    check_extension_name("a", ".gpx")
+    check_extension_name("b", ".gpx")
+    check_extension_name("c", ".gpx.bz2")
+    check_extension_name("d", ".gpx.gz")
+    check_extension_name("f", ".zip")
+    check_extension_name("g", ".tar")
+    check_extension_name("h", ".tar.gz")
+    check_extension_name("i", ".tar.bz2")

   end
 
   def test_xml_file
   end
 
   def test_xml_file

-    check_xml_file(1, "848caa72f2f456d1bd6a0fdf228aa1b9")
-    check_xml_file(2, "66179ca44f1e93d8df62e2b88cbea732")
-    check_xml_file(3, "848caa72f2f456d1bd6a0fdf228aa1b9")
-    check_xml_file(4, "abd6675fdf3024a84fc0a1deac147c0d")
-    check_xml_file(6, "848caa72f2f456d1bd6a0fdf228aa1b9")
-    check_xml_file(7, "848caa72f2f456d1bd6a0fdf228aa1b9")
-    check_xml_file(8, "848caa72f2f456d1bd6a0fdf228aa1b9")
-    check_xml_file(9, "848caa72f2f456d1bd6a0fdf228aa1b9")
+    check_xml_file("a", "848caa72f2f456d1bd6a0fdf228aa1b9")
+    check_xml_file("b", "66179ca44f1e93d8df62e2b88cbea732")
+    check_xml_file("c", "848caa72f2f456d1bd6a0fdf228aa1b9")
+    check_xml_file("d", "abd6675fdf3024a84fc0a1deac147c0d")
+    check_xml_file("f", "848caa72f2f456d1bd6a0fdf228aa1b9")
+    check_xml_file("g", "848caa72f2f456d1bd6a0fdf228aa1b9")
+    check_xml_file("h", "848caa72f2f456d1bd6a0fdf228aa1b9")
+    check_xml_file("i", "848caa72f2f456d1bd6a0fdf228aa1b9")

   end
 
   def test_large_picture
   end
 
   def test_large_picture

-    trace = create(:trace)
-    picture = trace.stub :large_picture_name, "#{GPX_IMAGE_DIR}/1.gif" do
-      trace.large_picture
-    end
+    picture = File.read(Rails.root.join("test", "gpx", "fixtures", "a.gif"), :mode => "rb")

 
     trace = Trace.create
     trace.large_picture = picture
 
     trace = Trace.create
     trace.large_picture = picture


@@ -180,10 +181,7 @@ class TraceTest < ActiveSupport::TestCase
   end
 
   def test_icon_picture
   end
 
   def test_icon_picture

-    trace = create(:trace)
-    picture = trace.stub :icon_picture_name, "#{GPX_IMAGE_DIR}/1_icon.gif" do
-      trace.icon_picture
-    end
+    picture = File.read(Rails.root.join("test", "gpx", "fixtures", "a_icon.gif"), :mode => "rb")

 
     trace = Trace.create
     trace.icon_picture = picture
 
     trace = Trace.create
     trace.icon_picture = picture


@@ -193,32 +191,83 @@ class TraceTest < ActiveSupport::TestCase
     trace.destroy
   end
 
     trace.destroy
   end
 

+  # When testing the trace.import method, care needs to be taken regarding the icon
+  # fixture files, since the fixtures could be overwritten by newly generated files.
+  # We use FakeFS to temporarily protect the real fixture files from being overwritten.
+
+  def test_import_removes_previous_tracepoints
+    FakeFS do
+      FakeFS::FileSystem.clone(Rails.root.join("test", "gpx"))
+      trace = create(:trace, :fixture => "a")
+      # Tracepoints don't have a primary key, so we use a specific latitude to
+      # check for successful deletion
+      create(:tracepoint, :latitude => 54321, :trace => trace)
+      assert_equal 1, Tracepoint.where(:latitude => 54321).count
+
+      trace.import
+
+      assert_equal 0, Tracepoint.where(:latitude => 54321).count
+    end
+  end
+
+  def test_import_creates_tracepoints
+    FakeFS do
+      FakeFS::FileSystem.clone(Rails.root.join("test", "gpx"))
+      trace = create(:trace, :fixture => "a")
+      assert_equal 0, Tracepoint.where(:gpx_id => trace.id).count
+
+      trace.import
+
+      trace.reload
+      assert_equal 1, Tracepoint.where(:gpx_id => trace.id).count
+    end
+  end
+
+  def test_import_creates_icon
+    FakeFS do
+      FakeFS::FileSystem.clone(Rails.root.join("test", "gpx"))
+      trace = create(:trace, :fixture => "a")
+      icon_path = File.join(GPX_IMAGE_DIR, "#{trace.id}_icon.gif")
+      FileUtils.rm(icon_path)
+      assert_equal false, File.exist?(icon_path)
+
+      trace.import
+
+      assert_equal true, File.exist?(icon_path)
+    end
+  end
+
+  def test_import_creates_large_picture
+    FakeFS do
+      FakeFS::FileSystem.clone(Rails.root.join("test", "gpx"))
+      trace = create(:trace, :fixture => "a")
+      large_picture_path = File.join(GPX_IMAGE_DIR, "#{trace.id}.gif")
+      FileUtils.rm(large_picture_path)
+      assert_equal false, File.exist?(large_picture_path)
+
+      trace.import
+
+      assert_equal true, File.exist?(large_picture_path)
+    end
+  end
+

   private
 
   def check_query(query, traces)
   private
 
   def check_query(query, traces)

-    traces = traces.map { |t| t.id }.sort
+    traces = traces.map(&:id).sort

     assert_equal traces, query.order(:id).ids
   end
 
   def check_mime_type(id, mime_type)
     assert_equal traces, query.order(:id).ids
   end
 
   def check_mime_type(id, mime_type)

-    trace = create(:trace)
-    trace.stub :trace_name, "#{GPX_TRACE_DIR}/#{id}.gpx" do
-      assert_equal mime_type, trace.mime_type
-    end
+    assert_equal mime_type, create(:trace, :fixture => id).mime_type

   end
 
   def check_extension_name(id, extension_name)
   end
 
   def check_extension_name(id, extension_name)

-    trace = create(:trace)
-    trace.stub :trace_name, "#{GPX_TRACE_DIR}/#{id}.gpx" do
-      assert_equal extension_name, trace.extension_name
-    end
+    assert_equal extension_name, create(:trace, :fixture => id).extension_name

   end
 
   def check_xml_file(id, md5sum)
   end
 
   def check_xml_file(id, md5sum)

-    trace = create(:trace)
-    trace.stub :trace_name, "#{GPX_TRACE_DIR}/#{id}.gpx" do
-      assert_equal md5sum, md5sum(trace.xml_file)
-    end
+    assert_equal md5sum, md5sum(create(:trace, :fixture => id).xml_file)

   end
 
   def trace_valid(attrs, result = true)
   end
 
   def trace_valid(attrs, result = true)