Split api changeset comment create fail tests

[rails.git] / test / controllers / api / changeset_comments_controller_test.rb

diff --git a/test/controllers/api/changeset_comments_controller_test.rb b/test/controllers/api/changeset_comments_controller_test.rb
index cc257eb9d63aa3f53779e78dd8dc65fd1e5d6b93..b3b3d9c757d9ce0904b57930a5f314c72fae3592 100644 (file)
--- a/test/controllers/api/changeset_comments_controller_test.rb
+++ b/test/controllers/api/changeset_comments_controller_test.rb
@@ -98,38 +98,39 @@ module Api
       ActionMailer::Base.deliveries.clear
     end
 
       ActionMailer::Base.deliveries.clear
     end
 

-    ##
-    # create comment fail
-    def test_create_fail
-      # unauthorized
-      post changeset_comment_path(create(:changeset, :closed), :text => "This is a comment")
-      assert_response :unauthorized
-
-      auth_header = bearer_authorization_header
+    def test_create_by_unauthorized
+      assert_no_difference "ChangesetComment.count" do
+        post changeset_comment_path(create(:changeset, :closed), :text => "This is a comment")
+        assert_response :unauthorized
+      end
+    end

 
 

-      # bad changeset id
+    def test_create_on_missing_changeset

       assert_no_difference "ChangesetComment.count" do
       assert_no_difference "ChangesetComment.count" do

-        post changeset_comment_path(999111, :text => "This is a comment"), :headers => auth_header
+        post changeset_comment_path(999111, :text => "This is a comment"), :headers => bearer_authorization_header
+        assert_response :not_found

       end
       end

-      assert_response :not_found
+    end

 
 

-      # not closed changeset
+    def test_create_on_open_changeset

       assert_no_difference "ChangesetComment.count" do
       assert_no_difference "ChangesetComment.count" do

-        post changeset_comment_path(create(:changeset), :text => "This is a comment"), :headers => auth_header
+        post changeset_comment_path(create(:changeset), :text => "This is a comment"), :headers => bearer_authorization_header
+        assert_response :conflict

       end
       end

-      assert_response :conflict
+    end

 
 

-      # no text
+    def test_create_without_text

       assert_no_difference "ChangesetComment.count" do
       assert_no_difference "ChangesetComment.count" do

-        post changeset_comment_path(create(:changeset, :closed)), :headers => auth_header
+        post changeset_comment_path(create(:changeset, :closed)), :headers => bearer_authorization_header
+        assert_response :bad_request

       end
       end

-      assert_response :bad_request
+    end

 
 

-      # empty text
+    def test_create_with_empty_text

       assert_no_difference "ChangesetComment.count" do
       assert_no_difference "ChangesetComment.count" do

-        post changeset_comment_path(create(:changeset, :closed), :text => ""), :headers => auth_header
+        post changeset_comment_path(create(:changeset, :closed), :text => ""), :headers => bearer_authorization_header
+        assert_response :bad_request

       end
       end

-      assert_response :bad_request

     end
 
     ##
     end
 
     ##