session :off
before_filter :check_api_readable
after_filter :compress_output
+ around_filter :api_call_handle_error, :api_call_timeout
def history
- begin
- relation = Relation.find(params[:id])
- doc = OSM::API.new.get_xml_doc
-
- relation.old_relations.each do |old_relation|
- doc.root << old_relation.to_xml_node
- end
-
- render :text => doc.to_s, :content_type => "text/xml"
- rescue ActiveRecord::RecordNotFound
- render :nothing => true, :status => :not_found
- rescue
- render :nothing => true, :status => :internal_server_error
+ relation = Relation.find(params[:id])
+ doc = OSM::API.new.get_xml_doc
+
+ relation.old_relations.each do |old_relation|
+ doc.root << old_relation.to_xml_node
end
+
+ render :text => doc.to_s, :content_type => "text/xml"
end
def version
- begin
- old_relation = OldRelation.find(:first, :conditions => {:id => params[:id], :version => params[:version]} )
-
- response.headers['Last-Modified'] = old_relation.timestamp.rfc822
-
- doc = OSM::API.new.get_xml_doc
- doc.root << old_relation.to_xml_node
-
- render :text => doc.to_s, :content_type => "text/xml"
- rescue ActiveRecord::RecordNotFound
+ old_relation = OldRelation.find(:first, :conditions => {:id => params[:id], :version => params[:version]} )
+ if old_relation.nil?
+ # (RecordNotFound is not raised with find :first...)
render :nothing => true, :status => :not_found
- rescue
- render :nothing => true, :status => :internal_service_error
+ return
end
+
+ response.headers['Last-Modified'] = old_relation.timestamp.rfc822
+
+ doc = OSM::API.new.get_xml_doc
+ doc.root << old_relation.to_xml_node
+
+ render :text => doc.to_s, :content_type => "text/xml"
end
end