Remove redundant presence validation on belongs_to

[rails.git] / app / models / report.rb

diff --git a/app/models/report.rb b/app/models/report.rb
index e32e09721848e75fd8053488c1ef02c635b855f6..77a96764125bbc8e839d73773a3fbfa50a5d9aa9 100644 (file)
--- a/app/models/report.rb
+++ b/app/models/report.rb
@@ -3,9 +3,10 @@
 # Table name: reports
 #
 #  id         :integer          not null, primary key
-#  issue_id   :integer
-#  user_id    :integer
+#  issue_id   :integer          not null
+#  user_id    :integer          not null
 #  details    :text             not null
+#  category   :string           not null
 #  created_at :datetime         not null
 #  updated_at :datetime         not null
 #
@@ -16,13 +17,23 @@
 #
 # Foreign Keys
 #
-#  reports_issue_id_fkey  (issue_id => issues.id) ON DELETE => cascade
-#  reports_user_id_fkey   (user_id => users.id) ON DELETE => cascade
+#  reports_issue_id_fkey  (issue_id => issues.id)
+#  reports_user_id_fkey   (user_id => users.id)
 #
 
-class Report < ActiveRecord::Base
+class Report < ApplicationRecord
   belongs_to :issue, :counter_cache => true
   belongs_to :user
 
-  validates :details, :presence => true
+  validates :details, :presence => true, :characters => true
+  validates :category, :presence => true
+
+  def self.categories_for(reportable)
+    case reportable.class.name
+    when "DiaryEntry", "DiaryComment" then %w[spam offensive threat other]
+    when "User" then %w[spam offensive threat vandal other]
+    when "Note" then %w[spam personal abusive other]
+    else %w[other]
+    end
+  end
 end