# This configuration was generated by
# `rubocop --auto-gen-config`
-# on 2016-09-07 11:03:27 +0100 using RuboCop version 0.41.2.
+# on 2019-10-19 16:05:52 +0000 using RuboCop version 0.75.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
-# Offense count: 34
-Lint/AmbiguousOperator:
- Exclude:
- - 'test/controllers/amf_controller_test.rb'
- - 'test/controllers/changeset_controller_test.rb'
- - 'test/lib/bounding_box_test.rb'
- - 'test/lib/country_test.rb'
+# Work around erblint issues.
+# https://github.com/openstreetmap/openstreetmap-website/issues/2472
+require:
+ - rubocop-performance
+ - rubocop-rails
-# Offense count: 117
-Lint/AmbiguousRegexpLiteral:
- Enabled: false
+# Offense count: 3338
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+ Max: 260
-# Offense count: 30
+# Offense count: 35
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
Exclude:
+ - 'app/controllers/api/traces_controller.rb'
+ - 'app/controllers/api/user_preferences_controller.rb'
- 'app/controllers/application_controller.rb'
- 'app/controllers/geocoder_controller.rb'
- 'app/controllers/notes_controller.rb'
- - 'app/controllers/trace_controller.rb'
- - 'app/controllers/user_controller.rb'
- - 'app/controllers/user_preference_controller.rb'
+ - 'app/controllers/traces_controller.rb'
+ - 'app/controllers/users_controller.rb'
- 'app/helpers/application_helper.rb'
- - 'app/helpers/browse_helper.rb'
+ - 'app/helpers/browse_tags_helper.rb'
+ - 'app/mailers/notifier.rb'
- 'app/models/client_application.rb'
- - 'app/models/notifier.rb'
- 'lib/nominatim.rb'
- 'lib/osm.rb'
- 'script/deliver-message'
-# Offense count: 5
-Lint/HandleExceptions:
- Exclude:
- - 'app/controllers/amf_controller.rb'
- - 'app/controllers/user_controller.rb'
- - 'config/initializers/session.rb'
-
-# Offense count: 2
-Lint/ShadowingOuterLocalVariable:
+# Offense count: 4
+# Configuration parameters: AllowComments.
+Lint/SuppressedException:
Exclude:
- - 'app/views/changeset/list.atom.builder'
+ - 'app/controllers/api/amf_controller.rb'
+ - 'app/controllers/users_controller.rb'
+ - 'app/controllers/site_controller.rb'
-# Offense count: 626
+# Offense count: 701
Metrics/AbcSize:
- Max: 277
+ Max: 189
+
+# Offense count: 39
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+ Max: 71
-# Offense count: 12
+# Offense count: 15
+# Configuration parameters: CountBlocks.
Metrics/BlockNesting:
Max: 5
-# Offense count: 62
+# Offense count: 25
# Configuration parameters: CountComments.
Metrics/ClassLength:
- Max: 1650
+ Max: 645
-# Offense count: 68
+# Offense count: 74
Metrics/CyclomaticComplexity:
- Max: 20
-
-# Offense count: 2561
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
-# URISchemes: http, https
-Metrics/LineLength:
- Max: 962
+ Max: 22
-# Offense count: 604
-# Configuration parameters: CountComments.
+# Offense count: 722
+# Configuration parameters: CountComments, ExcludedMethods.
Metrics/MethodLength:
Max: 179
-# Offense count: 1
+# Offense count: 2
# Configuration parameters: CountComments.
Metrics/ModuleLength:
- Max: 139
+ Max: 117
# Offense count: 4
# Configuration parameters: CountKeywordArgs.
Metrics/ParameterLists:
Max: 9
-# Offense count: 70
+# Offense count: 72
Metrics/PerceivedComplexity:
- Max: 23
+ Max: 25
-# Offense count: 2
-# Configuration parameters: Include.
-# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb
-Rails/Exit:
+# Offense count: 6
+Naming/AccessorMethodName:
Exclude:
- - 'lib/**/*.rake'
- - 'lib/daemons/gpx_import.rb'
+ - 'app/controllers/application_controller.rb'
+ - 'app/helpers/title_helper.rb'
+ - 'app/models/old_way.rb'
+ - 'lib/osm.rb'
+ - 'lib/potlatch.rb'
+
+# Offense count: 8
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+# MethodDefinitionMacros: define_method, define_singleton_method
+Naming/PredicateName:
+ Exclude:
+ - 'spec/**/*'
+ - 'app/models/changeset.rb'
+ - 'app/models/old_node.rb'
+ - 'app/models/old_relation.rb'
+ - 'app/models/old_way.rb'
+ - 'app/models/user.rb'
+ - 'lib/classic_pagination/pagination.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Performance/RegexpMatch:
+ Exclude:
+ - 'app/helpers/browse_tags_helper.rb'
+ - 'app/validators/characters_validator.rb'
+ - 'app/validators/whitespace_validator.rb'
+
+# Offense count: 6
+# Configuration parameters: Database, Include.
+# SupportedDatabases: mysql, postgresql
+# Include: db/migrate/*.rb
+Rails/BulkChangeTable:
+ Exclude:
+ - 'db/migrate/20111116184519_update_oauth.rb'
+ - 'db/migrate/20120208122334_merge_acl_address_and_mask.rb'
+ - 'db/migrate/20120208194454_add_domain_to_acl.rb'
+ - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
# Offense count: 2
# Configuration parameters: Include.
- 'app/models/changeset.rb'
- 'app/models/user.rb'
-# Offense count: 17
+# Offense count: 11
+# Configuration parameters: Include.
+# Include: app/helpers/**/*.rb
+Rails/HelperInstanceVariable:
+ Exclude:
+ - 'app/helpers/application_helper.rb'
+ - 'app/helpers/title_helper.rb'
+ - 'app/helpers/trace_helper.rb'
+
+# Offense count: 5
+# Configuration parameters: Include.
+# Include: db/migrate/*.rb
+Rails/NotNullColumn:
+ Exclude:
+ - 'db/migrate/002_cleanup_osm_db.rb'
+ - 'db/migrate/020_populate_node_tags_and_remove.rb'
+ - 'db/migrate/021_move_to_innodb.rb'
+ - 'db/migrate/025_add_end_time_to_changesets.rb'
+ - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
+
+# Offense count: 18
Rails/OutputSafety:
Exclude:
- - 'app/controllers/user_controller.rb'
+ - 'app/controllers/users_controller.rb'
- 'app/helpers/application_helper.rb'
- - 'app/helpers/changeset_helper.rb'
+ - 'app/helpers/changesets_helper.rb'
- 'app/helpers/geocoder_helper.rb'
- 'app/helpers/note_helper.rb'
- 'app/helpers/open_graph_helper.rb'
- 'app/helpers/user_blocks_helper.rb'
- - 'app/helpers/user_roles_helper.rb'
- 'lib/rich_text.rb'
- 'test/helpers/application_helper_test.rb'
-# Offense count: 65
-# Configuration parameters: EnforcedStyle, SupportedStyles.
+# Offense count: 94
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
# SupportedStyles: strict, flexible
Rails/TimeZone:
Enabled: false
-# Offense count: 5
-Style/AccessorMethodName:
- Exclude:
- - 'app/controllers/application_controller.rb'
- - 'app/helpers/title_helper.rb'
- - 'app/models/old_way.rb'
- - 'lib/osm.rb'
- - 'lib/potlatch.rb'
-
# Offense count: 1
+# Configuration parameters: AllowedChars.
Style/AsciiComments:
Exclude:
- 'test/models/message_test.rb'
-# Offense count: 218
-Style/Documentation:
- Enabled: false
-
-# Offense count: 60
-# Cop supports --auto-correct.
-Style/LineEndConcatenation:
+# Offense count: 27
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
Exclude:
- - 'db/migrate/008_remove_segments.rb'
- - 'db/migrate/020_populate_node_tags_and_remove.rb'
- - 'db/migrate/023_add_changesets.rb'
+ - 'app/models/concerns/geo_record.rb'
+ - 'app/views/api/map/_bounds.xml.builder'
- 'lib/bounding_box.rb'
- - 'lib/diff_reader.rb'
- - 'lib/osm.rb'
- - 'test/controllers/changeset_controller_test.rb'
- - 'test/controllers/node_controller_test.rb'
- - 'test/controllers/relation_controller_test.rb'
- - 'test/controllers/way_controller_test.rb'
-
-# Offense count: 69
-# Cop supports --auto-correct.
-Style/NumericLiterals:
- MinDigits: 11
-
-# Offense count: 38
-# Cop supports --auto-correct.
-Style/PerlBackrefs:
- Exclude:
- - 'app/controllers/amf_controller.rb'
- - 'app/helpers/browse_helper.rb'
- - 'config/initializers/paperclip.rb'
- - 'lib/id.rb'
- - 'lib/potlatch.rb'
- - 'test/lib/i18n_test.rb'
-
-# Offense count: 8
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
-# NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
-Style/PredicateName:
- Exclude:
- - 'spec/**/*'
- - 'app/models/changeset.rb'
- - 'app/models/old_node.rb'
- - 'app/models/old_relation.rb'
- - 'app/models/old_way.rb'
- - 'app/models/user.rb'
- - 'lib/classic_pagination/pagination.rb'
+ - 'test/controllers/api/map_controller_test.rb'
+ - 'test/controllers/api/relations_controller_test.rb'
+ - 'test/controllers/api/ways_controller_test.rb'
+ - 'test/lib/bounding_box_test.rb'
-# Offense count: 97
+# Offense count: 539
# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: compact, exploded
-Style/RaiseArgs:
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, never
+Style/FrozenStringLiteralComment:
Enabled: false
# Offense count: 2
# Cop supports --auto-correct.
-Style/RescueModifier:
+Style/IfUnlessModifier:
Exclude:
- - 'app/helpers/browse_helper.rb'
+ - 'app/controllers/api/ways_controller.rb'
-# Offense count: 8
+# Offense count: 70
# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiteralsInInterpolation:
- Exclude:
- - 'app/controllers/amf_controller.rb'
- - 'app/models/node.rb'
- - 'app/models/way.rb'
- - 'lib/migrate.rb'
- - 'test/controllers/changeset_controller_test.rb'
+# Configuration parameters: Strict.
+Style/NumericLiterals:
+ MinDigits: 11
projects / rails.git / blobdiff