Removed bogus belongs_to user declaration.

[rails.git] / app / controllers / node_controller.rb

diff --git a/app/controllers/node_controller.rb b/app/controllers/node_controller.rb
index 5cdbca827dffe35287313f6618f329e681c98e38..edc3675e58382fce0b8b5801a2e7180ab280cec2 100644 (file)
--- a/app/controllers/node_controller.rb
+++ b/app/controllers/node_controller.rb
@@ -1,105 +1,111 @@
+# The NodeController is the RESTful interface to Node objects
+

 class NodeController < ApplicationController
   require 'xml/libxml'
 
 class NodeController < ApplicationController
   require 'xml/libxml'
 

-  before_filter :authorize
+  session :off
+  before_filter :authorize, :only => [:create, :update, :delete]
+  before_filter :check_write_availability, :only => [:create, :update, :delete]
+  before_filter :check_read_availability, :except => [:create, :update, :delete]

   after_filter :compress_output
 
   after_filter :compress_output
 

+  # Create a node from XML.

   def create
   def create

-    response.headers["Content-Type"] = 'application/xml'

     if request.put?
     if request.put?

-      node = nil
-      begin
-        node = Node.from_xml(request.raw_post, true)
-      rescue
-        render :text => "XML didn't parse", :status => 400 # if we got here the doc didnt parse
-        return
-      end
+      node = Node.from_xml(request.raw_post, true)

 
       if node
         node.user_id = @user.id
 
       if node
         node.user_id = @user.id

-        node.visible = 1
-        if node.save_with_history
-          render :text => node.id.to_s
-        else
-          render :nothing => true, :status => 500
-        end
-        return
+        node.visible = true
+        node.save_with_history!

 
 

+        render :text => node.id.to_s, :content_type => "text/plain"

       else
       else

-        render :nothing => true, :status => 400 # if we got here the doc didnt parse
-        return
+        render :nothing => true, :status => :bad_request

       end
       end

+    else
+      render :nothing => true, :status => :method_not_allowed

     end
     end

-
-    render :nothing => true, :status => 500 # something went very wrong

   end
 
   end
 

-  def rest
-    response.headers["Content-Type"] = 'application/xml'
-    unless Node.exists?(params[:id])
-      render :nothing => true, :status => 404
-      return
-    end
-
-    node = Node.find(params[:id])
-
-    case request.method
-
-    when :get
-      unless node
-        render :nothing => true, :status => 500
-        return
+  # Dump the details on a node given in params[:id]
+  def read
+    begin
+      node = Node.find(params[:id])
+      if node.visible
+        response.headers['Last-Modified'] = node.timestamp.rfc822
+        render :text => node.to_xml.to_s, :content_type => "text/xml"
+       else
+        render :text => "", :status => :gone

       end
       end

+    rescue ActiveRecord::RecordNotFound
+      render :nothing => true, :status => :not_found
+    end
+  end

 
 

-      unless node.visible
-        render :nothing => true, :status => 410
-        return
-      end
+  # Update a node from given XML
+  def update
+    begin
+      node = Node.find(params[:id])
+      new_node = Node.from_xml(request.raw_post)

 
 

-      render :text => node.to_xml.to_s
-      return
+      if new_node and new_node.id == node.id
+        node.user_id = @user.id
+        node.latitude = new_node.latitude 
+        node.longitude = new_node.longitude
+        node.tags = new_node.tags
+        node.visible = true
+        node.save_with_history!

 
 

-    when :delete
-      if node.visible
-        node.visible = 0
-        node.save_with_history

         render :nothing => true
       else
         render :nothing => true
       else

-        render :nothing => true, :status => 410
+        render :nothing => true, :status => :bad_request

       end
       end

+    rescue ActiveRecord::RecordNotFound
+      render :nothing => true, :status => :not_found
+    end
+  end

 
 

-    when :put
-      new_node = Node.from_xml(request.raw_post)
-
-      node.timestamp = Time.now
-      node.user_id = @user.id
+  # Delete a node. Doesn't actually delete it, but retains its history in a wiki-like way.
+  # FIXME remove all the fricking SQL
+  def delete
+    begin
+      node = Node.find(params[:id])

 
 

-      node.latitude = new_node.latitude 
-      node.longitude = new_node.longitude
-      node.tags = new_node.tags
+      if node.visible
+        if WayNode.find(:first, :joins => "INNER JOIN current_ways ON current_ways.id = current_way_nodes.id", :conditions => [ "current_ways.visible = 1 AND current_way_nodes.node_id = ?", node.id ])
+          render :text => "", :status => :precondition_failed
+        elsif RelationMember.find(:first, :joins => "INNER JOIN current_relations ON current_relations.id=current_relation_members.id", :conditions => [ "visible = 1 AND member_type='node' and member_id=?", params[:id]])
+          render :text => "", :status => :precondition_failed
+        else
+          node.user_id = @user.id
+          node.visible = 0
+          node.save_with_history!

 
 

-      if node.id == new_node.id and node.save_with_history
-        render :nothing => true, :status => 200
+          render :nothing => true
+        end

       else
       else

-        render :nothing => true, :status => 500
+        render :text => "", :status => :gone

       end
       end

-      return
+    rescue ActiveRecord::RecordNotFound
+      render :nothing => true, :status => :not_found

     end
     end

-

   end
 
   end
 

+  # WTF does this do?

   def nodes
   def nodes

-    response.headers["Content-Type"] = 'application/xml'
-    ids = params['nodes'].split(',').collect {|n| n.to_i }
+    ids = params['nodes'].split(',').collect { |n| n.to_i }
+

     if ids.length > 0
     if ids.length > 0

-      nodelist = Node.find(ids)
-      doc = get_xml_doc
-      nodelist.each do |node|
+      doc = OSM::API.new.get_xml_doc
+
+      Node.find(ids).each do |node|

         doc.root << node.to_xml_node
       end 
         doc.root << node.to_xml_node
       end 

-      render :text => doc.to_s
+
+      render :text => doc.to_s, :content_type => "text/xml"

     else
     else

-      render :nothing => true, :status => 400
+      render :nothing => true, :status => :bad_request

     end
   end
 end
     end
   end
 end