More unit tests for the parsing of the Node.from_xml. Some code clean up to ensure...

[rails.git] / app / models / changeset.rb

diff --git a/app/models/changeset.rb b/app/models/changeset.rb
index d41a8298940c5bdfd08f6632a27f12ddfa892a05..5c961a06470c1999d74df7565707559956811135 100644 (file)
--- a/app/models/changeset.rb
+++ b/app/models/changeset.rb
@@ -85,6 +85,20 @@ class Changeset < ActiveRecord::Base
   def bbox
     @bbox ||= [ min_lon, min_lat, max_lon, max_lat ]
   end
   def bbox
     @bbox ||= [ min_lon, min_lat, max_lon, max_lat ]
   end

+  
+  def has_valid_bbox?
+    not bbox.include? nil
+  end
+  
+  ##
+  # returns area of the changset bbox as a rough comparitive quantity for use of changset displays
+  def area
+     if has_valid_bbox?
+            (max_lon - min_lon) * (max_lat - min_lat)
+     else
+            0
+     end
+  end

 
   ##
   # expand the bounding box to include the given bounding box. also, 
 
   ##
   # expand the bounding box to include the given bounding box. also, 


@@ -140,19 +154,9 @@ class Changeset < ActiveRecord::Base
   end
 
   def save_with_tags!
   end
 
   def save_with_tags!

-    t = Time.now.getutc
-

     # do the changeset update and the changeset tags update in the
     # same transaction to ensure consistency.
     Changeset.transaction do
     # do the changeset update and the changeset tags update in the
     # same transaction to ensure consistency.
     Changeset.transaction do

-      # set the auto-close time to be one hour in the future unless
-      # that would make it more than 24h long, in which case clip to
-      # 24h, as this has been decided is a reasonable time limit.
-      if (closed_at - created_at) > (MAX_TIME_OPEN - IDLE_TIMEOUT)
-        self.closed_at = created_at + MAX_TIME_OPEN
-      else
-        self.closed_at = Time.now.getutc + IDLE_TIMEOUT
-      end

       self.save!
 
       tags = self.tags
       self.save!
 
       tags = self.tags


@@ -167,6 +171,20 @@ class Changeset < ActiveRecord::Base
       end
     end
   end
       end
     end
   end

+
+  ##
+  # set the auto-close time to be one hour in the future unless
+  # that would make it more than 24h long, in which case clip to
+  # 24h, as this has been decided is a reasonable time limit.
+  def before_save
+    if self.is_open?
+      if (closed_at - created_at) > (MAX_TIME_OPEN - IDLE_TIMEOUT)
+        self.closed_at = created_at + MAX_TIME_OPEN
+      else
+        self.closed_at = Time.now.getutc + IDLE_TIMEOUT
+      end
+    end
+  end

   
   def to_xml
     doc = OSM::API.new.get_xml_doc
   
   def to_xml
     doc = OSM::API.new.get_xml_doc


@@ -221,7 +239,7 @@ class Changeset < ActiveRecord::Base
   def update_from(other, user)
     # ensure that only the user who opened the changeset may modify it.
     unless user.id == self.user_id 
   def update_from(other, user)
     # ensure that only the user who opened the changeset may modify it.
     unless user.id == self.user_id 

-      raise OSM::APIUserChangesetMismatchError 
+      raise OSM::APIUserChangesetMismatchError.new

     end
     
     # can't change a closed changeset
     end
     
     # can't change a closed changeset