Merge remote-tracking branch 'upstream/pull/4410'

[rails.git] / app / controllers / users_controller.rb

diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
index 0b7f6ec919e7ddec4683d08623fe2d508ecb37ca..f79c284e3e499bf6b70475b0380141034032e316 100644 (file)
--- a/app/controllers/users_controller.rb
+++ b/app/controllers/users_controller.rb
@@ -311,20 +311,17 @@ class UsersController < ApplicationController
 
   def welcome_options
     uri = URI(session[:referer]) if session[:referer].present?
-    welcome_options = {}
-    welcome_options["oauth_return_url"] = uri&.to_s if uri&.path == oauth_authorization_path
+
+    return { "oauth_return_url" => uri&.to_s } if uri&.path == oauth_authorization_path
 
     begin
       %r{map=(.*)/(.*)/(.*)}.match(uri.fragment) do |m|
         editor = Rack::Utils.parse_query(uri.query).slice("editor")
-        welcome_options = { "zoom" => m[1],
-                            "lat" => m[2],
-                            "lon" => m[3] }.merge(editor).merge(welcome_options)
+        return { "zoom" => m[1], "lat" => m[2], "lon" => m[3] }.merge(editor)
       end
     rescue StandardError
       # Use default
     end
-    welcome_options
   end
 
   ##