Merge remote-tracking branch 'upstream/pull/2296'

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index a993d5fff1a3968fbece6a2df3218abded4f2204..809cde374d470abfb57c755a369189dc1b73d34a 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,126 +1,196 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2015-02-25 00:27:05 +0000 using RuboCop version 0.29.1.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2019-06-05 09:04:25 +0100 using RuboCop version 0.71.0.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 

-# Offense count: 13
-Lint/AmbiguousOperator:
-  Enabled: false
-
-# Offense count: 107
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
-
-# Offense count: 29
+# Offense count: 33

 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:

-  Enabled: false
+  Exclude:
+    - 'app/controllers/api/traces_controller.rb'
+    - 'app/controllers/api/user_preferences_controller.rb'
+    - 'app/controllers/application_controller.rb'
+    - 'app/controllers/geocoder_controller.rb'
+    - 'app/controllers/notes_controller.rb'
+    - 'app/controllers/traces_controller.rb'
+    - 'app/controllers/users_controller.rb'
+    - 'app/helpers/application_helper.rb'
+    - 'app/helpers/browse_tags_helper.rb'
+    - 'app/mailers/notifier.rb'
+    - 'app/models/client_application.rb'
+    - 'lib/nominatim.rb'
+    - 'lib/osm.rb'
+    - 'script/deliver-message'

 
 

-# Offense count: 5
+# Offense count: 4
+# Configuration parameters: AllowComments.

 Lint/HandleExceptions:
 Lint/HandleExceptions:

-  Enabled: false
-
-# Offense count: 8
-Lint/ParenthesesAsGroupedExpression:
-  Enabled: false
+  Exclude:
+    - 'app/controllers/api/amf_controller.rb'
+    - 'app/controllers/users_controller.rb'

 
 

-# Offense count: 542
+# Offense count: 703

 Metrics/AbcSize:
 Metrics/AbcSize:

-  Max: 270
+  Max: 279
+
+# Offense count: 40
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Max: 71

 
 

-# Offense count: 12
+# Offense count: 15
+# Configuration parameters: CountBlocks.

 Metrics/BlockNesting:
   Max: 5
 
 Metrics/BlockNesting:
   Max: 5
 

-# Offense count: 60
+# Offense count: 68

 # Configuration parameters: CountComments.
 Metrics/ClassLength:
 # Configuration parameters: CountComments.
 Metrics/ClassLength:

-  Max: 1552
+  Max: 645

 
 

-# Offense count: 68
+# Offense count: 73

 Metrics/CyclomaticComplexity:
 Metrics/CyclomaticComplexity:

-  Max: 21
-
-# Offense count: 2092
-# Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
-  Max: 694
+  Max: 22

 
 

-# Offense count: 520
-# Configuration parameters: CountComments.
+# Offense count: 714
+# Configuration parameters: CountComments, ExcludedMethods.

 Metrics/MethodLength:
   Max: 179
 
 Metrics/MethodLength:
   Max: 179
 

+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 107
+

 # Offense count: 4
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 9
 
 # Offense count: 4
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 9
 

-# Offense count: 70
+# Offense count: 71

 Metrics/PerceivedComplexity:
 Metrics/PerceivedComplexity:

-  Max: 24
+  Max: 25
+
+# Offense count: 6
+Naming/AccessorMethodName:
+  Exclude:
+    - 'app/controllers/application_controller.rb'
+    - 'app/helpers/title_helper.rb'
+    - 'app/models/old_way.rb'
+    - 'lib/osm.rb'
+    - 'lib/potlatch.rb'
+
+# Offense count: 8
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+# MethodDefinitionMacros: define_method, define_singleton_method
+Naming/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'app/models/changeset.rb'
+    - 'app/models/old_node.rb'
+    - 'app/models/old_relation.rb'
+    - 'app/models/old_way.rb'
+    - 'app/models/user.rb'
+    - 'lib/classic_pagination/pagination.rb'
+
+# Offense count: 6
+# Configuration parameters: Database, Include.
+# SupportedDatabases: mysql, postgresql
+# Include: db/migrate/*.rb
+Rails/BulkChangeTable:
+  Exclude:
+    - 'db/migrate/20111116184519_update_oauth.rb'
+    - 'db/migrate/20120208122334_merge_acl_address_and_mask.rb'
+    - 'db/migrate/20120208194454_add_domain_to_acl.rb'
+    - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'

 
 # Offense count: 2
 # Configuration parameters: Include.
 
 # Offense count: 2
 # Configuration parameters: Include.

+# Include: app/models/**/*.rb

 Rails/HasAndBelongsToMany:
 Rails/HasAndBelongsToMany:

-  Enabled: false
+  Exclude:
+    - 'app/models/changeset.rb'
+    - 'app/models/user.rb'
+
+# Offense count: 11
+# Configuration parameters: Include.
+# Include: app/helpers/**/*.rb
+Rails/HelperInstanceVariable:
+  Exclude:
+    - 'app/helpers/application_helper.rb'
+    - 'app/helpers/title_helper.rb'
+    - 'app/helpers/trace_helper.rb'

 
 # Offense count: 5
 
 # Offense count: 5

-Style/AccessorMethodName:
+# Configuration parameters: Include.
+# Include: db/migrate/*.rb
+Rails/NotNullColumn:
+  Exclude:
+    - 'db/migrate/002_cleanup_osm_db.rb'
+    - 'db/migrate/020_populate_node_tags_and_remove.rb'
+    - 'db/migrate/021_move_to_innodb.rb'
+    - 'db/migrate/025_add_end_time_to_changesets.rb'
+    - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
+
+# Offense count: 18
+Rails/OutputSafety:
+  Exclude:
+    - 'app/controllers/users_controller.rb'
+    - 'app/helpers/application_helper.rb'
+    - 'app/helpers/changesets_helper.rb'
+    - 'app/helpers/geocoder_helper.rb'
+    - 'app/helpers/note_helper.rb'
+    - 'app/helpers/open_graph_helper.rb'
+    - 'app/helpers/user_blocks_helper.rb'
+    - 'lib/rich_text.rb'
+    - 'test/helpers/application_helper_test.rb'
+
+# Offense count: 94
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: strict, flexible
+Rails/TimeZone:

   Enabled: false
 
 # Offense count: 1
   Enabled: false
 
 # Offense count: 1

+# Configuration parameters: AllowedChars.

 Style/AsciiComments:
 Style/AsciiComments:

-  Enabled: false
+  Exclude:
+    - 'test/models/message_test.rb'

 
 

-# Offense count: 305
+# Offense count: 255

 Style/Documentation:
   Enabled: false
 
 Style/Documentation:
   Enabled: false
 

-# Offense count: 39
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
+# Offense count: 503
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, never
+Style/FrozenStringLiteralComment:

   Enabled: false
 
   Enabled: false
 

-# Offense count: 60
+# Offense count: 2

 # Cop supports --auto-correct.
 # Cop supports --auto-correct.

-Style/LineEndConcatenation:
-  Enabled: false
+Style/IfUnlessModifier:
+  Exclude:
+    - 'app/controllers/api/ways_controller.rb'

 
 

-# Offense count: 53
+# Offense count: 74

 # Cop supports --auto-correct.
 # Cop supports --auto-correct.

+# Configuration parameters: Strict.

 Style/NumericLiterals:
   MinDigits: 11
 
 Style/NumericLiterals:
   MinDigits: 11
 

-# Offense count: 44
+# Offense count: 3320

 # Cop supports --auto-correct.
 # Cop supports --auto-correct.

-Style/PerlBackrefs:
-  Enabled: false
-
-# Offense count: 8
-# Configuration parameters: NamePrefix, NamePrefixBlacklist.
-Style/PredicateName:
-  Enabled: false
-
-# Offense count: 95
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/RaiseArgs:
-  Enabled: false
-
-# Offense count: 2
-Style/RescueModifier:
-  Enabled: false
-
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiteralsInInterpolation:
-  Enabled: false
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
-Style/TrivialAccessors:
-  Enabled: false
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 307