# This configuration was generated by
# `rubocop --auto-gen-config`
-# on 2020-08-06 20:53:30 UTC using RuboCop version 0.89.0.
+# on 2021-09-14 19:29:59 UTC using RuboCop version 1.21.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
-# versions of RuboCop, may require this file to be generated again.
# Work around erblint issues.
# https://github.com/openstreetmap/openstreetmap-website/issues/2472
- rubocop-minitest
- rubocop-performance
- rubocop-rails
+ - rubocop-rake
-# Offense count: 568
+# Offense count: 524
# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Layout/LineLength:
- Max: 370
+ Max: 270
+
+# Offense count: 62
+# Cop supports --auto-correct.
+Lint/AmbiguousOperatorPrecedence:
+ Exclude:
+ - 'app/controllers/geocoder_controller.rb'
+ - 'app/models/user.rb'
+ - 'lib/bounding_box.rb'
+ - 'lib/osm.rb'
+ - 'lib/rich_text.rb'
+ - 'lib/short_link.rb'
+ - 'test/controllers/api/old_nodes_controller_test.rb'
+ - 'test/lib/short_link_test.rb'
-# Offense count: 36
+# Offense count: 34
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
Exclude:
- 'app/controllers/users_controller.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/browse_tags_helper.rb'
- - 'app/mailers/notifier.rb'
+ - 'app/mailers/user_mailer.rb'
- 'app/models/client_application.rb'
- 'lib/nominatim.rb'
- 'lib/osm.rb'
- 'script/deliver-message'
-# Offense count: 682
-# Configuration parameters: IgnoredMethods.
+# Offense count: 8
+# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
+Lint/DuplicateBranch:
+ Exclude:
+ - 'app/controllers/api_controller.rb'
+ - 'app/controllers/diary_entries_controller.rb'
+ - 'app/controllers/geocoder_controller.rb'
+ - 'app/helpers/browse_tags_helper.rb'
+ - 'lib/password_hash.rb'
+
+# Offense count: 643
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
Metrics/AbcSize:
- Max: 194
+ Max: 189
-# Offense count: 72
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
-# ExcludedMethods: refine
+# Offense count: 69
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine
Metrics/BlockLength:
Max: 71
# Offense count: 25
# Configuration parameters: CountComments, CountAsOne.
Metrics/ClassLength:
- Max: 645
+ Max: 337
-# Offense count: 68
+# Offense count: 58
# Configuration parameters: IgnoredMethods.
Metrics/CyclomaticComplexity:
- Max: 26
+ Max: 25
-# Offense count: 735
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
+# Offense count: 716
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
Metrics/MethodLength:
Max: 179
-# Offense count: 4
-# Configuration parameters: CountKeywordArgs.
+# Offense count: 1
+# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
Metrics/ParameterLists:
- Max: 9
+ Max: 6
-# Offense count: 69
+# Offense count: 62
# Configuration parameters: IgnoredMethods.
Metrics/PerceivedComplexity:
Max: 26
-# Offense count: 540
+# Offense count: 528
Minitest/MultipleAssertions:
- Max: 81
-
-# Offense count: 26
-# Cop supports --auto-correct.
-Minitest/TestMethodName:
- Exclude:
- - 'test/abilities/api_capability_test.rb'
- - 'test/controllers/api/nodes_controller_test.rb'
- - 'test/controllers/api/old_nodes_controller_test.rb'
- - 'test/controllers/api/relations_controller_test.rb'
- - 'test/controllers/api/ways_controller_test.rb'
- - 'test/helpers/browse_helper_test.rb'
- - 'test/integration/client_applications_test.rb'
- - 'test/integration/short_links_test.rb'
- - 'test/integration/user_blocks_test.rb'
- - 'test/integration/user_creation_test.rb'
+ Max: 54
-# Offense count: 6
+# Offense count: 3
Naming/AccessorMethodName:
Exclude:
- 'app/controllers/application_controller.rb'
- 'app/helpers/title_helper.rb'
- - 'app/models/old_way.rb'
- 'lib/osm.rb'
- - 'lib/potlatch.rb'
# Offense count: 8
# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
# MethodDefinitionMacros: define_method, define_singleton_method
Naming/PredicateName:
Exclude:
- - 'spec/**/*'
- 'app/models/changeset.rb'
- 'app/models/old_node.rb'
- 'app/models/old_relation.rb'
- 'app/models/changeset.rb'
- 'app/models/user.rb'
-# Offense count: 4
+# Offense count: 3
# Configuration parameters: Include.
# Include: app/helpers/**/*.rb
Rails/HelperInstanceVariable:
- 'app/helpers/title_helper.rb'
# Offense count: 1
-# Cop supports --auto-correct.
# Configuration parameters: Include.
-# Include: app/mailers/**/*.rb
-Rails/MailerName:
+# Include: app/controllers/**/*.rb
+Rails/LexicallyScopedActionFilter:
Exclude:
- - 'app/mailers/notifier.rb'
+ - 'app/controllers/oauth2_applications_controller.rb'
# Offense count: 5
# Configuration parameters: Include.
- 'db/migrate/025_add_end_time_to_changesets.rb'
- 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
-# Offense count: 19
+# Offense count: 9
Rails/OutputSafety:
Exclude:
+ - 'app/controllers/sessions_controller.rb'
- 'app/controllers/users_controller.rb'
- 'app/helpers/application_helper.rb'
- - 'app/helpers/changesets_helper.rb'
- - 'app/helpers/geocoder_helper.rb'
- - 'app/helpers/note_helper.rb'
- - 'app/helpers/open_graph_helper.rb'
- - 'app/helpers/user_blocks_helper.rb'
- 'lib/rich_text.rb'
- 'test/helpers/application_helper_test.rb'
-# Offense count: 95
+# Offense count: 91
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: strict, flexible
# Offense count: 6
# Cop supports --auto-correct.
-Style/ExplicitBlockArgument:
+Rake/Desc:
Exclude:
- - 'app/controllers/api/amf_controller.rb'
- - 'app/controllers/application_controller.rb'
- - 'app/mailers/notifier.rb'
- - 'test/integration/client_applications_test.rb'
+ - 'lib/tasks/auto_annotate_models.rake'
+ - 'lib/tasks/eslint.rake'
+ - 'lib/tasks/subscribe_diary_authors.rake'
+ - 'lib/tasks/subscribe_old_changesets.rake'
-# Offense count: 572
+# Offense count: 602
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: always, always_true, never
Style/FrozenStringLiteralComment:
Enabled: false
-# Offense count: 78
+# Offense count: 73
# Cop supports --auto-correct.
# Configuration parameters: Strict.
Style/NumericLiterals:
- MinDigits: 11
-
-# Offense count: 20
-Style/OptionalBooleanParameter:
- Exclude:
- - 'app/controllers/api/notes_controller.rb'
- - 'app/controllers/application_controller.rb'
- - 'app/helpers/browse_helper.rb'
- - 'app/models/changeset.rb'
- - 'app/models/node.rb'
- - 'app/models/relation.rb'
- - 'app/models/trace.rb'
- - 'app/models/tracepoint.rb'
- - 'app/models/way.rb'
- - 'test/models/diary_entry_test.rb'
- - 'test/models/trace_test.rb'
- - 'test/models/tracetag_test.rb'
-
-# Offense count: 44
-# Cop supports --auto-correct.
-Style/StringConcatenation:
- Enabled: false
+ MinDigits: 15
projects / rails.git / blobdiff