Merge remote-tracking branch 'upstream/pull/5389'

[rails.git] / .rubocop.yml

diff --git a/.rubocop.yml b/.rubocop.yml
index 1ae01086a36590d17fcb82ec3578b495fedfa618..8b6ed018032c66c116e4b08fe6ba697e9c608a9d 100644 (file)
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,11 +1,16 @@
 inherit_from: .rubocop_todo.yml
 
 require:
 inherit_from: .rubocop_todo.yml
 
 require:

+  - rubocop-capybara
+  - rubocop-factory_bot
+  - rubocop-minitest

   - rubocop-performance
   - rubocop-rails
   - rubocop-performance
   - rubocop-rails

+  - rubocop-rake

 
 AllCops:
 
 AllCops:

-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 3.1
+  NewCops: enable

   Exclude:
     - 'vendor/**/*'
 
   Exclude:
     - 'vendor/**/*'
 


@@ -29,18 +34,27 @@ Metrics/ClassLength:
   Exclude:
     - 'test/**/*'
 
   Exclude:
     - 'test/**/*'
 

+Metrics/ModuleLength:
+  Max: 150
+

 Naming/FileName:
   Exclude:
     - 'script/deliver-message'
 Naming/FileName:
   Exclude:
     - 'script/deliver-message'

-    - 'script/locale/reload-languages'

     - 'script/update-spam-blocks'
 
 Naming/MethodParameterName:
   Enabled: false
 
     - 'script/update-spam-blocks'
 
 Naming/MethodParameterName:
   Enabled: false
 

+# This conflicts with Strong Migrations, which can't check `change_table`
+Rails/BulkChangeTable:
+  Enabled: false
+

 Rails/CreateTableWithTimestamps:
   Enabled: false
 
 Rails/CreateTableWithTimestamps:
   Enabled: false
 

+Rails/FindBy:
+  IgnoreWhereFirst: false
+

 Rails/FindEach:
   Enabled: false
 
 Rails/FindEach:
   Enabled: false
 


@@ -50,7 +64,7 @@ Rails/HasManyOrHasOneDependent:
 Rails/HttpPositionalArguments:
   Enabled: false
 
 Rails/HttpPositionalArguments:
   Enabled: false
 

-Rails/InverseOf:
+Rails/ReflectionClassName:

   Enabled: false
 
 Rails/SkipsModelValidations:
   Enabled: false
 
 Rails/SkipsModelValidations:


@@ -58,14 +72,12 @@ Rails/SkipsModelValidations:
     - 'db/migrate/*.rb'
     - 'app/controllers/users_controller.rb'
 
     - 'db/migrate/*.rb'
     - 'app/controllers/users_controller.rb'
 

-Style/BracesAroundHashParameters:
-  EnforcedStyle: context_dependent
-

 Style/Documentation:
   Enabled: false
 
 Style/FormatStringToken:
 Style/Documentation:
   Enabled: false
 
 Style/FormatStringToken:

-  EnforcedStyle: template
+  Exclude:
+    - 'config/routes.rb'

 
 Style/IfInsideElse:
   Enabled: false
 
 Style/IfInsideElse:
   Enabled: false


@@ -73,12 +85,21 @@ Style/IfInsideElse:
 Style/GuardClause:
   Enabled: false
 
 Style/GuardClause:
   Enabled: false
 

+Style/HashEachMethods:
+  Enabled: true
+

 Style/HashSyntax:
   EnforcedStyle: hash_rockets
   Exclude:
     - 'lib/tasks/testing.rake'
     - 'config/initializers/wrap_parameters.rb'
 
 Style/HashSyntax:
   EnforcedStyle: hash_rockets
   Exclude:
     - 'lib/tasks/testing.rake'
     - 'config/initializers/wrap_parameters.rb'
 

+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+

 Style/MixinUsage:
   Exclude:
     - 'bin/setup'
 Style/MixinUsage:
   Exclude:
     - 'bin/setup'