Fix rubocop style issues

[rails.git] / app / controllers / diary_entry_controller.rb

diff --git a/app/controllers/diary_entry_controller.rb b/app/controllers/diary_entry_controller.rb
index 091744e2226256e0d6aba9cd283a68ec37b896df..5129963f80795e0fb7d61099d81e469d5367a296 100644 (file)
--- a/app/controllers/diary_entry_controller.rb
+++ b/app/controllers/diary_entry_controller.rb
@@ -38,12 +38,12 @@ class DiaryEntryController < ApplicationController
   end
 
   def edit
   end
 
   def edit

-    @title= t 'diary_entry.edit.title'
+    @title = t 'diary_entry.edit.title'

     @diary_entry = DiaryEntry.find(params[:id])
 
     if @user != @diary_entry.user
       redirect_to :controller => 'diary_entry', :action => 'view', :id => params[:id]
     @diary_entry = DiaryEntry.find(params[:id])
 
     if @user != @diary_entry.user
       redirect_to :controller => 'diary_entry', :action => 'view', :id => params[:id]

-    elsif params[:diary_entry] and @diary_entry.update_attributes(entry_params)
+    elsif params[:diary_entry] && @diary_entry.update_attributes(entry_params)

       redirect_to :controller => 'diary_entry', :action => 'view', :id => params[:id]
     end
 
       redirect_to :controller => 'diary_entry', :action => 'view', :id => params[:id]
     end
 


@@ -58,7 +58,7 @@ class DiaryEntryController < ApplicationController
     @diary_comment.user = @user
     if @diary_comment.save
       if @diary_comment.user != @entry.user
     @diary_comment.user = @user
     if @diary_comment.save
       if @diary_comment.user != @entry.user

-        Notifier.diary_comment_notification(@diary_comment).deliver
+        Notifier.diary_comment_notification(@diary_comment).deliver_now

       end
 
       redirect_to :controller => 'diary_entry', :action => 'view', :display_name => @entry.user.display_name, :id => @entry.id
       end
 
       redirect_to :controller => 'diary_entry', :action => 'view', :display_name => @entry.user.display_name, :id => @entry.id


@@ -85,20 +85,20 @@ class DiaryEntryController < ApplicationController
         @title = t 'diary_entry.list.title_friends'
         @entries = DiaryEntry.where(:user_id => @user.friend_users)
       else
         @title = t 'diary_entry.list.title_friends'
         @entries = DiaryEntry.where(:user_id => @user.friend_users)
       else

-          require_user
-          return
+        require_user
+        return

       end
     elsif params[:nearby]
       if @user
         @title = t 'diary_entry.list.title_nearby'
         @entries = DiaryEntry.where(:user_id => @user.nearby)
       else
       end
     elsif params[:nearby]
       if @user
         @title = t 'diary_entry.list.title_nearby'
         @entries = DiaryEntry.where(:user_id => @user.nearby)
       else

-          require_user
-          return
+        require_user
+        return

       end
     else
       end
     else

-      @entries = DiaryEntry.joins(:user).where(:users => { :status => ["active", "confirmed"] })
-      
+      @entries = DiaryEntry.joins(:user).where(:users => { :status => %w(active confirmed) })
+

       if params[:language]
         @title = t 'diary_entry.list.in_language_title', :language => Language.find(params[:language]).english_name
         @entries = @entries.where(:language_code => params[:language])
       if params[:language]
         @title = t 'diary_entry.list.in_language_title', :language => Language.find(params[:language]).english_name
         @entries = @entries.where(:language_code => params[:language])


@@ -131,7 +131,7 @@ class DiaryEntryController < ApplicationController
         return
       end
     else
         return
       end
     else

-      @entries = DiaryEntry.joins(:user).where(:users => { :status => ["active", "confirmed"] })
+      @entries = DiaryEntry.joins(:user).where(:users => { :status => %w(active confirmed) })

 
       if params[:language]
         @entries = @entries.where(:language_code => params[:language])
 
       if params[:language]
         @entries = @entries.where(:language_code => params[:language])


@@ -180,7 +180,9 @@ class DiaryEntryController < ApplicationController
                                          :per_page => 20)
     @page = (params[:page] || 1).to_i
   end
                                          :per_page => 20)
     @page = (params[:page] || 1).to_i
   end

-private
+
+  private
+

   ##
   # return permitted diary entry parameters
   def entry_params
   ##
   # return permitted diary entry parameters
   def entry_params


@@ -206,17 +208,17 @@ private
   ##
   # is this list user specific?
   def user_specific_list?
   ##
   # is this list user specific?
   def user_specific_list?

-    params[:friends] or params[:nearby]
+    params[:friends] || params[:nearby]

   end
 
   ##
   # decide on a location for the diary entry map
   def set_map_location
   end
 
   ##
   # decide on a location for the diary entry map
   def set_map_location

-    if @diary_entry.latitude and @diary_entry.longitude
+    if @diary_entry.latitude && @diary_entry.longitude

       @lon = @diary_entry.longitude
       @lat = @diary_entry.latitude
       @zoom = 12
       @lon = @diary_entry.longitude
       @lat = @diary_entry.latitude
       @zoom = 12

-    elsif @user.home_lat.nil? or @user.home_lon.nil?
+    elsif @user.home_lat.nil? || @user.home_lon.nil?

       @lon = params[:lon] || -0.1
       @lat = params[:lat] || 51.5
       @zoom = params[:zoom] || 4
       @lon = params[:lon] || -0.1
       @lat = params[:lat] || 51.5
       @zoom = params[:zoom] || 4