Always check changes/comments counts in single changeset tests

[rails.git] / test / abilities / api_capability_test.rb

diff --git a/test/abilities/api_capability_test.rb b/test/abilities/api_capability_test.rb
index ca679dd717f338b5f7edb1e6f6fb4d57bbeeb1bf..58c8f7fe7141f95fee59b393beb65fc74dbe1d87 100644 (file)
--- a/test/abilities/api_capability_test.rb
+++ b/test/abilities/api_capability_test.rb
@@ -3,18 +3,20 @@
 require "test_helper"
 
 class ChangesetCommentApiCapabilityTest < ActiveSupport::TestCase
 require "test_helper"
 
 class ChangesetCommentApiCapabilityTest < ActiveSupport::TestCase

-  test "as a normal user with permissionless token" do
-    token = create(:oauth_access_token)
-    ability = ApiAbility.new token
+  test "as a normal user without scopes" do
+    user = create(:user)
+    scopes = Set.new
+    ability = ApiAbility.new user, scopes

 
     [:create, :destroy, :restore].each do |action|
       assert ability.cannot? action, ChangesetComment
     end
   end
 
 
     [:create, :destroy, :restore].each do |action|
       assert ability.cannot? action, ChangesetComment
     end
   end
 

-  test "as a normal user with write_api token" do
-    token = create(:oauth_access_token, :scopes => %w[write_api])
-    ability = ApiAbility.new token
+  test "as a normal user with write_changeset_comments scope" do
+    user = create(:user)
+    scopes = Set.new %w[write_changeset_comments]
+    ability = ApiAbility.new user, scopes

 
     [:destroy, :restore].each do |action|
       assert ability.cannot? action, ChangesetComment
 
     [:destroy, :restore].each do |action|
       assert ability.cannot? action, ChangesetComment


@@ -25,18 +27,20 @@ class ChangesetCommentApiCapabilityTest < ActiveSupport::TestCase
     end
   end
 
     end
   end
 

-  test "as a moderator with permissionless token" do
-    token = create(:oauth_access_token, :user => create(:moderator_user))
-    ability = ApiAbility.new token
+  test "as a moderator without scopes" do
+    user = create(:moderator_user)
+    scopes = Set.new
+    ability = ApiAbility.new user, scopes

 
     [:create, :destroy, :restore].each do |action|
       assert ability.cannot? action, ChangesetComment
     end
   end
 
 
     [:create, :destroy, :restore].each do |action|
       assert ability.cannot? action, ChangesetComment
     end
   end
 

-  test "as a moderator with write_api token" do
-    token = create(:oauth_access_token, :user => create(:moderator_user), :scopes => %w[write_api])
-    ability = ApiAbility.new token
+  test "as a moderator with write_changeset_comments scope" do
+    user = create(:moderator_user)
+    scopes = Set.new %w[write_changeset_comments]
+    ability = ApiAbility.new user, scopes

 
     [:create, :destroy, :restore].each do |action|
       assert ability.can? action, ChangesetComment
 
     [:create, :destroy, :restore].each do |action|
       assert ability.can? action, ChangesetComment


@@ -45,18 +49,20 @@ class ChangesetCommentApiCapabilityTest < ActiveSupport::TestCase
 end
 
 class NoteApiCapabilityTest < ActiveSupport::TestCase
 end
 
 class NoteApiCapabilityTest < ActiveSupport::TestCase

-  test "as a normal user with permissionless token" do
-    token = create(:oauth_access_token)
-    ability = ApiAbility.new token
+  test "as a normal user without scopes" do
+    user = create(:user)
+    scopes = Set.new
+    ability = ApiAbility.new user, scopes

 
     [:create, :comment, :close, :reopen, :destroy].each do |action|
       assert ability.cannot? action, Note
     end
   end
 
 
     [:create, :comment, :close, :reopen, :destroy].each do |action|
       assert ability.cannot? action, Note
     end
   end
 

-  test "as a normal user with write_notes token" do
-    token = create(:oauth_access_token, :scopes => %w[write_notes])
-    ability = ApiAbility.new token
+  test "as a normal user with write_notes scope" do
+    user = create(:user)
+    scopes = Set.new %w[write_notes]
+    ability = ApiAbility.new user, scopes

 
     [:destroy].each do |action|
       assert ability.cannot? action, Note
 
     [:destroy].each do |action|
       assert ability.cannot? action, Note


@@ -67,18 +73,20 @@ class NoteApiCapabilityTest < ActiveSupport::TestCase
     end
   end
 
     end
   end
 

-  test "as a moderator with permissionless token" do
-    token = create(:oauth_access_token, :user => create(:moderator_user))
-    ability = ApiAbility.new token
+  test "as a moderator without scopes" do
+    user = create(:moderator_user)
+    scopes = Set.new
+    ability = ApiAbility.new user, scopes

 
     [:destroy].each do |action|
       assert ability.cannot? action, Note
     end
   end
 
 
     [:destroy].each do |action|
       assert ability.cannot? action, Note
     end
   end
 

-  test "as a moderator with write_notes token" do
-    token = create(:oauth_access_token, :user => create(:moderator_user), :scopes => %w[write_notes])
-    ability = ApiAbility.new token
+  test "as a moderator with write_notes scope" do
+    user = create(:moderator_user)
+    scopes = Set.new %w[write_notes]
+    ability = ApiAbility.new user, scopes

 
     [:destroy].each do |action|
       assert ability.can? action, Note
 
     [:destroy].each do |action|
       assert ability.can? action, Note


@@ -88,16 +96,16 @@ end
 
 class UserApiCapabilityTest < ActiveSupport::TestCase
   test "user preferences" do
 
 class UserApiCapabilityTest < ActiveSupport::TestCase
   test "user preferences" do

-    # A user with empty tokens
-    token = create(:oauth_access_token)
-    ability = ApiAbility.new token
+    user = create(:user)
+    scopes = Set.new
+    ability = ApiAbility.new user, scopes

 
     [:index, :show, :update_all, :update, :destroy].each do |act|
       assert ability.cannot? act, UserPreference
     end
 
 
     [:index, :show, :update_all, :update, :destroy].each do |act|
       assert ability.cannot? act, UserPreference
     end
 

-    token = create(:oauth_access_token, :scopes => %w[read_prefs])
-    ability = ApiAbility.new token
+    scopes = Set.new %w[read_prefs]
+    ability = ApiAbility.new user, scopes

 
     [:update_all, :update, :destroy].each do |act|
       assert ability.cannot? act, UserPreference
 
     [:update_all, :update, :destroy].each do |act|
       assert ability.cannot? act, UserPreference


@@ -107,8 +115,8 @@ class UserApiCapabilityTest < ActiveSupport::TestCase
       assert ability.can? act, UserPreference
     end
 
       assert ability.can? act, UserPreference
     end
 

-    token = create(:oauth_access_token, :scopes => %w[write_prefs])
-    ability = ApiAbility.new token
+    scopes = Set.new %w[write_prefs]
+    ability = ApiAbility.new user, scopes

 
     [:index, :show].each do |act|
       assert ability.cannot? act, UserPreference
 
     [:index, :show].each do |act|
       assert ability.cannot? act, UserPreference