- el1['lat'] = self.latitude.to_s
- el1['lon'] = self.longitude.to_s
- el1['user'] = self.user.display_name if self.user.data_public?
- Node.split_tags(el1, self.tags)
+ el1['lat'] = self.lat.to_s
+ el1['lon'] = self.lon.to_s
+
+ user_display_name_cache = {} if user_display_name_cache.nil?
+
+ if user_display_name_cache and user_display_name_cache.key?(self.user_id)
+ # use the cache if available
+ elsif self.user.data_public?
+ user_display_name_cache[self.user_id] = self.user.display_name
+ else
+ user_display_name_cache[self.user_id] = nil
+ end
+
+ el1['user'] = user_display_name_cache[self.user_id] unless user_display_name_cache[self.user_id].nil?
+
+ Tags.split(self.tags) do |k,v|
+ el2 = XML::Node.new('tag')
+ el2['k'] = k.to_s
+ el2['v'] = v.to_s
+ el1 << el2
+ end
+