Tidy up mail notifiers and make them more rails style rather then

[rails.git] / app / models / trace.rb

diff --git a/app/models/trace.rb b/app/models/trace.rb
index 8f99e7bd8cb57bfc35954a5e8b687638d7cd0beb..baf2ea7d27592dba4c88baebbfd734f1a8c0ed17 100644 (file)
--- a/app/models/trace.rb
+++ b/app/models/trace.rb
@@ -175,7 +175,12 @@ class Trace < ActiveRecord::Base
       f_lon = 0
       first = true
 
       f_lon = 0
       first = true
 

-      Tracepoint.delete_all(['gpx_id = ?', self.id])
+      # If there are any existing points for this trace then delete
+      # them - we check for existing points first to avoid locking
+      # the table in the common case where there aren't any.
+      if Tracepoint.exists?(['gpx_id = ?', self.id])
+        Tracepoint.delete_all(['gpx_id = ?', self.id])
+      end

 
       gpx.points do |point|
         if first
 
       gpx.points do |point|
         if first


@@ -185,10 +190,9 @@ class Trace < ActiveRecord::Base
 
         tp = Tracepoint.new
         tp.lat = point['latitude'].to_f
 
         tp = Tracepoint.new
         tp.lat = point['latitude'].to_f

-        tp.lng = point['longitude'].to_f
+        tp.lon = point['longitude'].to_f

         tp.altitude = point['altitude'].to_f
         tp.timestamp = point['timestamp']
         tp.altitude = point['altitude'].to_f
         tp.timestamp = point['timestamp']

-        tp.user_id = user.id

         tp.gpx_id = id
         tp.trackid = point['segment'].to_i
         tp.save!
         tp.gpx_id = id
         tp.trackid = point['segment'].to_i
         tp.save!


@@ -200,10 +204,10 @@ class Trace < ActiveRecord::Base
         max_lon = Tracepoint.maximum('longitude', :conditions => ['gpx_id = ?', id])
         min_lon = Tracepoint.minimum('longitude', :conditions => ['gpx_id = ?', id])
 
         max_lon = Tracepoint.maximum('longitude', :conditions => ['gpx_id = ?', id])
         min_lon = Tracepoint.minimum('longitude', :conditions => ['gpx_id = ?', id])
 

-        max_lat = max_lat.to_f / 1000000
-        min_lat = min_lat.to_f / 1000000
-        max_lon = max_lon.to_f / 1000000
-        min_lon = min_lon.to_f / 1000000
+        max_lat = max_lat.to_f / 10000000
+        min_lat = min_lat.to_f / 10000000
+        max_lon = max_lon.to_f / 10000000
+        min_lon = min_lon.to_f / 10000000

 
         self.latitude = f_lat
         self.longitude = f_lon
 
         self.latitude = f_lat
         self.longitude = f_lon


@@ -211,7 +215,7 @@ class Trace < ActiveRecord::Base
         self.icon_picture = gpx.get_icon(min_lat, min_lon, max_lat, max_lon)
         self.size = gpx.actual_points
         self.inserted = true
         self.icon_picture = gpx.get_icon(min_lat, min_lon, max_lat, max_lon)
         self.size = gpx.actual_points
         self.inserted = true

-        self.save
+        self.save!

       end
 
       logger.info "done trace #{id}"
       end
 
       logger.info "done trace #{id}"