Fix more rubocop style issues

[rails.git] / app / controllers / user_preference_controller.rb

diff --git a/app/controllers/user_preference_controller.rb b/app/controllers/user_preference_controller.rb
index 7d6fc8e236a1b35215084acef64a523b471a4b92..78f310ce50557d1a4a3f7e77baefa9d6693d92fe 100644 (file)
--- a/app/controllers/user_preference_controller.rb
+++ b/app/controllers/user_preference_controller.rb
@@ -13,7 +13,7 @@ class UserPreferenceController < ApplicationController
 
     prefs = @user.preferences
 
 
     prefs = @user.preferences
 

-    el1 = XML::Node.new 'preferences'
+    el1 = XML::Node.new "preferences"

 
     prefs.each do |pref|
       el1 <<  pref.to_xml_node
 
     prefs.each do |pref|
       el1 <<  pref.to_xml_node


@@ -33,20 +33,19 @@ class UserPreferenceController < ApplicationController
 
   # update the entire set of preferences
   def update
 
   # update the entire set of preferences
   def update

-    old_preferences = @user.preferences.reduce({}) do |preferences,preference|
+    old_preferences = @user.preferences.each_with_object({}) do |preference, preferences|

       preferences[preference.k] = preference
       preferences[preference.k] = preference

-      preferences

     end
 
     new_preferences = {}
 
     doc = XML::Parser.string(request.raw_post).parse
 
     end
 
     new_preferences = {}
 
     doc = XML::Parser.string(request.raw_post).parse
 

-    doc.find('//preferences/preference').each do |pt|
+    doc.find("//preferences/preference").each do |pt|

       if preference = old_preferences.delete(pt["k"])
         preference.v = pt["v"]
       elsif new_preferences.include?(pt["k"])
       if preference = old_preferences.delete(pt["k"])
         preference.v = pt["v"]
       elsif new_preferences.include?(pt["k"])

-        raise OSM::APIDuplicatePreferenceError.new(pt["k"])
+        fail OSM::APIDuplicatePreferenceError.new(pt["k"])

       else
         preference = @user.preferences.build(:k => pt["k"], :v => pt["v"])
       end
       else
         preference = @user.preferences.build(:k => pt["k"], :v => pt["v"])
       end


@@ -54,13 +53,9 @@ class UserPreferenceController < ApplicationController
       new_preferences[preference.k] = preference
     end
 
       new_preferences[preference.k] = preference
     end
 

-    old_preferences.each_value do |preference|
-      preference.delete
-    end
+    old_preferences.each_value(&:delete)

 
 

-    new_preferences.each_value do |preference|
-      preference.save!
-    end
+    new_preferences.each_value(&:save!)

 
     render :text => "", :content_type => "text/plain"
   end
 
     render :text => "", :content_type => "text/plain"
   end