Merge pull request #5558 from tomhughes/var-let-const

[rails.git] / app / assets / javascripts / index.js

diff --git a/app/assets/javascripts/index.js b/app/assets/javascripts/index.js
index 49266f919f374770f0b7463020c0dae762e4e424..194ed82f7451098bd318d63a661a2b35221087c0 100644 (file)
--- a/app/assets/javascripts/index.js
+++ b/app/assets/javascripts/index.js
@@ -1,7 +1,7 @@
 //= require_self
 //= require leaflet.sidebar
 //= require leaflet.sidebar-pane
 //= require_self
 //= require leaflet.sidebar
 //= require leaflet.sidebar-pane

-//= require leaflet.locatecontrol/src/L.Control.Locate
+//= require leaflet.locatecontrol/dist/L.Control.Locate.umd

 //= require leaflet.locate
 //= require leaflet.layers
 //= require leaflet.key
 //= require leaflet.locate
 //= require leaflet.layers
 //= require leaflet.key


@@ -12,22 +12,20 @@
 //= require leaflet.contextmenu
 //= require index/contextmenu
 //= require index/search
 //= require leaflet.contextmenu
 //= require index/contextmenu
 //= require index/search

-//= require index/browse
+//= require index/layers/data

 //= require index/export
 //= require index/export

-//= require index/notes
+//= require index/layers/notes

 //= require index/history
 //= require index/note
 //= require index/new_note
 //= require index/directions
 //= require index/changeset
 //= require index/query
 //= require index/history
 //= require index/note
 //= require index/new_note
 //= require index/directions
 //= require index/changeset
 //= require index/query

+//= require index/home

 //= require router
 //= require router

-//= require qs/dist/qs

 
 $(document).ready(function () {
 
 $(document).ready(function () {

-  var loaderTimeout;
-
-  var map = new L.OSM.Map("map", {
+  const map = new L.OSM.Map("map", {

     zoomControl: false,
     layerControl: false,
     contextmenu: true,
     zoomControl: false,
     layerControl: false,
     contextmenu: true,


@@ -35,18 +33,14 @@ $(document).ready(function () {
   });
 
   OSM.loadSidebarContent = function (path, callback) {
   });
 
   OSM.loadSidebarContent = function (path, callback) {

-    var content_path = path;
+    let content_path = path;

 
     map.setSidebarOverlaid(false);
 
 
     map.setSidebarOverlaid(false);
 

-    clearTimeout(loaderTimeout);
-
-    loaderTimeout = setTimeout(function () {
-      $("#sidebar_loader").show();
-    }, 200);
+    $("#sidebar_loader").show().addClass("delayed-fade-in");

 
 

-    // IE<10 doesn't respect Vary: X-Requested-With header, so
-    // prevent caching the XHR response as a full-page URL.
+    // Prevent caching the XHR response as a full-page URL
+    // https://github.com/openstreetmap/openstreetmap-website/issues/5663

     if (content_path.indexOf("?") >= 0) {
       content_path += "&xhr=1";
     } else {
     if (content_path.indexOf("?") >= 0) {
       content_path += "&xhr=1";
     } else {


@@ -56,20 +50,18 @@ $(document).ready(function () {
     $("#sidebar_content")
       .empty();
 
     $("#sidebar_content")
       .empty();
 

-    $.ajax({
-      url: content_path,
-      dataType: "html",
-      complete: function (xhr) {
-        clearTimeout(loaderTimeout);
+    fetch(content_path, { headers: { "accept": "text/html", "x-requested-with": "XMLHttpRequest" } })
+      .then(response => {

         $("#flash").empty();
         $("#flash").empty();

-        $("#sidebar_loader").hide();
+        $("#sidebar_loader").removeClass("delayed-fade-in").hide();

 
 

-        var content = $(xhr.responseText);
+        const title = response.headers.get("X-Page-Title");
+        if (title) document.title = decodeURIComponent(title);

 
 

-        if (xhr.getResponseHeader("X-Page-Title")) {
-          var title = xhr.getResponseHeader("X-Page-Title");
-          document.title = decodeURIComponent(title);
-        }
+        return response.text();
+      })
+      .then(html => {
+        const content = $(html);

 
         $("head")
           .find("link[type=\"application/atom+xml\"]")
 
         $("head")
           .find("link[type=\"application/atom+xml\"]")


@@ -83,11 +75,10 @@ $(document).ready(function () {
         if (callback) {
           callback();
         }
         if (callback) {
           callback();
         }

-      }
-    });
+      });

   };
 
   };
 

-  var params = OSM.mapParams();
+  const params = OSM.mapParams();

 
   map.attributionControl.setPrefix("");
 
 
   map.attributionControl.setPrefix("");
 


@@ -99,21 +90,19 @@ $(document).ready(function () {
     }
   });
 
     }
   });
 

-  var sidebar = L.OSM.sidebar("#map-ui")
+  const sidebar = L.OSM.sidebar("#map-ui")

     .addTo(map);
 
     .addTo(map);
 

-  var position = $("html").attr("dir") === "rtl" ? "topleft" : "topright";
+  const position = $("html").attr("dir") === "rtl" ? "topleft" : "topright";

 
   function addControlGroup(controls) {
 
   function addControlGroup(controls) {

-    controls.forEach(function (control) {
-      control.addTo(map);
-    });
+    for (const control of controls) control.addTo(map);

 
 

-    var firstContainer = controls[0].getContainer();
+    const firstContainer = controls[0].getContainer();

     $(firstContainer).find(".control-button").first()
       .addClass("control-button-first");
 
     $(firstContainer).find(".control-button").first()
       .addClass("control-button-first");
 

-    var lastContainer = controls[controls.length - 1].getContainer();
+    const lastContainer = controls[controls.length - 1].getContainer();

     $(lastContainer).find(".control-button").last()
       .addClass("control-button-last");
   }
     $(lastContainer).find(".control-button").last()
       .addClass("control-button-last");
   }


@@ -160,12 +149,12 @@ $(document).ready(function () {
   OSM.initializeContextMenu(map);
 
   if (OSM.STATUS !== "api_offline" && OSM.STATUS !== "database_offline") {
   OSM.initializeContextMenu(map);
 
   if (OSM.STATUS !== "api_offline" && OSM.STATUS !== "database_offline") {

-    OSM.initializeNotes(map);
+    OSM.initializeNotesLayer(map);

     if (params.layers.indexOf(map.noteLayer.options.code) >= 0) {
       map.addLayer(map.noteLayer);
     }
 
     if (params.layers.indexOf(map.noteLayer.options.code) >= 0) {
       map.addLayer(map.noteLayer);
     }
 

-    OSM.initializeBrowse(map);
+    OSM.initializeDataLayer(map);

     if (params.layers.indexOf(map.dataLayer.options.code) >= 0) {
       map.addLayer(map.dataLayer);
     }
     if (params.layers.indexOf(map.dataLayer.options.code) >= 0) {
       map.addLayer(map.dataLayer);
     }


@@ -175,13 +164,12 @@ $(document).ready(function () {
     }
   }
 
     }
   }
 

-  var placement = $("html").attr("dir") === "rtl" ? "right" : "left";
-  $(".leaflet-control .control-button").tooltip({ placement: placement, container: "body" });
+  $(".leaflet-control .control-button").tooltip({ placement: "left", container: "body" });

 
 

-  var expiry = new Date();
+  const expiry = new Date();

   expiry.setYear(expiry.getFullYear() + 10);
 
   expiry.setYear(expiry.getFullYear() + 10);
 

-  map.on("moveend layeradd layerremove", function () {
+  map.on("moveend baselayerchange overlayadd overlayremove", function () {

     updateLinks(
       map.getCenter().wrap(),
       map.getZoom(),
     updateLinks(
       map.getCenter().wrap(),
       map.getZoom(),


@@ -192,19 +180,19 @@ $(document).ready(function () {
   });
 
   if (Cookies.get("_osm_welcome") !== "hide") {
   });
 
   if (Cookies.get("_osm_welcome") !== "hide") {

-    $(".welcome").addClass("visible");
+    $(".welcome").removeAttr("hidden");

   }
 
   $(".welcome .btn-close").on("click", function () {
   }
 
   $(".welcome .btn-close").on("click", function () {

-    $(".welcome").removeClass("visible");
+    $(".welcome").hide();

     Cookies.set("_osm_welcome", "hide", { secure: true, expires: expiry, path: "/", samesite: "lax" });
   });
 
     Cookies.set("_osm_welcome", "hide", { secure: true, expires: expiry, path: "/", samesite: "lax" });
   });
 

-  var bannerExpiry = new Date();
+  const bannerExpiry = new Date();

   bannerExpiry.setYear(bannerExpiry.getFullYear() + 1);
 
   $("#banner .btn-close").on("click", function (e) {
   bannerExpiry.setYear(bannerExpiry.getFullYear() + 1);
 
   $("#banner .btn-close").on("click", function (e) {

-    var cookieId = e.target.id;
+    const cookieId = e.target.id;

     $("#banner").hide();
     e.preventDefault();
     if (cookieId) {
     $("#banner").hide();
     e.preventDefault();
     if (cookieId) {


@@ -213,9 +201,9 @@ $(document).ready(function () {
   });
 
   if (OSM.MATOMO) {
   });
 
   if (OSM.MATOMO) {

-    map.on("layeradd", function (e) {
+    map.on("baselayerchange overlayadd", function (e) {

       if (e.layer.options) {
       if (e.layer.options) {

-        var goal = OSM.MATOMO.goals[e.layer.options.keyid];
+        const goal = OSM.MATOMO.goals[e.layer.options.layerId];

 
         if (goal) {
           $("body").trigger("matomogoal", goal);
 
         if (goal) {
           $("body").trigger("matomogoal", goal);


@@ -234,49 +222,30 @@ $(document).ready(function () {
     L.marker([params.mlat, params.mlon]).addTo(map);
   }
 
     L.marker([params.mlat, params.mlon]).addTo(map);
   }
 

-  $("#homeanchor").on("click", function (e) {
-    e.preventDefault();
-
-    var data = $(this).data(),
-        center = L.latLng(data.lat, data.lon);
-
-    map.setView(center, data.zoom);
-    L.marker(center, { icon: OSM.getUserIcon() }).addTo(map);
-  });
-

   function remoteEditHandler(bbox, object) {
   function remoteEditHandler(bbox, object) {

-    var remoteEditHost = "http://127.0.0.1:8111",
-        osmHost = location.protocol + "//" + location.host,
-        query = {
-          left: bbox.getWest() - 0.0001,
-          top: bbox.getNorth() + 0.0001,
-          right: bbox.getEast() + 0.0001,
-          bottom: bbox.getSouth() - 0.0001
-        };
-
-    if (object && object.type !== "note") query.select = object.type + object.id; // can't select notes
-    sendRemoteEditCommand(remoteEditHost + "/load_and_zoom?" + Qs.stringify(query), function () {
+    const remoteEditHost = "http://127.0.0.1:8111",
+          osmHost = location.protocol + "//" + location.host,
+          query = new URLSearchParams({
+            left: bbox.getWest() - 0.0001,
+            top: bbox.getNorth() + 0.0001,
+            right: bbox.getEast() + 0.0001,
+            bottom: bbox.getSouth() - 0.0001
+          });
+
+    if (object && object.type !== "note") query.set("select", object.type + object.id); // can't select notes
+    sendRemoteEditCommand(remoteEditHost + "/load_and_zoom?" + query, function () {

       if (object && object.type === "note") {
       if (object && object.type === "note") {

-        var noteQuery = { url: osmHost + OSM.apiUrl(object) };
-        sendRemoteEditCommand(remoteEditHost + "/import?" + Qs.stringify(noteQuery));
+        const noteQuery = new URLSearchParams({ url: osmHost + OSM.apiUrl(object) });
+        sendRemoteEditCommand(remoteEditHost + "/import?" + noteQuery);

       }
     });
 
     function sendRemoteEditCommand(url, callback) {
       }
     });
 
     function sendRemoteEditCommand(url, callback) {

-      var iframe = $("<iframe>");
-      var timeoutId = setTimeout(function () {
-        alert(I18n.t("site.index.remote_failed"));
-        iframe.remove();
-      }, 5000);
-
-      iframe
-        .hide()
-        .appendTo("body")
-        .attr("src", url)
-        .on("load", function () {
-          clearTimeout(timeoutId);
-          iframe.remove();
-          if (callback) callback();
+      fetch(url, { mode: "no-cors", signal: AbortSignal.timeout(5000) })
+        .then(callback)
+        .catch(function () {
+          // eslint-disable-next-line no-alert
+          alert(I18n.t("site.index.remote_failed"));

         });
     }
 
         });
     }
 


@@ -284,7 +253,7 @@ $(document).ready(function () {
   }
 
   $("a[data-editor=remote]").click(function (e) {
   }
 
   $("a[data-editor=remote]").click(function (e) {

-    var params = OSM.mapParams(this.search);
+    const params = OSM.mapParams(this.search);

     remoteEditHandler(map.getBounds(), params.object);
     e.preventDefault();
   });
     remoteEditHandler(map.getBounds(), params.object);
     e.preventDefault();
   });


@@ -304,7 +273,7 @@ $(document).ready(function () {
   }
 
   OSM.Index = function (map) {
   }
 
   OSM.Index = function (map) {

-    var page = {};
+    const page = {};

 
     page.pushstate = page.popstate = function () {
       map.setSidebarOverlaid(true);
 
     page.pushstate = page.popstate = function () {
       map.setSidebarOverlaid(true);


@@ -312,9 +281,9 @@ $(document).ready(function () {
     };
 
     page.load = function () {
     };
 
     page.load = function () {

-      var params = Qs.parse(location.search.substring(1));
-      if (params.query) {
-        $("#sidebar .search_form input[name=query]").value(params.query);
+      const params = new URLSearchParams(location.search);
+      if (params.has("query")) {
+        $("#sidebar .search_form input[name=query]").value(params.get("query"));

       }
       if (!("autofocus" in document.createElement("input"))) {
         $("#sidebar .search_form input[name=query]").focus();
       }
       if (!("autofocus" in document.createElement("input"))) {
         $("#sidebar .search_form input[name=query]").focus();


@@ -326,7 +295,7 @@ $(document).ready(function () {
   };
 
   OSM.Browse = function (map, type) {
   };
 
   OSM.Browse = function (map, type) {

-    var page = {};
+    const page = {};

 
     page.pushstate = page.popstate = function (path, id) {
       OSM.loadSidebarContent(path, function () {
 
     page.pushstate = page.popstate = function (path, id) {
       OSM.loadSidebarContent(path, function () {


@@ -339,18 +308,15 @@ $(document).ready(function () {
     };
 
     function addObject(type, id, center) {
     };
 
     function addObject(type, id, center) {

+      const hashParams = OSM.parseHash(window.location.hash);

       map.addObject({ type: type, id: parseInt(id, 10) }, function (bounds) {
       map.addObject({ type: type, id: parseInt(id, 10) }, function (bounds) {

-        if (!window.location.hash && bounds.isValid() &&
+        if (!hashParams.center && bounds.isValid() &&

             (center || !map.getBounds().contains(bounds))) {
           OSM.router.withoutMoveListener(function () {
             map.fitBounds(bounds);
           });
         }
       });
             (center || !map.getBounds().contains(bounds))) {
           OSM.router.withoutMoveListener(function () {
             map.fitBounds(bounds);
           });
         }
       });

-
-      $(".colour-preview-box").each(function () {
-        $(this).css("background-color", $(this).data("colour"));
-      });

     }
 
     page.unload = function () {
     }
 
     page.unload = function () {


@@ -360,7 +326,17 @@ $(document).ready(function () {
     return page;
   };
 
     return page;
   };
 

-  var history = OSM.History(map);
+  OSM.OldBrowse = function () {
+    const page = {};
+
+    page.pushstate = page.popstate = function (path) {
+      OSM.loadSidebarContent(path);
+    };
+
+    return page;
+  };
+
+  const history = OSM.History(map);

 
   OSM.router = OSM.Router(map, {
     "/": OSM.Index(map),
 
   OSM.router = OSM.Router(map, {
     "/": OSM.Index(map),


@@ -374,10 +350,14 @@ $(document).ready(function () {
     "/user/:display_name/history": history,
     "/note/:id": OSM.Note(map),
     "/node/:id(/history)": OSM.Browse(map, "node"),
     "/user/:display_name/history": history,
     "/note/:id": OSM.Note(map),
     "/node/:id(/history)": OSM.Browse(map, "node"),

+    "/node/:id/history/:version": OSM.OldBrowse(),

     "/way/:id(/history)": OSM.Browse(map, "way"),
     "/way/:id(/history)": OSM.Browse(map, "way"),

+    "/way/:id/history/:version": OSM.OldBrowse(),

     "/relation/:id(/history)": OSM.Browse(map, "relation"),
     "/relation/:id(/history)": OSM.Browse(map, "relation"),

+    "/relation/:id/history/:version": OSM.OldBrowse(),

     "/changeset/:id": OSM.Changeset(map),
     "/changeset/:id": OSM.Changeset(map),

-    "/query": OSM.Query(map)
+    "/query": OSM.Query(map),
+    "/account/home": OSM.Home(map)

   });
 
   if (OSM.preferred_editor === "remote" && document.location.pathname === "/edit") {
   });
 
   if (OSM.preferred_editor === "remote" && document.location.pathname === "/edit") {


@@ -388,7 +368,7 @@ $(document).ready(function () {
   OSM.router.load();
 
   $(document).on("click", "a", function (e) {
   OSM.router.load();
 
   $(document).on("click", "a", function (e) {

-    if (e.isDefaultPrevented() || e.isPropagationStopped()) {
+    if (e.isDefaultPrevented() || e.isPropagationStopped() || $(e.target).data("turbo")) {

       return;
     }
 
       return;
     }
 


@@ -404,6 +384,13 @@ $(document).ready(function () {
 
     if (OSM.router.route(this.pathname + this.search + this.hash)) {
       e.preventDefault();
 
     if (OSM.router.route(this.pathname + this.search + this.hash)) {
       e.preventDefault();

+      if (this.pathname !== "/directions") {
+        $("header").addClass("closed");
+      }

     }
   });
     }
   });

+
+  $(document).on("click", "#sidebar_content .btn-close", function () {
+    OSM.router.route("/" + OSM.formatHash(map));
+  });

 });
 });