nil protection - mysql however has a default for enums, which is why it wasn't a...

[rails.git] / app / models / node.rb

diff --git a/app/models/node.rb b/app/models/node.rb
index 39e1228acf80c8dd41f6d2c4be520c80be736637..faba4ed66d5e37817fc4821c4947d76aecbc03cc 100644 (file)
--- a/app/models/node.rb
+++ b/app/models/node.rb
@@ -2,6 +2,7 @@ class Node < ActiveRecord::Base
   require 'xml/libxml'
 
   include GeoRecord
   require 'xml/libxml'
 
   include GeoRecord

+  include ConsistencyValidations

 
   set_table_name 'current_nodes'
 
 
   set_table_name 'current_nodes'
 


@@ -52,7 +53,7 @@ class Node < ActiveRecord::Base
     #conditions = keys.join(' AND ')
  
     find_by_area(min_lat, min_lon, max_lat, max_lon,
     #conditions = keys.join(' AND ')
  
     find_by_area(min_lat, min_lon, max_lat, max_lon,

-                    :conditions => 'visible = 1',
+                    :conditions => {:visible => true},

                     :limit => APP_CONFIG['max_number_of_nodes']+1)  
   end
 
                     :limit => APP_CONFIG['max_number_of_nodes']+1)  
   end
 


@@ -74,20 +75,25 @@ class Node < ActiveRecord::Base
   def self.from_xml_node(pt, create=false)
     node = Node.new
     
   def self.from_xml_node(pt, create=false)
     node = Node.new
     

-    node.version = pt['version']

     node.lat = pt['lat'].to_f
     node.lon = pt['lon'].to_f
     node.changeset_id = pt['changeset'].to_i
 
     return nil unless node.in_world?
 
     node.lat = pt['lat'].to_f
     node.lon = pt['lon'].to_f
     node.changeset_id = pt['changeset'].to_i
 
     return nil unless node.in_world?
 

+    # version must be present unless creating
+    return nil unless create or not pt['version'].nil?
+    node.version = create ? 0 : pt['version'].to_i
+

     unless create
       if pt['id'] != '0'
         node.id = pt['id'].to_i
       end
     end
 
     unless create
       if pt['id'] != '0'
         node.id = pt['id'].to_i
       end
     end
 

-    node.visible = pt['visible'] and pt['visible'] == 'true'
+    # visible if it says it is, or as the default if the attribute
+    # is missing.
+    node.visible = pt['visible'].nil? or pt['visible'] == 'true'

 
     if create
       node.timestamp = Time.now
 
     if create
       node.timestamp = Time.now


@@ -106,6 +112,12 @@ class Node < ActiveRecord::Base
     return node
   end
 
     return node
   end
 

+  ##
+  # the bounding box around a node
+  def bbox
+    [ longitude, latitude, longitude, latitude ]
+  end
+

   def save_with_history!
     t = Time.now
     Node.transaction do
   def save_with_history!
     t = Time.now
     Node.transaction do


@@ -128,20 +140,27 @@ class Node < ActiveRecord::Base
       old_node = OldNode.from_node(self)
       old_node.timestamp = t
       old_node.save_with_dependencies!
       old_node = OldNode.from_node(self)
       old_node.timestamp = t
       old_node.save_with_dependencies!

+
+      # save the changeset in case of bounding box updates
+      changeset.save!

     end
   end
 
   # Should probably be renamed delete_from to come in line with update
     end
   end
 
   # Should probably be renamed delete_from to come in line with update

-  def delete_with_history(new_node, user)
+  def delete_with_history!(new_node, user)

     if self.visible
       check_consistency(self, new_node, user)
     if self.visible
       check_consistency(self, new_node, user)

-      if WayNode.find(:first, :joins => "INNER JOIN current_ways ON current_ways.id = current_way_nodes.id", :conditions => [ "current_ways.visible = 1 AND current_way_nodes.node_id = ?", self.id ])
+      if WayNode.find(:first, :joins => "INNER JOIN current_ways ON current_ways.id = current_way_nodes.id", :conditions => [ "current_ways.visible = ? AND current_way_nodes.node_id = ?", true, self.id ])

         raise OSM::APIPreconditionFailedError.new
         raise OSM::APIPreconditionFailedError.new

-      elsif RelationMember.find(:first, :joins => "INNER JOIN current_relations ON current_relations.id=current_relation_members.id", :conditions => [ "visible = 1 AND member_type='node' and member_id=?", self.id])
+      elsif RelationMember.find(:first, :joins => "INNER JOIN current_relations ON current_relations.id=current_relation_members.id", :conditions => [ "visible = ? AND member_type='node' and member_id=? ", true, self.id])

         raise OSM::APIPreconditionFailedError.new
       else
         self.changeset_id = new_node.changeset_id
         raise OSM::APIPreconditionFailedError.new
       else
         self.changeset_id = new_node.changeset_id

-        self.visible = 0
+        self.visible = false
+
+        # update the changeset with the deleted position
+        changeset.update_bbox!(bbox)
+

         save_with_history!
       end
     else
         save_with_history!
       end
     else


@@ -152,12 +171,30 @@ class Node < ActiveRecord::Base
   def update_from(new_node, user)
     check_consistency(self, new_node, user)
 
   def update_from(new_node, user)
     check_consistency(self, new_node, user)
 

+    # update changeset with *old* position first
+    changeset.update_bbox!(bbox);
+

     # FIXME logic needs to be double checked
     self.changeset_id = new_node.changeset_id
     self.latitude = new_node.latitude 
     self.longitude = new_node.longitude
     self.tags = new_node.tags
     self.visible = true
     # FIXME logic needs to be double checked
     self.changeset_id = new_node.changeset_id
     self.latitude = new_node.latitude 
     self.longitude = new_node.longitude
     self.tags = new_node.tags
     self.visible = true

+
+    # update changeset with *new* position
+    changeset.update_bbox!(bbox);
+
+    save_with_history!
+  end
+  
+  def create_with_history(user)
+    check_create_consistency(self, user)
+    self.version = 0
+    self.visible = true
+
+    # update the changeset to include the new location
+    changeset.update_bbox!(bbox)
+

     save_with_history!
   end
 
     save_with_history!
   end
 


@@ -185,7 +222,10 @@ class Node < ActiveRecord::Base
       user_display_name_cache[self.changeset.user_id] = nil
     end
 
       user_display_name_cache[self.changeset.user_id] = nil
     end
 

-    el1['user'] = user_display_name_cache[self.changeset.user_id] unless user_display_name_cache[self.changeset.user_id].nil?
+    if not user_display_name_cache[self.changeset.user_id].nil?
+      el1['user'] = user_display_name_cache[self.changeset.user_id]
+      el1['uid'] = self.changeset.user_id.to_s
+    end

 
     self.tags.each do |k,v|
       el2 = XML::Node.new('tag')
 
     self.tags.each do |k,v|
       el2 = XML::Node.new('tag')


@@ -219,7 +259,26 @@ class Node < ActiveRecord::Base
 
   def add_tag_key_val(k,v)
     @tags = Hash.new unless @tags
 
   def add_tag_key_val(k,v)
     @tags = Hash.new unless @tags

+
+    # duplicate tags are now forbidden, so we can't allow values
+    # in the hash to be overwritten.
+    raise OSM::APIDuplicateTagsError.new if @tags.include? k
+

     @tags[k] = v
   end
 
     @tags[k] = v
   end
 

+  ##
+  # are the preconditions OK? this is mainly here to keep the duck
+  # typing interface the same between nodes, ways and relations.
+  def preconditions_ok?
+    in_world?
+  end
+
+  ##
+  # dummy method to make the interfaces of node, way and relation
+  # more consistent.
+  def fix_placeholders!(id_map)
+    # nodes don't refer to anything, so there is nothing to do here
+  end
+

 end
 end