Don't show types twice in issue type select

[rails.git] / lib / locale.rb

diff --git a/lib/locale.rb b/lib/locale.rb
index bb09ae327121361f7c782bcb778e28220b70e91d..5931301b5af6bf46f3291aa1b86418226b6b6857 100644 (file)
--- a/lib/locale.rb
+++ b/lib/locale.rb
@@ -3,19 +3,23 @@ class Locale < I18n::Locale::Tag::Rfc4646
     attr_reader :locales
 
     def initialize(tags)
-      super(tags.map { |tag| Locale.tag(tag) })
+      super(tags.map { |tag| Locale.tag(tag) }).compact!
     end
 
     def candidates(preferred)
       preferred.expand & self
     end
 
-    def preferred(preferred)
-      candidates(preferred).first
+    def preferred(preferred, options = { :default => Locale.default })
+      candidates(preferred).first || options[:default]
     end
 
     def expand
-      map(&:candidates).flatten.uniq << Locale.default
+      List.new(reverse.each_with_object([]) do |locale, expanded|
+                 locale.candidates.uniq.reverse_each do |candidate|
+                   expanded << candidate if candidate == locale || expanded.exclude?(candidate)
+                 end
+               end.reverse.uniq)
     end
   end
 
@@ -28,17 +32,23 @@ class Locale < I18n::Locale::Tag::Rfc4646
   end
 
   def self.available
-    @available ||= List.new(I18n.available_locales)
+    @available ||= List.new(I18n.available_locales).reject!(&:invalid?)
+  end
+
+  def invalid?
+    I18n.t("activerecord.models.acl", :locale => self, :fallback => false, :raise => true).nil?
+  rescue I18n::MissingTranslationData
+    true
   end
 
   def candidates
-    [self.class.new(language, script, region, variant),
-     self.class.new(language, script, region),
-     self.class.new(language, script, nil, variant),
-     self.class.new(language, script),
-     self.class.new(language, nil, region, variant),
-     self.class.new(language, nil, region),
-     self.class.new(language, nil, nil, variant),
-     self.class.new(language)]
+    List.new([self.class.new(language, script, region, variant),
+              self.class.new(language, script, region),
+              self.class.new(language, script, nil, variant),
+              self.class.new(language, script),
+              self.class.new(language, nil, region, variant),
+              self.class.new(language, nil, region),
+              self.class.new(language, nil, nil, variant),
+              self.class.new(language)])
   end
 end