Use rails 4.2 defaults for older migrations

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 26a50cb97c26b1d6f17e4a50162df74e316f2cfb..b2cc901b0959f1888f03e33b531ffce6d2d57210 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -13,11 +13,13 @@ Lint/AssignmentInCondition:
     - 'app/controllers/application_controller.rb'
     - 'app/controllers/geocoder_controller.rb'
     - 'app/controllers/notes_controller.rb'
     - 'app/controllers/application_controller.rb'
     - 'app/controllers/geocoder_controller.rb'
     - 'app/controllers/notes_controller.rb'

+    - 'app/controllers/api/traces_controller.rb'

     - 'app/controllers/traces_controller.rb'
     - 'app/controllers/users_controller.rb'
     - 'app/controllers/traces_controller.rb'
     - 'app/controllers/users_controller.rb'

-    - 'app/controllers/user_preferences_controller.rb'
+    - 'app/controllers/api/user_preferences_controller.rb'

     - 'app/helpers/application_helper.rb'
     - 'app/helpers/browse_helper.rb'
     - 'app/helpers/application_helper.rb'
     - 'app/helpers/browse_helper.rb'

+    - 'app/helpers/browse_tags_helper.rb'

     - 'app/models/client_application.rb'
     - 'app/mailers/notifier.rb'
     - 'lib/nominatim.rb'
     - 'app/models/client_application.rb'
     - 'app/mailers/notifier.rb'
     - 'lib/nominatim.rb'


@@ -27,12 +29,12 @@ Lint/AssignmentInCondition:
 # Offense count: 4
 Lint/HandleExceptions:
   Exclude:
 # Offense count: 4
 Lint/HandleExceptions:
   Exclude:

-    - 'app/controllers/amf_controller.rb'
+    - 'app/controllers/api/amf_controller.rb'

     - 'app/controllers/users_controller.rb'
 
 # Offense count: 692
 Metrics/AbcSize:
     - 'app/controllers/users_controller.rb'
 
 # Offense count: 692
 Metrics/AbcSize:

-  Max: 280
+  Max: 283

 
 # Offense count: 40
 # Configuration parameters: CountComments, ExcludedMethods.
 
 # Offense count: 40
 # Configuration parameters: CountComments, ExcludedMethods.


@@ -48,11 +50,11 @@ Metrics/BlockNesting:
 # Offense count: 63
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
 # Offense count: 63
 # Configuration parameters: CountComments.
 Metrics/ClassLength:

-  Max: 1795
+  Max: 1627

 
 # Offense count: 72
 Metrics/CyclomaticComplexity:
 
 # Offense count: 72
 Metrics/CyclomaticComplexity:

-  Max: 20
+  Max: 23

 
 # Offense count: 691
 # Configuration parameters: CountComments.
 
 # Offense count: 691
 # Configuration parameters: CountComments.


@@ -98,6 +100,11 @@ Naming/PredicateName:
     - 'app/models/user.rb'
     - 'lib/classic_pagination/pagination.rb'
 
     - 'app/models/user.rb'
     - 'lib/classic_pagination/pagination.rb'
 

+# Disabled pending merge of fix for:
+# https://github.com/rubocop-hq/rubocop/issues/6943
+Rails/ActiveRecordOverride:
+  Enabled: false
+

 # Offense count: 6
 # Configuration parameters: Database, Include.
 # SupportedDatabases: mysql, postgresql
 # Offense count: 6
 # Configuration parameters: Database, Include.
 # SupportedDatabases: mysql, postgresql


@@ -141,7 +148,7 @@ Rails/OutputSafety:
   Exclude:
     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'
   Exclude:
     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'

-    - 'app/helpers/changeset_helper.rb'
+    - 'app/helpers/changesets_helper.rb'

     - 'app/helpers/geocoder_helper.rb'
     - 'app/helpers/note_helper.rb'
     - 'app/helpers/open_graph_helper.rb'
     - 'app/helpers/geocoder_helper.rb'
     - 'app/helpers/note_helper.rb'
     - 'app/helpers/open_graph_helper.rb'


@@ -177,7 +184,7 @@ Style/FrozenStringLiteralComment:
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Exclude:
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Exclude:

-    - 'app/controllers/way_controller.rb'
+    - 'app/controllers/api/ways_controller.rb'

 
 # Offense count: 70
 # Cop supports --auto-correct.
 
 # Offense count: 70
 # Cop supports --auto-correct.