Move controller tests for new reports into seperate file, and adapt to new form struc...

[rails.git] / test / controllers / issues_controller_test.rb

diff --git a/test/controllers/issues_controller_test.rb b/test/controllers/issues_controller_test.rb
index 325e0c297f2fe6410548f65e741c77c90aad88d0..a77ef86607d9588d49be80a7af76b37b47d86539 100644 (file)
--- a/test/controllers/issues_controller_test.rb
+++ b/test/controllers/issues_controller_test.rb
@@ -1,70 +1,91 @@
-require 'test_helper'
+require "test_helper"

 
 class IssuesControllerTest < ActionController::TestCase
 
 class IssuesControllerTest < ActionController::TestCase

-  test "should get index" do
-    get :index
-    assert_response :success
+  teardown do
+    # cleanup any emails set off by the test
+    ActionMailer::Base.deliveries.clear

   end
 
   end
 

-  def test_new_issue
-    # Test creation of a new issue and a new report
-    get :new, {reportable_id: 1, reportable_type: "IssueOne", user: 1}
-    assert_response :success
-    assert_difference "Issue.count",1 do 
-      details = "Details of a report"
-      post :create, { :report => { :deatils => details},
-                      :issue => { reportable_id: 1, reportable_type: "IssueOne", user: 1} }
-    end
+  def test_view_dashboard_without_auth
+    # Access issues_path without login
+    get :index

     assert_response :redirect
     assert_response :redirect

-  end
+    assert_redirected_to login_path(:referer => issues_path)

 
 

-  def test_new_report
-    # Test creation of a new report for an existing issue
-    get :new, {reportable_id: 1, reportable_type: "IssueOne", user: 1}
-    assert_response :success
-    assert_difference "Issue.count",1 do 
-      details = "Details of a report"
-      post :create, { :report => { :details => details},
-                      :issue => { reportable_id: 1, reportable_type: "IssueOne", user: 1} }
-    end
+    # Access issues_path as normal user
+    session[:user] = create(:user).id
+    get :index

     assert_response :redirect
     assert_response :redirect

-    
-    get :new, {reportable_id: 1, reportable_type: "IssueOne", user: 1}
+    assert_redirected_to root_path
+
+    # Access issues_path by admin
+    session[:user] = create(:administrator_user).id
+    get :index

     assert_response :success
     assert_response :success

-    assert_no_difference "Issue.count" do
-      details = "Details of another report under the same issue"
-      post :create, { :report => { :details => details},
-                      :issue => { reportable_id: 1, reportable_type: "IssueOne", user: 1} }
-    end
-    assert_response :redirect
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1,"IssueOne").reports.count,2
-  end

 
 

-  def test_change_status
-    # Create Issue
-    get :new, {reportable_id: 1, reportable_type: "IssueOne", user: 1}
+    # Access issues_path by moderator
+    session[:user] = create(:moderator_user).id
+    get :index

     assert_response :success
     assert_response :success

-    assert_difference "Issue.count",1 do 
-      details = "Details of a report"
-      post :create, { :report => { :deatils => details},
-                      :issue => { reportable_id: 1, reportable_type: "IssueOne", user: 1} }
-    end
+  end
+
+  def test_change_status_by_normal_user
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user)
+
+    # Login as normal user
+    session[:user] = create(:user).id
+
+    assert_equal Issue.count, 1
+
+    get :resolve, :params => { :id => issue.id }
+

     assert_response :redirect
     assert_response :redirect

+    assert_redirected_to root_path
+  end
+
+  def test_change_status_by_admin
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user)
+
+    # Login as administrator
+    session[:user] = create(:administrator_user).id

 
     # Test 'Resolved'
 
     # Test 'Resolved'

-    get :resolve, id: Issue.find_by_reportable_id_and_reportable_type(1,"IssueOne").id
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1,"IssueOne").resolved?, true
+    get :resolve, :params => { :id => issue.id }
+    assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").resolved?, true

     assert_response :redirect
 
     # Test 'Reopen'
     assert_response :redirect
 
     # Test 'Reopen'

-    get :reopen, id: Issue.find_by_reportable_id_and_reportable_type(1,"IssueOne").id
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1,"IssueOne").open?, true
+    get :reopen, :params => { :id => issue.id }
+    assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").open?, true

     assert_response :redirect
 
     # Test 'Ignored'
     assert_response :redirect
 
     # Test 'Ignored'

-    get :ignore, id: Issue.find_by_reportable_id_and_reportable_type(1,"IssueOne").id
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1,"IssueOne").ignored?, true
+    get :ignore, :params => { :id => issue.id }
+    assert_equal Issue.find_by(:reportable_id => target_user, :reportable_type => "User").ignored?, true

     assert_response :redirect
   end
 
     assert_response :redirect
   end
 

+  def test_search_issues
+    good_user = create(:user)
+    bad_user = create(:user)
+    create(:issue, :reportable => bad_user, :reported_user => bad_user, :issue_type => "administrator")
+    # Login as administrator
+    session[:user] = create(:administrator_user).id
+
+    # No issues against the user
+    get :index, :params => { :search_by_user => good_user.display_name }
+    assert_response :redirect
+    assert_redirected_to issues_path
+
+    # User doesn't exist
+    get :index, :params => { :search_by_user => "test1000" }
+    assert_response :redirect
+    assert_redirected_to issues_path
+
+    # Find Issue against bad_user
+    get :index, :params => { :search_by_user => bad_user.display_name }
+    assert_response :success
+  end

 end
 end