Rework capabilities to avoid assumptions about missing tokens

[rails.git] / test / models / abilities_test.rb

diff --git a/test/models/abilities_test.rb b/test/models/abilities_test.rb
index de9f9ba9bab1fe883eb4196c4c7bb8075c264c5a..2bae4e88cb156aa2df05cdbf2e2c9bca02912fa2 100644 (file)
--- a/test/models/abilities_test.rb
+++ b/test/models/abilities_test.rb
@@ -3,22 +3,21 @@
 require "test_helper"
 
 class AbilityTest < ActiveSupport::TestCase
 require "test_helper"
 
 class AbilityTest < ActiveSupport::TestCase

-
-  def tokens(*toks)
-    AccessToken.new do |token|
-      toks.each do |t|
-        token.public_send("#{t}=", true)
-      end
-    end
-  end
-

 end
 
 class GuestAbilityTest < AbilityTest
 end
 
 class GuestAbilityTest < AbilityTest

+  test "geocoder permission for a guest" do
+    ability = Ability.new nil
+
+    [:search, :search_latlon, :search_ca_postcode, :search_osm_nominatim,
+     :search_geonames, :search_osm_nominatim_reverse, :search_geonames_reverse].each do |action|
+      assert ability.can?(action, :geocoder), "should be able to #{action} geocoder"
+    end
+  end

 
   test "diary permissions for a guest" do
 
   test "diary permissions for a guest" do

-    ability = Ability.new nil, tokens
-    [:list, :rss, :view, :comments].each do |action|
+    ability = Ability.new nil
+    [:index, :rss, :show, :comments].each do |action|

       assert ability.can?(action, DiaryEntry), "should be able to #{action} DiaryEntries"
     end
 
       assert ability.can?(action, DiaryEntry), "should be able to #{action} DiaryEntries"
     end
 


@@ -27,15 +26,13 @@ class GuestAbilityTest < AbilityTest
       assert ability.cannot?(action, DiaryComment), "should be able to #{action} DiaryEntries"
     end
   end
       assert ability.cannot?(action, DiaryComment), "should be able to #{action} DiaryEntries"
     end
   end

-

 end
 
 class UserAbilityTest < AbilityTest
 end
 
 class UserAbilityTest < AbilityTest

-

   test "Diary permissions" do
   test "Diary permissions" do

-    ability = Ability.new create(:user), tokens
+    ability = Ability.new create(:user)

 
 

-    [:list, :rss, :view, :comments, :create, :edit, :comment, :subscribe, :unsubscribe].each do |action|
+    [:index, :rss, :show, :comments, :create, :edit, :comment, :subscribe, :unsubscribe].each do |action|

       assert ability.can?(action, DiaryEntry), "should be able to #{action} DiaryEntries"
     end
 
       assert ability.can?(action, DiaryEntry), "should be able to #{action} DiaryEntries"
     end
 


@@ -44,49 +41,12 @@ class UserAbilityTest < AbilityTest
       assert ability.cannot?(action, DiaryComment), "should be able to #{action} DiaryEntries"
     end
   end
       assert ability.cannot?(action, DiaryComment), "should be able to #{action} DiaryEntries"
     end
   end

-
-  test "user preferences" do
-    user = create(:user)
-
-    # a user with no tokens
-    ability = Ability.new create(:user), nil
-    [:read, :read_one, :update, :update_one, :delete_one].each do |act|
-      assert ability.can? act, UserPreference
-    end
-
-    # A user with empty tokens
-    ability = Ability.new create(:user), tokens
-
-    [:read, :read_one, :update, :update_one, :delete_one].each do |act|
-      assert ability.cannot? act, UserPreference
-    end
-
-    ability = Ability.new user, tokens(:allow_read_prefs)
-
-    [:update, :update_one, :delete_one].each do |act|
-      assert ability.cannot? act, UserPreference
-    end
-
-    [:read, :read_one].each do |act|
-      assert ability.can? act, UserPreference
-    end
-
-    ability = Ability.new user, tokens(:allow_write_prefs)
-    [:read, :read_one].each do |act|
-      assert ability.cannot? act, UserPreference
-    end
-
-    [:update, :update_one, :delete_one].each do |act|
-      assert ability.can? act, UserPreference
-    end
-  end

 end
 
 class AdministratorAbilityTest < AbilityTest
 end
 
 class AdministratorAbilityTest < AbilityTest

-

   test "Diary for an administrator" do
   test "Diary for an administrator" do

-    ability = Ability.new create(:administrator_user), tokens
-    [:list, :rss, :view, :comments, :create, :edit, :comment, :subscribe, :unsubscribe, :hide, :hidecomment].each do |action|
+    ability = Ability.new create(:administrator_user)
+    [:index, :rss, :show, :comments, :create, :edit, :comment, :subscribe, :unsubscribe, :hide, :hidecomment].each do |action|

       assert ability.can?(action, DiaryEntry), "should be able to #{action} DiaryEntries"
     end
 
       assert ability.can?(action, DiaryEntry), "should be able to #{action} DiaryEntries"
     end
 


@@ -94,14 +54,4 @@ class AdministratorAbilityTest < AbilityTest
       assert ability.can?(action, DiaryComment), "should be able to #{action} DiaryComment"
     end
   end
       assert ability.can?(action, DiaryComment), "should be able to #{action} DiaryComment"
     end
   end

-
-  test "administrator does not auto-grant user preferences" do
-    ability = Ability.new create(:administrator_user), tokens
-
-    [:read, :read_one, :update, :update_one, :delete_one].each do |act|
-      assert ability.cannot? act, UserPreference
-    end
-  end
-
-

 end
 end