Merge remote-tracking branch 'openstreetmap/pull/1423'

[rails.git] / test / models / changeset_comment_test.rb

diff --git a/test/models/changeset_comment_test.rb b/test/models/changeset_comment_test.rb
index c13fde8e28e31734c7ae755deba6388e46b88d4c..64fbb36637e253fec6ea954ef009c5a114f0d86b 100644 (file)
--- a/test/models/changeset_comment_test.rb
+++ b/test/models/changeset_comment_test.rb
@@ -1,16 +1,13 @@
-require 'test_helper'
+# -*- coding: utf-8 -*-
+require "test_helper"
 
 class ChangesetCommentTest < ActiveSupport::TestCase
-  fixtures :changesets, :changeset_comments
-
-  def test_changeset_comment_count
-    assert_equal 4, ChangesetComment.count
-  end
+  fixtures :changesets, :users
 
   # validations
   def test_does_not_accept_invalid_author
-    comment = changeset_comments(:normal_comment_1)
-    
+    comment = create(:changeset_comment)
+
     comment.author = nil
     assert !comment.valid?
 
@@ -19,7 +16,7 @@ class ChangesetCommentTest < ActiveSupport::TestCase
   end
 
   def test_does_not_accept_invalid_changeset
-    comment = changeset_comments(:normal_comment_1)
+    comment = create(:changeset_comment)
 
     comment.changeset = nil
     assert !comment.valid?
@@ -29,13 +26,33 @@ class ChangesetCommentTest < ActiveSupport::TestCase
   end
 
   def test_does_not_accept_empty_visible
-    comment = changeset_comments(:normal_comment_1)
+    comment = create(:changeset_comment)
 
     comment.visible = nil
     assert !comment.valid?
   end
 
   def test_comments_of_changeset_count
+    create_list(:changeset_comment, 3, :changeset_id => changesets(:normal_user_closed_change).id)
     assert_equal 3, Changeset.find(changesets(:normal_user_closed_change).id).comments.count
   end
+
+  def test_body_valid
+    ok = %W(Name vergrößern foo\nbar
+            ルシステムにも対応します 輕觸搖晃的遊戲)
+    bad = ["foo\x00bar", "foo\x08bar", "foo\x1fbar", "foo\x7fbar",
+           "foo\ufffebar", "foo\uffffbar"]
+
+    ok.each do |body|
+      changeset_comment = create(:changeset_comment)
+      changeset_comment.body = body
+      assert changeset_comment.valid?, "#{body} is invalid, when it should be"
+    end
+
+    bad.each do |body|
+      changeset_comment = create(:changeset_comment)
+      changeset_comment.body = body
+      assert !changeset_comment.valid?, "#{body} is valid when it shouldn't be"
+    end
+  end
 end