Merge remote-tracking branch 'upstream/pull/5288'

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index adc5d8fc85f79546bfdd350f30ed17ec64a9e48d..7384a8d95fee5c43c197b7abebd7767f95779702 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # This configuration was generated by
 # `rubocop --auto-gen-config`

-# on 2022-11-01 18:20:38 UTC using RuboCop version 1.38.0.
+# on 2024-08-27 18:01:13 UTC using RuboCop version 1.65.1.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new


@@ -14,23 +14,36 @@ require:
   - rubocop-rails
   - rubocop-rake
 
   - rubocop-rails
   - rubocop-rake
 

-# Offense count: 555
+# Offense count: 13
+# Configuration parameters: Include, MaxAmount.
+# Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb
+FactoryBot/ExcessiveCreateList:
+  Exclude:
+    - 'test/controllers/api/changeset_comments_controller_test.rb'
+    - 'test/controllers/api/messages_controller_test.rb'
+    - 'test/controllers/changesets_controller_test.rb'
+    - 'test/controllers/diary_entries_controller_test.rb'
+    - 'test/controllers/notes_controller_test.rb'
+    - 'test/controllers/traces_controller_test.rb'
+    - 'test/controllers/user_blocks_controller_test.rb'
+    - 'test/system/users_test.rb'
+
+# Offense count: 635

 # This cop supports safe autocorrection (--autocorrect).
 # This cop supports safe autocorrection (--autocorrect).

-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.

 # URISchemes: http, https
 Layout/LineLength:
 # URISchemes: http, https
 Layout/LineLength:

-  Max: 248
+  Max: 234

 
 

-# Offense count: 29
+# Offense count: 23
+# This cop supports unsafe autocorrection (--autocorrect-all).

 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
     - 'app/controllers/accounts_controller.rb'
     - 'app/controllers/api/traces_controller.rb'
     - 'app/controllers/api/user_preferences_controller.rb'
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
     - 'app/controllers/accounts_controller.rb'
     - 'app/controllers/api/traces_controller.rb'
     - 'app/controllers/api/user_preferences_controller.rb'

-    - 'app/controllers/application_controller.rb'

     - 'app/controllers/geocoder_controller.rb'
     - 'app/controllers/geocoder_controller.rb'

-    - 'app/controllers/notes_controller.rb'

     - 'app/controllers/traces_controller.rb'
     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'
     - 'app/controllers/traces_controller.rb'
     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'


@@ -41,34 +54,34 @@ Lint/AssignmentInCondition:
     - 'lib/osm.rb'
     - 'script/deliver-message'
 
     - 'lib/osm.rb'
     - 'script/deliver-message'
 

-# Offense count: 676
-# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes.
+# Offense count: 762
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.

 Metrics/AbcSize:
   Max: 189
 
 Metrics/AbcSize:
   Max: 189
 

-# Offense count: 73
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Offense count: 37
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.

 # AllowedMethods: refine
 Metrics/BlockLength:
   Max: 71
 
 # AllowedMethods: refine
 Metrics/BlockLength:
   Max: 71
 

-# Offense count: 15
-# Configuration parameters: CountBlocks.
+# Offense count: 8
+# Configuration parameters: CountBlocks, CountModifierForms.

 Metrics/BlockNesting:
   Max: 5
 
 Metrics/BlockNesting:
   Max: 5
 

-# Offense count: 25
+# Offense count: 26

 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:

-  Max: 316
+  Max: 309

 
 # Offense count: 58
 
 # Offense count: 58

-# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Configuration parameters: AllowedMethods, AllowedPatterns.

 Metrics/CyclomaticComplexity:
   Max: 25
 
 Metrics/CyclomaticComplexity:
   Max: 25
 

-# Offense count: 751
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Offense count: 844
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.

 Metrics/MethodLength:
   Max: 179
 
 Metrics/MethodLength:
   Max: 179
 


@@ -77,72 +90,34 @@ Metrics/MethodLength:
 Metrics/ParameterLists:
   Max: 6
 
 Metrics/ParameterLists:
   Max: 6
 

-# Offense count: 57
-# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Offense count: 58
+# Configuration parameters: AllowedMethods, AllowedPatterns.

 Metrics/PerceivedComplexity:
   Max: 26
 
 Metrics/PerceivedComplexity:
   Max: 26
 

-# Offense count: 2495
+# Offense count: 2784

 # This cop supports safe autocorrection (--autocorrect).
 Minitest/EmptyLineBeforeAssertionMethods:
   Enabled: false
 
 # This cop supports safe autocorrection (--autocorrect).
 Minitest/EmptyLineBeforeAssertionMethods:
   Enabled: false
 

-# Offense count: 560
+# Offense count: 695

 Minitest/MultipleAssertions:
 Minitest/MultipleAssertions:

-  Max: 52
-
-# Offense count: 1
-# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
-# NamePrefix: is_, has_, have_
-# ForbiddenPrefixes: is_, has_, have_
-# AllowedMethods: is_a?
-# MethodDefinitionMacros: define_method, define_singleton_method
-Naming/PredicateName:
-  Exclude:
-    - 'app/models/user.rb'
+  Max: 60

 
 

-# Offense count: 8
+# Offense count: 10

 # This cop supports unsafe autocorrection (--autocorrect-all).
 Rails/ActionControllerFlashBeforeRender:
   Exclude:
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Rails/ActionControllerFlashBeforeRender:
   Exclude:

+    - 'app/controllers/application_controller.rb'

     - 'app/controllers/confirmations_controller.rb'
     - 'app/controllers/friendships_controller.rb'
     - 'app/controllers/confirmations_controller.rb'
     - 'app/controllers/friendships_controller.rb'

-    - 'app/controllers/oauth_controller.rb'
-    - 'app/controllers/traces_controller.rb'
-    - 'app/controllers/user_blocks_controller.rb'
-    - 'app/controllers/users_controller.rb'
-
-# Offense count: 18
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: ExpectedOrder, Include.
-# ExpectedOrder: index, show, new, edit, create, update, destroy
-# Include: app/controllers/**/*.rb
-Rails/ActionOrder:
-  Exclude:
-    - 'app/controllers/api/changesets_controller.rb'
-    - 'app/controllers/api/nodes_controller.rb'
-    - 'app/controllers/api/notes_controller.rb'
-    - 'app/controllers/api/relations_controller.rb'
-    - 'app/controllers/api/traces_controller.rb'
-    - 'app/controllers/api/users_controller.rb'
-    - 'app/controllers/api/ways_controller.rb'
-    - 'app/controllers/diary_entries_controller.rb'
+    - 'app/controllers/issue_comments_controller.rb'

     - 'app/controllers/messages_controller.rb'
     - 'app/controllers/messages_controller.rb'

-    - 'app/controllers/oauth_clients_controller.rb'
-    - 'app/controllers/redactions_controller.rb'
+    - 'app/controllers/passwords_controller.rb'

     - 'app/controllers/traces_controller.rb'
     - 'app/controllers/traces_controller.rb'

+    - 'app/controllers/user_blocks_controller.rb'

     - 'app/controllers/users_controller.rb'
 
     - 'app/controllers/users_controller.rb'
 

-# Offense count: 5
-# Configuration parameters: Database, Include.
-# SupportedDatabases: mysql, postgresql
-# Include: db/migrate/*.rb
-Rails/BulkChangeTable:
-  Exclude:
-    - 'db/migrate/20111116184519_update_oauth.rb'
-    - 'db/migrate/20120208194454_add_domain_to_acl.rb'
-    - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
-

 # Offense count: 2
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 # Offense count: 2
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb


@@ -158,7 +133,7 @@ Rails/HelperInstanceVariable:
   Exclude:
     - 'app/helpers/title_helper.rb'
 
   Exclude:
     - 'app/helpers/title_helper.rb'
 

-# Offense count: 16
+# Offense count: 17

 # Configuration parameters: IgnoreScopes, Include.
 # Include: app/models/**/*.rb
 Rails/InverseOf:
 # Configuration parameters: IgnoreScopes, Include.
 # Include: app/models/**/*.rb
 Rails/InverseOf:


@@ -171,17 +146,17 @@ Rails/InverseOf:
     - 'app/models/note.rb'
     - 'app/models/user.rb'
 
     - 'app/models/note.rb'
     - 'app/models/user.rb'
 

-# Offense count: 2
+# Offense count: 1

 # Configuration parameters: Include.
 # Include: app/controllers/**/*.rb, app/mailers/**/*.rb
 Rails/LexicallyScopedActionFilter:
   Exclude:
     - 'app/controllers/oauth2_applications_controller.rb'
 # Configuration parameters: Include.
 # Include: app/controllers/**/*.rb, app/mailers/**/*.rb
 Rails/LexicallyScopedActionFilter:
   Exclude:
     - 'app/controllers/oauth2_applications_controller.rb'

-    - 'app/controllers/oauth2_authorizations_controller.rb'

 
 # Offense count: 5
 
 # Offense count: 5

-# Configuration parameters: Include.
-# Include: db/migrate/*.rb
+# Configuration parameters: Database, Include.
+# SupportedDatabases: mysql
+# Include: db/**/*.rb

 Rails/NotNullColumn:
   Exclude:
     - 'db/migrate/002_cleanup_osm_db.rb'
 Rails/NotNullColumn:
   Exclude:
     - 'db/migrate/002_cleanup_osm_db.rb'


@@ -190,15 +165,24 @@ Rails/NotNullColumn:
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 

-# Offense count: 9
+# Offense count: 7

 Rails/OutputSafety:
   Exclude:
 Rails/OutputSafety:
   Exclude:

-    - 'app/controllers/sessions_controller.rb'
-    - 'app/controllers/users_controller.rb'

     - 'app/helpers/application_helper.rb'
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 
     - 'app/helpers/application_helper.rb'
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 

+# Offense count: 16
+# Configuration parameters: Include.
+# Include: db/**/*.rb
+Rails/ThreeStateBooleanColumn:
+  Exclude:
+    - 'db/migrate/001_create_osm_db.rb'
+    - 'db/migrate/006_tile_nodes.rb'
+    - 'db/migrate/007_add_relations.rb'
+    - 'db/migrate/054_refactor_map_bug_tables.rb'
+    - 'db/migrate/20140507110937_create_changeset_comments.rb'
+

 # Offense count: 6
 # This cop supports safe autocorrection (--autocorrect).
 Rake/Desc:
 # Offense count: 6
 # This cop supports safe autocorrection (--autocorrect).
 Rake/Desc:


@@ -208,14 +192,14 @@ Rake/Desc:
     - 'lib/tasks/subscribe_diary_authors.rake'
     - 'lib/tasks/subscribe_old_changesets.rake'
 
     - 'lib/tasks/subscribe_diary_authors.rake'
     - 'lib/tasks/subscribe_old_changesets.rake'
 

-# Offense count: 625
+# Offense count: 712

 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 

-# Offense count: 72
+# Offense count: 78

 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Strict, AllowedNumbers, AllowedPatterns.
 Style/NumericLiterals:
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Strict, AllowedNumbers, AllowedPatterns.
 Style/NumericLiterals: