Move mechanics of changeset subscriptions into the model

[rails.git] / app / views / browse / changeset.html.erb

diff --git a/app/views/browse/changeset.html.erb b/app/views/browse/changeset.html.erb
index 05e3d4391254d8630139352cee9640bca3fc869e..ee8eee66e710fdd045a23ca562ed095324e31e59 100644 (file)
--- a/app/views/browse/changeset.html.erb
+++ b/app/views/browse/changeset.html.erb
@@ -1,71 +1,144 @@
-<% content_for :head do %>
-  <%= stylesheet_link_tag 'browse' %>
-<% end %>
+<% set_title(t(".title", :id => @changeset.id)) %>

 
 

-<% content_for :sidebar do %>
-  <h2><%= t 'browse.changeset.changeset', :id => @changeset.id %></h2>
+<%= render "sidebar_header", :title => t(".title", :id => @changeset.id) %>

 
 

-  <div class='browse-section common'>
-    <div class='browse-field'>
-      <h4><%= t 'browse.changeset_details.created_at' %></h4>
-      <p><%= l @changeset.created_at %></p>
-    </div>
+<div class="browse-section">
+  <p class="fst-italic">
+    <%= linkify(@changeset.tags["comment"].to_s.presence || t("browse.no_comment")) %>
+  </p>
+  <p class="details"><%= changeset_details(@changeset) %></p>
+
+  <%= render :partial => "tag_details", :object => @changeset.tags.except("comment") %>

 
 

-    <div class='browse-field'>
-      <h4><%= t 'browse.changeset_details.closed_at' %></h4>
-      <p><%= l @changeset.closed_at %></p>
+  <div class="row">
+    <div class="col">
+      <h4><%= t(".discussion") %></h4>

     </div>
 
     </div>
 

-    <% if @changeset.user.data_public? %>
-      <div class='browse-field'>
-        <h4><%= t 'browse.changeset_details.belongs_to' %></h4>
-        <p><%= link_to h(@changeset.user.display_name), :controller => "user", :action => "view", :display_name => @changeset.user.display_name %></p>
+    <% if current_user %>
+      <div class="col-auto">
+        <% if @changeset.subscribers.exists?(current_user.id) %>
+          <button class="btn btn-sm btn-primary" name="unsubscribe" data-method="POST" data-url="<%= api_changeset_unsubscribe_url(@changeset) %>"><%= t("javascripts.changesets.show.unsubscribe") %></button>
+        <% else %>
+          <button class="btn btn-sm btn-primary" name="subscribe" data-method="POST" data-url="<%= api_changeset_subscribe_url(@changeset) %>"><%= t("javascripts.changesets.show.subscribe") %></button>
+        <% end %>

       </div>
     <% end %>
   </div>
 
       </div>
     <% end %>
   </div>
 

-  <%= render :partial => "tag_details", :object => @changeset %>
+  <% if @comments.length > 0 %>
+    <ul class="list-unstyled">
+      <% @comments.each do |comment| %>
+        <% next unless comment.visible || current_user&.moderator? %>
+        <li id="c<%= comment.id %>">
+          <small class='text-muted'>
+            <%= t comment.visible ? ".comment_by_html" : ".hidden_comment_by_html",
+                  :time_ago => friendly_date_ago(comment.created_at),
+                  :user => link_to(comment.author.display_name, user_path(comment.author)) %>
+            <% if current_user&.moderator? %>
+              —
+              <%= tag.button t("javascripts.changesets.show.#{comment.visible ? 'hide' : 'unhide'}_comment"),
+                             :class => "btn btn-sm small btn-link link-secondary p-0 align-baseline",
+                             :data => { :method => "POST",
+                                        :url => comment.visible ? changeset_comment_hide_url(comment) : changeset_comment_unhide_url(comment) } %>
+            <% end %>
+          </small>
+          <div class="mx-2">
+            <%= comment.body.to_html %>
+          </div>
+        </li>
+      <% end %>
+    </ul>
+  <% end %>

 
 

-  <% unless @nodes.empty? %>
-    <div class='browse-section clearfix'>
-      <h4><%= t 'browse.changeset_details.has_nodes', :count => @node_pages.item_count %></h4>
-      <ul>
-        <% @nodes.each do |node| %>
-          <li><%= link_to h(printable_name(node, true)), { :action => "node", :id => node.node_id.to_s }, :class => link_class('node', node), :title => link_title(node) %></li>
-        <% end %>
-      </ul>
-    </div>
-    <%= render :partial => 'paging_nav', :locals => { :pages => @node_pages, :page_param => "node_page"} %>
+  <% unless current_user %>
+    <p>
+      <%= link_to(t(".join_discussion"), login_path(:referer => request.fullpath)) %>
+    </p>
+  <% end %>
+
+  <% if current_user %>
+    <% unless @changeset.open? %>
+      <form action="#" class="mb-3">
+        <div class="mb-3">
+          <textarea class="form-control" name="text" cols="40" rows="5"></textarea>
+        </div>
+        <div id="comment-error" class="alert alert-danger p-2 mb-3" hidden>
+        </div>
+        <div>
+          <button name="comment" data-method="POST" data-url="<%= changeset_comment_url(@changeset) %>" disabled class="btn btn-sm btn-primary"><%= t("javascripts.changesets.show.comment") %></button>
+        </div>
+      </form>
+    <% else %>
+      <p>
+        <%= t(".still_open") %>
+      </p>
+    <% end %>

   <% end %>
 
   <% unless @ways.empty? %>
   <% end %>
 
   <% unless @ways.empty? %>

-    <div class='browse-section clearfix'>
-      <h4><%= t 'browse.changeset_details.has_ways', :count => @way_pages.item_count %></h4>
-      <ul>
-        <% @ways.each do |way| %>
-          <li><%= link_to h(printable_name(way, true)), { :action => "way", :id => way.way_id.to_s }, :class => link_class('way', way), :title => link_title(way) %></li>
+    <%= render :partial => "paging_nav", :locals => { :heading => type_and_paginated_count("way", @way_pages), :pages => @way_pages, :page_param => "way_page" } %>
+    <ul class="list-unstyled">
+      <% @ways.each do |way| %>
+        <%= element_list_item "way", way do %>
+          <%= t "printable_name.current_and_old_links_html",
+                :current_link => link_to(printable_element_name(way), way_path(way.way_id)),
+                :old_link => link_to(printable_element_version(way), old_way_path(way.way_id, way.version)) %>

         <% end %>
         <% end %>

-      </ul>
-    </div>
-    <%= render :partial => 'paging_nav', :locals => { :pages => @way_pages, :page_param => "way_page" } %>
+      <% end %>
+    </ul>

   <% end %>
 
   <% unless @relations.empty? %>
   <% end %>
 
   <% unless @relations.empty? %>

-    <div class='browse-section clearfix'>
-      <h4><%= t 'browse.changeset_details.has_relations', :count => @relation_pages.item_count %></h4>
-        <ul>
-          <% @relations.each do |relation| %>
-            <li><%= link_to h(printable_name(relation, true)), { :action => "relation", :id => relation.relation_id.to_s }, :class => link_class('relation', relation), :title => link_title(relation) %></li>
-          <% end %>
-        </ul>
-    </div>
-    <%= render :partial => 'paging_nav', :locals => { :pages => @relation_pages, :page_param => "relation_page" } %>
+    <%= render :partial => "paging_nav", :locals => { :heading => type_and_paginated_count("relation", @relation_pages), :pages => @relation_pages, :page_param => "relation_page" } %>
+    <ul class="list-unstyled">
+      <% @relations.each do |relation| %>
+        <%= element_list_item "relation", relation do %>
+          <%= t "printable_name.current_and_old_links_html",
+                :current_link => link_to(printable_element_name(relation), relation_path(relation.relation_id)),
+                :old_link => link_to(printable_element_version(relation), old_relation_path(relation.relation_id, relation.version)) %>
+        <% end %>
+      <% end %>
+    </ul>

   <% end %>
 
   <% end %>
 

-  <ul class='secondary-actions clearfix'>
-    <li><%= link_to(t('browse.changeset.changesetxml'), :controller => "changeset", :action => "read") %></li>
-    <li><%= link_to(t('browse.changeset.osmchangexml'), :controller => "changeset", :action => "download") %></li>
-  </ul>
-<% end %>
+  <% unless @nodes.empty? %>
+    <%= render :partial => "paging_nav", :locals => { :heading => type_and_paginated_count("node", @node_pages), :pages => @node_pages, :page_param => "node_page" } %>
+    <ul class="list-unstyled">
+      <% @nodes.each do |node| %>
+        <%= element_list_item "node", node do %>
+          <%= t "printable_name.current_and_old_links_html",
+                :current_link => link_to(printable_element_name(node), node_path(node.node_id), { :rel => link_follow(node) }),
+                :old_link => link_to(printable_element_version(node), old_node_path(node.node_id, node.version), { :rel => link_follow(node) }) %>
+        <% end %>
+      <% end %>
+    </ul>
+  <% end %>
+</div>

 
 

-<%= render :template => 'layouts/map' %>
+<div class='secondary-actions'>
+  <%= link_to(t(".changesetxml"), :controller => "api/changesets", :action => "show") %>
+  &middot;
+  <%= link_to(t(".osmchangexml"), :controller => "api/changesets", :action => "download") %>
+</div>
+
+<% if @next_by_user || @prev_by_user %>
+  <div class='secondary-actions'>
+    <% if @prev_by_user %>
+      <%= link_to({ :id => @prev_by_user.id }, :class => "icon-link") do %>
+        <%= previous_page_svg_tag :height => 11 %>
+        <%= @prev_by_user.id %>
+      <% end %>
+      &middot;
+    <% end %>
+    <%= user = (@prev_by_user || @next_by_user).user.display_name
+        link_to tag.bdi(user), :controller => "changesets", :action => "index", :display_name => user %>
+    <% if @next_by_user %>
+      &middot;
+      <%= link_to({ :id => @next_by_user.id }, :class => "icon-link") do %>
+        <%= @next_by_user.id %>
+        <%= next_page_svg_tag :height => 11 %>
+      <% end %>
+    <% end %>
+  </div>
+<% end %>