Merge remote-tracking branch 'upstream/pull/5405'

[rails.git] / app / controllers / api / users_controller.rb

diff --git a/app/controllers/api/users_controller.rb b/app/controllers/api/users_controller.rb
index d4baf4a820a0c1dada9c5a4f13342d440f536a0f..e9f42e12b1444787260dad22a18bf5ee97fdb368 100644 (file)
--- a/app/controllers/api/users_controller.rb
+++ b/app/controllers/api/users_controller.rb
@@ -1,17 +1,31 @@
 module Api
   class UsersController < ApiController
 module Api
   class UsersController < ApiController

-    before_action :check_api_readable

     before_action :disable_terms_redirect, :only => [:details]
     before_action :setup_user_auth, :only => [:show, :index]
     before_action :authorize, :only => [:details, :gpx_files]
 
     authorize_resource
 
     before_action :disable_terms_redirect, :only => [:details]
     before_action :setup_user_auth, :only => [:show, :index]
     before_action :authorize, :only => [:details, :gpx_files]
 
     authorize_resource
 

-    around_action :api_call_handle_error
-    before_action :lookup_user_by_id, :only => [:show]
+    load_resource :only => :show

 
     before_action :set_request_formats, :except => [:gpx_files]
 
 
     before_action :set_request_formats, :except => [:gpx_files]
 

+    def index
+      raise OSM::APIBadUserInput, "The parameter users is required, and must be of the form users=id[,id[,id...]]" unless params["users"]
+
+      ids = params["users"].split(",").collect(&:to_i)
+
+      raise OSM::APIBadUserInput, "No users were given to search for" if ids.empty?
+
+      @users = User.visible.where(:id => ids).in_order_of(:id, ids)
+
+      # Render the result
+      respond_to do |format|
+        format.xml
+        format.json
+      end
+    end
+

     def show
       if @user.visible?
         # Render the result
     def show
       if @user.visible?
         # Render the result


@@ -33,22 +47,6 @@ module Api
       end
     end
 
       end
     end
 

-    def index
-      raise OSM::APIBadUserInput, "The parameter users is required, and must be of the form users=id[,id[,id...]]" unless params["users"]
-
-      ids = params["users"].split(",").collect(&:to_i)
-
-      raise OSM::APIBadUserInput, "No users were given to search for" if ids.empty?
-
-      @users = User.visible.find(ids)
-
-      # Render the result
-      respond_to do |format|
-        format.xml
-        format.json
-      end
-    end
-

     def gpx_files
       @traces = current_user.traces.reload
       render :content_type => "application/xml"
     def gpx_files
       @traces = current_user.traces.reload
       render :content_type => "application/xml"


@@ -56,14 +54,6 @@ module Api
 
     private
 
 
     private
 

-    ##
-    # ensure that there is a "user" instance variable
-    def lookup_user_by_id
-      @user = User.find(params[:id])
-    end
-
-    ##
-    #

     def disable_terms_redirect
       # this is necessary otherwise going to the user terms page, when
       # having not agreed already would cause an infinite redirect loop.
     def disable_terms_redirect
       # this is necessary otherwise going to the user terms page, when
       # having not agreed already would cause an infinite redirect loop.