Only show each note once is the user notes view

[rails.git] / app / models / note.rb

diff --git a/app/models/note.rb b/app/models/note.rb
index a2937074c4053d8b4eaaca9a051fb4b67508d0e4..14806be266dfd1114e62ad324a97708aafc8e65b 100644 (file)
--- a/app/models/note.rb
+++ b/app/models/note.rb
@@ -14,14 +14,13 @@ class Note < ActiveRecord::Base
   validates_inclusion_of :status, :in => ["open", "closed", "hidden"]
   validate :validate_position
 
+  attr_accessible :lat, :lon
+
+  after_initialize :set_defaults
+
   # Sanity check the latitude and longitude and add an error if it's broken
   def validate_position
-    errors.add_to_base("Note is not in the world") unless in_world?
-  end
-
-  # Fill in default values for new notes
-  def after_initialize
-    self.status = "open" unless self.attribute_present?(:status)
+    errors.add(:base, "Note is not in the world") unless in_world?
   end
 
   # Close a note
@@ -40,7 +39,7 @@ class Note < ActiveRecord::Base
       resp += (comment_no == 1 ? "" : separator_char)
       resp += comment.body if comment.body
       resp += " [ " 
-      resp += comment.author_name if comment.author_name
+      resp += comment.author.display_name if comment.author
       resp += " " + comment.created_at.to_s + " ]"
       comment_no += 1
     end
@@ -63,13 +62,10 @@ class Note < ActiveRecord::Base
     self.comments.first.author_ip
   end
 
-  # Return the author id, derived from the first comment
-  def author_id
-    self.comments.first.author_id
-  end
+private
 
-  # Return the author name, derived from the first comment
-  def author_name
-    self.comments.first.author_name
+  # Fill in default values for new notes
+  def set_defaults
+    self.status = "open" unless self.attribute_present?(:status)
   end
 end