Merge pull request #5314 from AntonKhorev/note-subscriptions-api

[rails.git] / app / controllers / api / changeset_comments_controller.rb

diff --git a/app/controllers/api/changeset_comments_controller.rb b/app/controllers/api/changeset_comments_controller.rb
index 8b971834d76432d2728a2d7c0bd059691a9328e4..c180571c58b10b0184e1f3dd98ab86f4fb5d8d27 100644 (file)
--- a/app/controllers/api/changeset_comments_controller.rb
+++ b/app/controllers/api/changeset_comments_controller.rb
@@ -1,15 +1,13 @@
 module Api
   class ChangesetCommentsController < ApiController
     before_action :check_api_writable
 module Api
   class ChangesetCommentsController < ApiController
     before_action :check_api_writable

-    before_action :check_api_readable, :except => [:create]

     before_action :authorize
 
     authorize_resource
 
     before_action :require_public_data, :only => [:create]
     before_action :authorize
 
     authorize_resource
 
     before_action :require_public_data, :only => [:create]

+

     before_action :set_request_formats
     before_action :set_request_formats

-    around_action :api_call_handle_error
-    around_action :api_call_timeout

 
     ##
     # Add a comment to a changeset
 
     ##
     # Add a comment to a changeset


@@ -17,6 +15,7 @@ module Api
       # Check the arguments are sane
       raise OSM::APIBadUserInput, "No id was given" unless params[:id]
       raise OSM::APIBadUserInput, "No text was given" if params[:text].blank?
       # Check the arguments are sane
       raise OSM::APIBadUserInput, "No id was given" unless params[:id]
       raise OSM::APIBadUserInput, "No text was given" if params[:text].blank?

+      raise OSM::APIRateLimitExceeded if rate_limit_exceeded?

 
       # Extract the arguments
       id = params[:id].to_i
 
       # Extract the arguments
       id = params[:id].to_i


@@ -41,7 +40,7 @@ module Api
 
       # Return a copy of the updated changeset
       @changeset = changeset
 
       # Return a copy of the updated changeset
       @changeset = changeset

-      render "api/changesets/changeset"
+      render "api/changesets/show"

 
       respond_to do |format|
         format.xml
 
       respond_to do |format|
         format.xml


@@ -66,7 +65,7 @@ module Api
 
       # Return a copy of the updated changeset
       @changeset = comment.changeset
 
       # Return a copy of the updated changeset
       @changeset = comment.changeset

-      render "api/changesets/changeset"
+      render "api/changesets/show"

 
       respond_to do |format|
         format.xml
 
       respond_to do |format|
         format.xml


@@ -91,12 +90,22 @@ module Api
 
       # Return a copy of the updated changeset
       @changeset = comment.changeset
 
       # Return a copy of the updated changeset
       @changeset = comment.changeset

-      render "api/changesets/changeset"
+      render "api/changesets/show"

 
       respond_to do |format|
         format.xml
         format.json
       end
     end
 
       respond_to do |format|
         format.xml
         format.json
       end
     end

+
+    private
+
+    ##
+    # Check if the current user has exceed the rate limit for comments
+    def rate_limit_exceeded?
+      recent_comments = current_user.changeset_comments.where(:created_at => Time.now.utc - 1.hour..).count
+
+      recent_comments >= current_user.max_changeset_comments_per_hour
+    end

   end
 end
   end
 end