-# -*- coding: utf-8 -*-
require "test_helper"
class UserTest < ActiveSupport::TestCase
include Rails::Dom::Testing::Assertions::SelectorAssertions
- api_fixtures
- fixtures :user_roles
-
def test_invalid_with_empty_attributes
user = User.new
- assert !user.valid?
+ assert_not user.valid?
assert user.errors[:email].any?
assert user.errors[:pass_crypt].any?
assert user.errors[:display_name].any?
assert user.errors[:email].any?
- assert !user.errors[:home_lat].any?
- assert !user.errors[:home_lon].any?
- assert !user.errors[:home_zoom].any?
+ assert user.errors[:home_lat].none?
+ assert user.errors[:home_lon].none?
+ assert user.errors[:home_zoom].none?
end
def test_unique_email
:data_public => 1,
:description => "desc"
)
- assert !new_user.save
+ assert_not new_user.save
assert new_user.errors[:email].include?("has already been taken")
end
:data_public => 1,
:description => "desc"
)
- assert !new_user.save
+ assert_not new_user.save
assert new_user.errors[:display_name].include?("has already been taken")
end
def test_email_valid
- ok = %w(a@s.com test@shaunmcdonald.me.uk hello_local@ping-d.ng
- test_local@openstreetmap.org test-local@example.com)
- bad = %w(hi ht@ n@ @.com help@.me.uk help"hi.me.uk も対@応します
- 輕觸搖晃的遊戲@ah.com も対応します@s.name)
+ ok = %w[a@s.com test@shaunmcdonald.me.uk hello_local@ping-d.ng
+ test_local@openstreetmap.org test-local@example.com]
+ bad = %w[hi ht@ n@ @.com help@.me.uk help"hi.me.uk も対@応します
+ 輕觸搖晃的遊戲@ah.com も対応します@s.name]
ok.each do |name|
user = build(:user)
def test_display_name_length
user = build(:user)
user.display_name = "123"
- assert user.valid?, " should allow nil display name"
+ assert user.valid?, "should allow 3 char name name"
user.display_name = "12"
- assert !user.valid?, "should not allow 2 char name"
+ assert_not user.valid?, "should not allow 2 char name"
user.display_name = ""
- assert !user.valid?
+ assert_not user.valid?, "should not allow blank/0 char name"
user.display_name = nil
- # Don't understand why it isn't allowing a nil value,
- # when the validates statements specifically allow it
- # It appears the database does not allow null values
- assert !user.valid?
+ assert_not user.valid?, "should not allow nil value"
end
def test_display_name_valid
# expact are allowed
# However, would they affect the xml planet dumps?
ok = ["Name", "'me", "he\"", "<hr>", "*ho", "\"help\"@",
- "vergrößern", "ルシステムにも対応します", "輕觸搖晃的遊戲"]
+ "vergrößern", "ルシステムにも対応します", "輕觸搖晃的遊戲", "space space"]
# These need to be 3 chars in length, otherwise the length test above
# should be used.
bad = ["<hr/>", "test@example.com", "s/f", "aa/", "aa;", "aa.",
"aa,", "aa?", "/;.,?", "も対応します/", "#ping",
"foo\x1fbar", "foo\x7fbar", "foo\ufffebar", "foo\uffffbar",
"new", "terms", "save", "confirm", "confirm-email",
- "go_public", "reset-password", "forgot-password", "suspended"]
+ "go_public", "reset-password", "forgot-password", "suspended",
+ "trailing whitespace ", " leading whitespace"]
ok.each do |display_name|
user = build(:user)
user.display_name = display_name
bad.each do |display_name|
user = build(:user)
user.display_name = display_name
- assert !user.valid?, "#{display_name} is valid when it shouldn't be"
+ assert_not user.valid?, "#{display_name} is valid when it shouldn't be"
end
end
- def test_friend_with
- create(:friend, :befriender => users(:normal_user), :befriendee => users(:public_user))
- assert users(:normal_user).is_friends_with?(users(:public_user))
- assert !users(:normal_user).is_friends_with?(users(:inactive_user))
- assert !users(:public_user).is_friends_with?(users(:normal_user))
- assert !users(:public_user).is_friends_with?(users(:inactive_user))
- assert !users(:inactive_user).is_friends_with?(users(:normal_user))
- assert !users(:inactive_user).is_friends_with?(users(:public_user))
+ def test_friends_with
+ alice = create(:user, :active)
+ bob = create(:user, :active)
+ charlie = create(:user, :active)
+ create(:friendship, :befriender => alice, :befriendee => bob)
+
+ assert alice.is_friends_with?(bob)
+ assert_not alice.is_friends_with?(charlie)
+ assert_not bob.is_friends_with?(alice)
+ assert_not bob.is_friends_with?(charlie)
+ assert_not charlie.is_friends_with?(bob)
+ assert_not charlie.is_friends_with?(alice)
end
def test_users_nearby
- # second user has their data public and is close by normal user
- assert_equal [users(:public_user), users(:german_user)], users(:normal_user).nearby
- # second_user has normal user nearby, but normal user has their data private
- assert_equal [users(:german_user)], users(:public_user).nearby
- # inactive_user has no user nearby
- assert_equal [], users(:inactive_user).nearby
- # north_pole_user has no user nearby, and doesn't throw exception
- assert_equal [], users(:north_pole_user).nearby
- # confirmed_user has no home location
- assert_equal [], users(:confirmed_user).nearby
+ alice = create(:user, :active, :home_lat => 51.0, :home_lon => 1.0, :data_public => false)
+ bob = create(:user, :active, :home_lat => 51.1, :home_lon => 1.0, :data_public => true)
+ charlie = create(:user, :active, :home_lat => 51.1, :home_lon => 1.1, :data_public => true)
+ david = create(:user, :active, :home_lat => 10.0, :home_lon => -123.0, :data_public => true)
+ _edward = create(:user, :suspended, :home_lat => 10.0, :home_lon => -123.0, :data_public => true)
+ south_pole_user = create(:user, :active, :home_lat => -90.0, :home_lon => 0.0, :data_public => true)
+ vagrant_user = create(:user, :active, :home_lat => nil, :home_lon => nil, :data_public => true)
+
+ # bob and charlie are both near alice
+ assert_equal [bob, charlie], alice.nearby
+ # charlie and alice are both near bob, but alice has their data private
+ assert_equal [charlie], bob.nearby
+ # david has no user nearby, since edward is not active
+ assert_equal [], david.nearby
+ # south_pole_user has no user nearby, and doesn't throw exception
+ assert_equal [], south_pole_user.nearby
+ # vagrant_user has no home location
+ assert_equal [], vagrant_user.nearby
end
- def test_friends_with
- # normal user is a friend of second user
- # it should be a one way friend associatation
- norm = users(:normal_user)
- sec = users(:public_user)
- create(:friend, :befriender => norm, :befriendee => sec)
- assert_equal 1, Friend.count
- assert_equal [sec], norm.friend_users
- assert_equal 1, norm.friend_users.size
- assert_equal 1, Friend.count
- assert norm.is_friends_with?(sec)
- assert !sec.is_friends_with?(norm)
- assert !users(:normal_user).is_friends_with?(users(:inactive_user))
- assert !users(:public_user).is_friends_with?(users(:normal_user))
- assert !users(:public_user).is_friends_with?(users(:inactive_user))
- assert !users(:inactive_user).is_friends_with?(users(:normal_user))
- assert !users(:inactive_user).is_friends_with?(users(:public_user))
- # Friend.delete(friend)
- # assert_equal 0, Friend.count
+ def test_friends
+ norm = create(:user, :active)
+ sec = create(:user, :active)
+ create(:friendship, :befriender => norm, :befriendee => sec)
+
+ assert_equal [sec], norm.friends
+ assert_equal 1, norm.friends.size
+
+ assert_equal [], sec.friends
+ assert_equal 0, sec.friends.size
end
def test_user_preferred_editor
create(:language, :code => "de")
create(:language, :code => "sl")
- user = users(:normal_user)
+ user = create(:user, :languages => ["en"])
assert_equal ["en"], user.languages
- user.languages = %w(de fr en)
- assert_equal %w(de fr en), user.languages
- user.languages = %w(fr de sl)
+ user.languages = %w[de fr en]
+ assert_equal %w[de fr en], user.languages
+ user.languages = %w[fr de sl]
assert_equal "de", user.preferred_language
- assert_equal %w(fr de sl), user.preferred_languages.map(&:to_s)
- user = users(:public_user)
- assert_equal %w(en de), user.languages
+ assert_equal %w[fr de sl], user.preferred_languages.map(&:to_s)
+ user = create(:user, :languages => %w[en de])
+ assert_equal %w[en de], user.languages
end
def test_visible?
assert user.description.blank?
assert_nil user.home_lat
assert_nil user.home_lon
- assert_equal false, user.image.file?
+ assert_equal false, user.avatar.attached?
assert_equal "deleted", user.status
assert_equal false, user.visible?
assert_equal false, user.active?
projects / rails.git / blobdiff