Add a redirect and error message if user ends up trying to report something without...

[rails.git] / app / controllers / user_roles_controller.rb

diff --git a/app/controllers/user_roles_controller.rb b/app/controllers/user_roles_controller.rb
index 51106866efed9dc65785375027aa3b269353e068..5ef68216bf81e8cc26a53845bf138110edbc1a10 100644 (file)
--- a/app/controllers/user_roles_controller.rb
+++ b/app/controllers/user_roles_controller.rb
@@ -1,65 +1,49 @@
 class UserRolesController < ApplicationController
 class UserRolesController < ApplicationController

-  layout 'site'
+  layout "site"

 
 

-  before_filter :authorize_web
-  before_filter :require_user
-  before_filter :lookup_this_user
-  before_filter :require_administrator
-  before_filter :require_valid_role
-  before_filter :not_in_role, :only => [:grant]
-  before_filter :in_role, :only => [:revoke]
-  around_filter :setup_nonce
+  before_action :authorize_web
+  before_action :require_user
+  before_action :lookup_this_user
+  before_action :require_administrator
+  before_action :require_valid_role
+  before_action :not_in_role, :only => [:grant]
+  before_action :in_role, :only => [:revoke]

 
   def grant
 
   def grant

-    @this_user.roles.create(:role => @role, :granter_id => @user.id)
-    redirect_to :controller => 'user', :action => 'view', :display_name => @this_user.display_name
+    @this_user.roles.create(:role => @role, :granter => current_user)
+    redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name

   end
 
   def revoke
   end
 
   def revoke

-    UserRole.delete_all({:user_id => @this_user.id, :role => @role})
-    redirect_to :controller => 'user', :action => 'view', :display_name => @this_user.display_name
-  end
-
-  private
-  def require_administrator
-    unless @user.administrator?
-      flash[:notice] = t'user_role.filter.not_an_administrator'
-      redirect_to :controller => 'user', :action => 'view', :display_name => @this_user.display_name
+    # checks that administrator role is not revoked from current user
+    if current_user == @this_user && @role == "administrator"
+      flash[:error] = t("user_role.filter.not_revoke_admin_current_user")
+    else
+      UserRole.where(:user_id => @this_user.id, :role => @role).delete_all

     end
     end

+    redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name

   end
 
   end
 

-  ##
-  # ensure that there is a "this_user" instance variable
-  def lookup_this_user
-    @this_user = User.find_by_display_name(params[:display_name])
-  rescue ActiveRecord::RecordNotFound
-    redirect_to :controller => 'user', :action => 'view', :display_name => params[:display_name] unless @this_user
-  end
+  private

 
   ##
 
   ##

-  # the random nonce here which isn't predictable, making an CSRF 
-  # procedure much, much more difficult. setup the nonce. if the given
-  # nonce matches the session nonce then yield into the actual method.
-  # otherwise, just sets up the nonce for the form.
-  def setup_nonce
-    if params[:nonce] and params[:nonce] == session[:nonce]
-      @nonce = params[:nonce]
-      yield
-    else
-      @nonce = OAuth::Helper.generate_nonce
-      session[:nonce] = @nonce
-      render
+  # require that the user is an administrator, or fill out a helpful error message
+  # and return them to theuser page.
+  def require_administrator
+    unless current_user.administrator?
+      flash[:error] = t "user_role.filter.not_an_administrator"
+      redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name

     end
     end

-  end    
+  end

 
   ##
 
   ##

-  # require that the given role is valid. the role is a URL 
+  # require that the given role is valid. the role is a URL

   # parameter, so should always be present.
   def require_valid_role
     @role = params[:role]
     unless UserRole::ALL_ROLES.include?(@role)
   # parameter, so should always be present.
   def require_valid_role
     @role = params[:role]
     unless UserRole::ALL_ROLES.include?(@role)

-      flash[:notice] = t('user_role.filter.not_a_role', :role => @role)
-      redirect_to :controller => 'user', :action => 'view', :display_name => @this_user.display_name
+      flash[:error] = t("user_role.filter.not_a_role", :role => @role)
+      redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name

     end
   end
 
     end
   end
 


@@ -67,17 +51,17 @@ class UserRolesController < ApplicationController
   # checks that the user doesn't already have this role
   def not_in_role
     if @this_user.has_role? @role
   # checks that the user doesn't already have this role
   def not_in_role
     if @this_user.has_role? @role

-      flash[:notice] = t('user_role.filter.already_has_role', :role => @role)
-      redirect_to :controller => 'user', :action => 'view', :display_name => @this_user.display_name
+      flash[:error] = t("user_role.filter.already_has_role", :role => @role)
+      redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name

     end
   end
 
   ##
     end
   end
 
   ##

-  # checks that the user doesn't already have this role
+  # checks that the user already has this role

   def in_role
     unless @this_user.has_role? @role
   def in_role
     unless @this_user.has_role? @role

-      flash[:notice] = t('user_role.filter.doesnt_have_role', :role => @role)
-      redirect_to :controller => 'user', :action => 'view', :display_name => @this_user.display_name
+      flash[:error] = t("user_role.filter.doesnt_have_role", :role => @role)
+      redirect_to :controller => "user", :action => "view", :display_name => @this_user.display_name

     end
   end
 end
     end
   end
 end