Merge pull request #5558 from tomhughes/var-let-const

[rails.git] / app / assets / javascripts / index / history.js

diff --git a/app/assets/javascripts/index/history.js b/app/assets/javascripts/index/history.js
index 75b02ec07066e1b484a2fa0d739e7bd0ad822cb8..c36ae5f185683d58eddf99946e90bab7bd1bcc3c 100644 (file)
--- a/app/assets/javascripts/index/history.js
+++ b/app/assets/javascripts/index/history.js
@@ -1,5 +1,7 @@
-OSM.History = function(map) {
-  var page = {};
+//= require jquery-simulate/jquery.simulate
+
+OSM.History = function (map) {
+  const page = {};

 
   $("#sidebar_content")
     .on("click", ".changeset_more a", loadMore)
 
   $("#sidebar_content")
     .on("click", ".changeset_more a", loadMore)


@@ -8,12 +10,9 @@ OSM.History = function(map) {
     })
     .on("mouseout", "[data-changeset]", function () {
       unHighlightChangeset($(this).data("changeset").id);
     })
     .on("mouseout", "[data-changeset]", function () {
       unHighlightChangeset($(this).data("changeset").id);

-    })
-    .on("click", "[data-changeset]", function () {
-      clickChangeset($(this).data("changeset").id);

     });
 
     });
 

-  var group = L.featureGroup()
+  const group = L.featureGroup()

     .on("mouseover", function (e) {
       highlightChangeset(e.layer.id);
     })
     .on("mouseover", function (e) {
       highlightChangeset(e.layer.id);
     })


@@ -21,102 +20,149 @@ OSM.History = function(map) {
       unHighlightChangeset(e.layer.id);
     })
     .on("click", function (e) {
       unHighlightChangeset(e.layer.id);
     })
     .on("click", function (e) {

-      clickChangeset(e.layer.id);
+      clickChangeset(e.layer.id, e.originalEvent);

     });
 
     });
 

-  group.getLayerId = function(layer) {
+  group.getLayerId = function (layer) {

     return layer.id;
   };
 
   function highlightChangeset(id) {
     return layer.id;
   };
 
   function highlightChangeset(id) {

-    group.getLayer(id).setStyle({fillOpacity: 0.3});
+    const layer = group.getLayer(id);
+    if (layer) layer.setStyle({ fillOpacity: 0.3, color: "#FF6600", weight: 3 });

     $("#changeset_" + id).addClass("selected");
   }
 
   function unHighlightChangeset(id) {
     $("#changeset_" + id).addClass("selected");
   }
 
   function unHighlightChangeset(id) {

-    group.getLayer(id).setStyle({fillOpacity: 0});
+    const layer = group.getLayer(id);
+    if (layer) layer.setStyle({ fillOpacity: 0, color: "#FF9500", weight: 2 });

     $("#changeset_" + id).removeClass("selected");
   }
 
     $("#changeset_" + id).removeClass("selected");
   }
 

-  function clickChangeset(id) {
-    OSM.route($("#changeset_" + id).find(".changeset_id").attr("href"));
+  function clickChangeset(id, e) {
+    $("#changeset_" + id).find("a.changeset_id").simulate("click", e);
+  }
+
+  function displayFirstChangesets(html) {
+    $("#sidebar_content .changesets").html(html);

   }
 
   }
 

-  function loadData() {
-    $.ajax({
-      url: window.location.pathname,
-      method: "GET",
-      data: {bbox: map.getBounds().wrap().toBBoxString()},
-      success: function(html, status, xhr) {
-        $('#sidebar_content .changesets').html(html);
+  function displayMoreChangesets(html) {
+    $("#sidebar_content .changeset_more").replaceWith(html);
+    const oldList = $("#sidebar_content .changesets ol").first();
+    const newList = oldList.next("ol");
+    newList.children().appendTo(oldList);
+    newList.remove();
+  }
+
+  function update() {
+    const data = new URLSearchParams();
+
+    if (window.location.pathname === "/history") {
+      data.set("bbox", map.getBounds().wrap().toBBoxString());
+      const feedLink = $("link[type=\"application/atom+xml\"]"),
+            feedHref = feedLink.attr("href").split("?")[0];
+      feedLink.attr("href", feedHref + "?" + data);
+    }
+
+    data.set("list", "1");
+
+    fetch(window.location.pathname + "?" + data)
+      .then(response => response.text())
+      .then(function (html) {
+        displayFirstChangesets(html);

         updateMap();
         updateMap();

-      }
-    });
+      });

   }
 
   function loadMore(e) {
     e.preventDefault();
     e.stopPropagation();
 
   }
 
   function loadMore(e) {
     e.preventDefault();
     e.stopPropagation();
 

-    var div = $(this).parents(".changeset_more");
+    const div = $(this).parents(".changeset_more");

 
     $(this).hide();
     div.find(".loader").show();
 
 
     $(this).hide();
     div.find(".loader").show();
 

-    $.get($(this).attr("href"), function(data) {
-      div.replaceWith(data);
+    $.get($(this).attr("href"), function (html) {
+      displayMoreChangesets(html);

       updateMap();
     });
   }
 
       updateMap();
     });
   }
 

-  function updateMap() {
+  let changesets = [];
+
+  function updateBounds() {

     group.clearLayers();
 
     group.clearLayers();
 

-    var changesets = [];
+    for (const changeset of changesets) {
+      const bottomLeft = map.project(L.latLng(changeset.bbox.minlat, changeset.bbox.minlon)),
+            topRight = map.project(L.latLng(changeset.bbox.maxlat, changeset.bbox.maxlon)),
+            width = topRight.x - bottomLeft.x,
+            height = bottomLeft.y - topRight.y,
+            minSize = 20; // Min width/height of changeset in pixels

 
 

-    $("[data-changeset]").each(function () {
-      var changeset = $(this).data('changeset');
-      if (changeset.bbox) {
-        changeset.bounds = L.latLngBounds(
-          [changeset.bbox.minlat, changeset.bbox.minlon],
-          [changeset.bbox.maxlat, changeset.bbox.maxlon]);
-        changesets.push(changeset);
+      if (width < minSize) {
+        bottomLeft.x -= ((minSize - width) / 2);
+        topRight.x += ((minSize - width) / 2);

       }
       }

-    });
+
+      if (height < minSize) {
+        bottomLeft.y += ((minSize - height) / 2);
+        topRight.y -= ((minSize - height) / 2);
+      }
+
+      changeset.bounds = L.latLngBounds(map.unproject(bottomLeft),
+                                        map.unproject(topRight));
+    }

 
     changesets.sort(function (a, b) {
       return b.bounds.getSize() - a.bounds.getSize();
     });
 
 
     changesets.sort(function (a, b) {
       return b.bounds.getSize() - a.bounds.getSize();
     });
 

-    for (var i = 0; i < changesets.length; ++i) {
-      var changeset = changesets[i],
-        rect = L.rectangle(changeset.bounds,
-          {weight: 2, color: "#FF9500", opacity: 1, fillColor: "#FFFFBF", fillOpacity: 0});
+    for (const changeset of changesets) {
+      const rect = L.rectangle(changeset.bounds,
+                               { weight: 2, color: "#FF9500", opacity: 1, fillColor: "#FFFFAF", fillOpacity: 0 });

       rect.id = changeset.id;
       rect.addTo(group);
     }
   }
 
       rect.id = changeset.id;
       rect.addTo(group);
     }
   }
 

-  page.pushstate = page.popstate = function(path) {
-    $("#history_tab").addClass("current");
+  function updateMap() {
+    changesets = $("[data-changeset]").map(function (index, element) {
+      return $(element).data("changeset");
+    }).get().filter(function (changeset) {
+      return changeset.bbox;
+    });
+
+    updateBounds();
+
+    if (window.location.pathname !== "/history") {
+      const bounds = group.getBounds();
+      if (bounds.isValid()) map.fitBounds(bounds);
+    }
+  }
+
+  page.pushstate = page.popstate = function (path) {

     OSM.loadSidebarContent(path, page.load);
   };
 
     OSM.loadSidebarContent(path, page.load);
   };
 

-  page.load = function() {
-    map
-      .on("moveend", loadData)
-      .addLayer(group);
+  page.load = function () {
+    map.addLayer(group);

 
 

-    loadData();
-  };
+    if (window.location.pathname === "/history") {
+      map.on("moveend", update);
+    }

 
 

-  page.unload = function() {
-    map
-      .off("moveend", loadData)
-      .removeLayer(group);
+    map.on("zoomend", updateBounds);

 
 

-    group.clearLayers();
-    $("#history_tab").removeClass("current");
+    update();
+  };
+
+  page.unload = function () {
+    map.removeLayer(group);
+    map.off("moveend", update);
+    map.off("zoomend", updateBounds);

   };
 
   return page;
   };
 
   return page;