Refactor generation of object metadata in API calls

[rails.git] / app / models / old_node.rb

diff --git a/app/models/old_node.rb b/app/models/old_node.rb
index 64ae1a70c9d8fe2050f2ccb3283bc04414dae030..0d4fd144f8168bdb6021cc681c31e51eede85519 100644 (file)
--- a/app/models/old_node.rb
+++ b/app/models/old_node.rb
@@ -1,10 +1,15 @@
 class OldNode < ActiveRecord::Base
   include GeoRecord
   include ConsistencyValidations
 class OldNode < ActiveRecord::Base
   include GeoRecord
   include ConsistencyValidations

+  include ObjectMetadata

 
   self.table_name = "nodes"
   self.primary_keys = "node_id", "version"
 
 
   self.table_name = "nodes"
   self.primary_keys = "node_id", "version"
 

+  # note this needs to be included after the table name changes, or
+  # the queries generated by Redactable will use the wrong table name.
+  include Redactable
+

   validates_presence_of :changeset_id, :timestamp
   validates_inclusion_of :visible, :in => [ true, false ]
   validates_numericality_of :latitude, :longitude
   validates_presence_of :changeset_id, :timestamp
   validates_inclusion_of :visible, :in => [ true, false ]
   validates_numericality_of :latitude, :longitude


@@ -12,7 +17,9 @@ class OldNode < ActiveRecord::Base
   validates_associated :changeset
 
   belongs_to :changeset
   validates_associated :changeset
 
   belongs_to :changeset

- 
+  belongs_to :redaction
+  belongs_to :current_node, :class_name => "Node", :foreign_key => "node_id"
+

   def validate_position
     errors.add(:base, "Node is not in the world") unless in_world?
   end
   def validate_position
     errors.add(:base, "Node is not in the world") unless in_world?
   end


@@ -36,15 +43,14 @@ class OldNode < ActiveRecord::Base
     return doc
   end
 
     return doc
   end
 

-  def to_xml_node
+  def to_xml_node(changeset_cache = {}, user_display_name_cache = {})

     el1 = XML::Node.new 'node'
     el1['id'] = self.node_id.to_s
     el1 = XML::Node.new 'node'
     el1['id'] = self.node_id.to_s

-    el1['lat'] = self.lat.to_s
-    el1['lon'] = self.lon.to_s
-    el1['changeset'] = self.changeset.id.to_s
-    if self.changeset.user.data_public?
-      el1['user'] = self.changeset.user.display_name
-      el1['uid'] = self.changeset.user.id.to_s
+    add_metadata_to_xml_node(el1, self, changeset_cache, user_display_name_cache)
+
+    if self.visible?
+      el1['lat'] = self.lat.to_s
+      el1['lon'] = self.lon.to_s

     end
 
     self.tags.each do |k,v|
     end
 
     self.tags.each do |k,v|


@@ -54,9 +60,6 @@ class OldNode < ActiveRecord::Base
       el1 << el2
     end
 
       el1 << el2
     end
 

-    el1['visible'] = self.visible.to_s
-    el1['timestamp'] = self.timestamp.xmlschema
-    el1['version'] = self.version.to_s

     return el1
   end
 
     return el1
   end
 


@@ -106,4 +109,10 @@ class OldNode < ActiveRecord::Base
   def containing_relation_members 
     return [] 
   end 
   def containing_relation_members 
     return [] 
   end 

+
+  # check whether this element is the latest version - that is,
+  # has the same version as its "current" counterpart.
+  def is_latest_version?
+    current_node.version == self.version
+  end

 end
 end