Remove some (hopefully) redundant code

[rails.git] / app / models / old_way.rb

diff --git a/app/models/old_way.rb b/app/models/old_way.rb
index 00642cdb3568eeb834aa2580652484e5e7a188d9..dbdcdd46d62dbaf2f0f591b29681c76d3af4f71a 100644 (file)
--- a/app/models/old_way.rb
+++ b/app/models/old_way.rb
@@ -1,10 +1,17 @@
 class OldWay < ActiveRecord::Base
   include ConsistencyValidations
 class OldWay < ActiveRecord::Base
   include ConsistencyValidations

-  
-  set_table_name 'ways'
-  set_primary_keys :way_id, :version
+  include ObjectMetadata
+
+  self.table_name = "ways"
+  self.primary_keys = "way_id", "version"
+
+  # note this needs to be included after the table name changes, or
+  # the queries generated by Redactable will use the wrong table name.
+  include Redactable

 
   belongs_to :changeset
 
   belongs_to :changeset

+  belongs_to :redaction
+  belongs_to :current_way, :class_name => "Way", :foreign_key => "way_id"

 
   has_many :old_nodes, :class_name => 'OldWayNode', :foreign_key => [:way_id, :version]
   has_many :old_tags, :class_name => 'OldWayTag', :foreign_key => [:way_id, :version]
 
   has_many :old_nodes, :class_name => 'OldWayNode', :foreign_key => [:way_id, :version]
   has_many :old_tags, :class_name => 'OldWayTag', :foreign_key => [:way_id, :version]


@@ -24,19 +31,7 @@ class OldWay < ActiveRecord::Base
   end
 
   def save_with_dependencies!
   end
 
   def save_with_dependencies!

-
-    # dont touch this unless you really have figured out why it's called
-    # (Rails doesn't deal well with the old ways table (called 'ways') because
-    # it doesn't have a unique key. It knows how to insert and auto_increment
-    # id and get it back but we have that and we want to get the 'version' back
-    # we could add another column but thats a lot of data. No, set_primary_key
-    # doesn't work either.

     save!
     save!

-    clear_aggregation_cache
-    clear_association_cache
-    @attributes.update(OldWay.where(:way_id => self.way_id, :timestamp => self.timestamp).order("version DESC").first.instance_variable_get('@attributes'))
-
-    # ok, you can touch from here on

 
     self.tags.each do |k,v|
       tag = OldWayTag.new
 
     self.tags.each do |k,v|
       tag = OldWayTag.new


@@ -58,24 +53,11 @@ class OldWay < ActiveRecord::Base
   end
 
   def nds
   end
 
   def nds

-    unless @nds
-      @nds = Array.new
-      OldWayNode.where(:way_id => self.way_id, :version => self.version).order(:sequence_id).each do |nd|
-        @nds += [nd.node_id]
-      end
-    end
-    @nds
+    @nds ||= self.old_nodes.order(:sequence_id).collect { |n| n.node_id }

   end
 
   def tags
   end
 
   def tags

-    unless @tags
-      @tags = Hash.new
-      OldWayTag.where(:way_id => self.way_id, :version => self.version).each do |tag|
-        @tags[tag.k] = tag.v
-      end
-    end
-    @tags = Hash.new unless @tags
-    @tags
+    @tags ||= Hash[self.old_tags.collect { |t| [t.k, t.v] }]

   end
 
   def nds=(s)
   end
 
   def nds=(s)


@@ -86,31 +68,21 @@ class OldWay < ActiveRecord::Base
     @tags = t
   end
 
     @tags = t
   end
 

-  def to_xml_node
-    el1 = XML::Node.new 'way'
-    el1['id'] = self.way_id.to_s
-    el1['visible'] = self.visible.to_s
-    el1['timestamp'] = self.timestamp.xmlschema
-    if self.changeset.user.data_public?
-      el1['user'] = self.changeset.user.display_name
-      el1['uid'] = self.changeset.user.id.to_s
-    end
-    el1['version'] = self.version.to_s
-    el1['changeset'] = self.changeset.id.to_s
-    
+  def to_xml_node(changeset_cache = {}, user_display_name_cache = {})
+    el = XML::Node.new 'way'
+    el['id'] = self.way_id.to_s
+
+    add_metadata_to_xml_node(el, self, changeset_cache, user_display_name_cache)
+

     self.old_nodes.each do |nd| # FIXME need to make sure they come back in the right order
     self.old_nodes.each do |nd| # FIXME need to make sure they come back in the right order

-      e = XML::Node.new 'nd'
-      e['ref'] = nd.node_id.to_s
-      el1 << e
+      node_el = XML::Node.new 'nd'
+      node_el['ref'] = nd.node_id.to_s
+      el << node_el

     end
     end

- 
-    self.old_tags.each do |tag|
-      e = XML::Node.new 'tag'
-      e['k'] = tag.k
-      e['v'] = tag.v
-      el1 << e
-    end
-    return el1
+      
+    add_tags_to_xml_node(el, self.old_tags)
+
+    return el

   end
 
   # Read full version of old way
   end
 
   # Read full version of old way


@@ -121,18 +93,16 @@ class OldWay < ActiveRecord::Base
   # (i.e. is it visible? are we actually reverting to an earlier version?)
 
   def get_nodes_undelete
   # (i.e. is it visible? are we actually reverting to an earlier version?)
 
   def get_nodes_undelete

-    points = []
-    self.nds.each do |n|
+    self.nds.collect do |n|

       node = Node.find(n)
       node = Node.find(n)

-      points << [node.lon, node.lat, n, node.version, node.tags_as_hash, node.visible]
+      [node.lon, node.lat, n, node.version, node.tags_as_hash, node.visible]

     end
     end

-    points

   end
   
   def get_nodes_revert(timestamp)
     points=[]
     self.nds.each do |n|
   end
   
   def get_nodes_revert(timestamp)
     points=[]
     self.nds.each do |n|

-      oldnode = OldNode.where('node_id = ? AND timestamp <= ?', n, timestamp).order("timestamp DESC").first
+      oldnode = OldNode.where('node_id = ? AND timestamp <= ?', n, timestamp).unredacted.order("timestamp DESC").first

       curnode = Node.find(n)
       id = n; reuse = curnode.visible
       if oldnode.lat != curnode.lat or oldnode.lon != curnode.lon or oldnode.tags != curnode.tags then
       curnode = Node.find(n)
       id = n; reuse = curnode.visible
       if oldnode.lat != curnode.lat or oldnode.lon != curnode.lon or oldnode.tags != curnode.tags then


@@ -158,4 +128,10 @@ class OldWay < ActiveRecord::Base
   def containing_relation_members
     return []
   end
   def containing_relation_members
     return []
   end

+
+  # check whether this element is the latest version - that is,
+  # has the same version as its "current" counterpart.
+  def is_latest_version?
+    current_way.version == self.version
+  end

 end
 end