Fix new rubocop warnings

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 66942d6a47c1c01168ab854b187dea49eb2c2caf..1baaf0ab6f551145ca53cb0a4087b3b15cd25b72 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # This configuration was generated by
 # `rubocop --auto-gen-config`

-# on 2020-08-02 18:37:55 UTC using RuboCop version 0.86.0.
+# on 2020-08-06 17:20:38 UTC using RuboCop version 0.89.0.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new


@@ -39,13 +39,20 @@ Lint/AssignmentInCondition:
     - 'lib/osm.rb'
     - 'script/deliver-message'
 
     - 'lib/osm.rb'
     - 'script/deliver-message'
 

-# Offense count: 739
+# Offense count: 20
+Lint/MissingSuper:
+  Exclude:
+    - 'config/initializers/oauth.rb'
+    - 'lib/osm.rb'
+    - 'lib/session_persistence.rb'
+
+# Offense count: 682

 # Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
 # Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:

-  Max: 189
+  Max: 194

 
 # Offense count: 72
 
 # Offense count: 72

-# Configuration parameters: CountComments, ExcludedMethods.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.

 # ExcludedMethods: refine
 Metrics/BlockLength:
   Max: 71
 # ExcludedMethods: refine
 Metrics/BlockLength:
   Max: 71


@@ -56,17 +63,17 @@ Metrics/BlockNesting:
   Max: 5
 
 # Offense count: 25
   Max: 5
 
 # Offense count: 25

-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.

 Metrics/ClassLength:
   Max: 645
 
 # Offense count: 68
 # Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
 Metrics/ClassLength:
   Max: 645
 
 # Offense count: 68
 # Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:

-  Max: 28
+  Max: 26

 
 # Offense count: 735
 
 # Offense count: 735

-# Configuration parameters: CountComments, ExcludedMethods.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.

 Metrics/MethodLength:
   Max: 179
 
 Metrics/MethodLength:
   Max: 179
 


@@ -75,10 +82,10 @@ Metrics/MethodLength:
 Metrics/ParameterLists:
   Max: 9
 
 Metrics/ParameterLists:
   Max: 9
 

-# Offense count: 73
+# Offense count: 69

 # Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
 # Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:

-  Max: 25
+  Max: 26

 
 # Offense count: 6
 Naming/AccessorMethodName:
 
 # Offense count: 6
 Naming/AccessorMethodName:


@@ -161,6 +168,15 @@ Rails/OutputSafety:
 Rails/TimeZone:
   Enabled: false
 
 Rails/TimeZone:
   Enabled: false
 

+# Offense count: 6
+# Cop supports --auto-correct.
+Style/ExplicitBlockArgument:
+  Exclude:
+    - 'app/controllers/api/amf_controller.rb'
+    - 'app/controllers/application_controller.rb'
+    - 'app/mailers/notifier.rb'
+    - 'test/integration/client_applications_test.rb'
+

 # Offense count: 572
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # Offense count: 572
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.


@@ -173,3 +189,24 @@ Style/FrozenStringLiteralComment:
 # Configuration parameters: Strict.
 Style/NumericLiterals:
   MinDigits: 11
 # Configuration parameters: Strict.
 Style/NumericLiterals:
   MinDigits: 11

+
+# Offense count: 20
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'app/controllers/api/notes_controller.rb'
+    - 'app/controllers/application_controller.rb'
+    - 'app/helpers/browse_helper.rb'
+    - 'app/models/changeset.rb'
+    - 'app/models/node.rb'
+    - 'app/models/relation.rb'
+    - 'app/models/trace.rb'
+    - 'app/models/tracepoint.rb'
+    - 'app/models/way.rb'
+    - 'test/models/diary_entry_test.rb'
+    - 'test/models/trace_test.rb'
+    - 'test/models/tracetag_test.rb'
+
+# Offense count: 44
+# Cop supports --auto-correct.
+Style/StringConcatenation:
+  Enabled: false