Fix rubocop warnings

[rails.git] / lib / short_link.rb

diff --git a/lib/short_link.rb b/lib/short_link.rb
index 045883d57b5c45fb2435aa6e2411ffe1b7d58ce8..43d64041e6b7a765114f36ea4b7e302dd3ac392a 100644 (file)
--- a/lib/short_link.rb
+++ b/lib/short_link.rb
@@ -5,14 +5,13 @@
 # Each character encodes 3 bits of x and 3 of y, so there are extra characters
 # tacked on the end to make the zoom levels "work".
 module ShortLink
 # Each character encodes 3 bits of x and 3 of y, so there are extra characters
 # tacked on the end to make the zoom levels "work".
 module ShortLink

-

   # array of 64 chars to encode 6 bits. this is almost like base64 encoding, but
   # array of 64 chars to encode 6 bits. this is almost like base64 encoding, but

-  # the symbolic chars are different, as base64's + and / aren't very 
+  # the symbolic chars are different, as base64's + and / aren't very

   # URL-friendly.
   # URL-friendly.

-  ARRAY = ('A'..'Z').to_a + ('a'..'z').to_a + ('0'..'9').to_a + ['_','~']
+  ARRAY = ("A".."Z").to_a + ("a".."z").to_a + ("0".."9").to_a + ["_", "~"]

 
   ##
 
   ##

-  # Given a string encoding a location, returns the [lon, lat, z] tuple of that 
+  # Given a string encoding a location, returns the [lon, lat, z] tuple of that

   # location.
   def self.decode(str)
     x = 0
   # location.
   def self.decode(str)
     x = 0


@@ -23,7 +22,7 @@ module ShortLink
     # keep support for old shortlinks which use the @ character, now
     # replaced by the ~ character because twitter is horribly broken
     # and we can't have that.
     # keep support for old shortlinks which use the @ character, now
     # replaced by the ~ character because twitter is horribly broken
     # and we can't have that.

-    str.gsub!("@","~")
+    str.tr!("@", "~")

 
     str.each_char do |c|
       t = ARRAY.index c
 
     str.each_char do |c|
       t = ARRAY.index c


@@ -31,8 +30,13 @@ module ShortLink
         z_offset -= 1
       else
         3.times do
         z_offset -= 1
       else
         3.times do

-          x <<= 1; x = x | 1 unless (t & 32).zero?; t <<= 1
-          y <<= 1; y = y | 1 unless (t & 32).zero?; t <<= 1
+          x <<= 1
+          x |= 1 unless (t & 32).zero?
+          t <<= 1
+
+          y <<= 1
+          y |= 1 unless (t & 32).zero?
+          t <<= 1

         end
         z += 3
       end
         end
         z += 3
       end


@@ -42,20 +46,20 @@ module ShortLink
     y <<= (32 - z)
 
     # project the parameters back to their coordinate ranges.
     y <<= (32 - z)
 
     # project the parameters back to their coordinate ranges.

-    [(x * 360.0 / 2**32) - 180.0, 
-     (y * 180.0 / 2**32) - 90.0, 
+    [(x * 360.0 / 2**32) - 180.0,
+     (y * 180.0 / 2**32) - 90.0,

      z - 8 - (z_offset % 3)]
   end
 
   ##
   # given a location and zoom, return a short string representing it.
   def self.encode(lon, lat, z)
      z - 8 - (z_offset % 3)]
   end
 
   ##
   # given a location and zoom, return a short string representing it.
   def self.encode(lon, lat, z)

-    code = interleave_bits(((lon + 180.0) * 2**32 / 360.0).to_i, 
-                           ((lat +  90.0) * 2**32 / 180.0).to_i)
+    code = interleave_bits(((lon + 180.0) * 2**32 / 360.0).to_i,
+                           ((lat + 90.0) * 2**32 / 180.0).to_i)

     str = ""
     # add eight to the zoom level, which approximates an accuracy of
     # one pixel in a tile.
     str = ""
     # add eight to the zoom level, which approximates an accuracy of
     # one pixel in a tile.

-    ((z + 8)/3.0).ceil.times do |i|
+    ((z + 8) / 3.0).ceil.times do |i|

       digit = (code >> (58 - 6 * i)) & 0x3f
       str << ARRAY[digit]
     end
       digit = (code >> (58 - 6 * i)) & 0x3f
       str << ARRAY[digit]
     end


@@ -63,12 +67,12 @@ module ShortLink
     # partial zoom levels (characters themselves have a granularity
     # of 3 zoom levels).
     ((z + 8) % 3).times { str << "-" }
     # partial zoom levels (characters themselves have a granularity
     # of 3 zoom levels).
     ((z + 8) % 3).times { str << "-" }

-    
-    return str
+
+    str

   end
 
   private
   end
 
   private

-  
+

   ##
   # interleaves the bits of two 32-bit numbers. the result is known
   # as a Morton code.
   ##
   # interleaves the bits of two 32-bit numbers. the result is known
   # as a Morton code.


@@ -80,5 +84,4 @@ module ShortLink
     end
     c
   end
     end
     c
   end

-

 end
 end