Rework the signup and settings methods to make them a bit clearer

[rails.git] / app / controllers / user_preference_controller.rb

diff --git a/app/controllers/user_preference_controller.rb b/app/controllers/user_preference_controller.rb
index b07f4ecc5d0e287051522099a1dfb96a3ce9fac4..d02313497ef61408eb1667852c95abaa4e386366 100644 (file)
--- a/app/controllers/user_preference_controller.rb
+++ b/app/controllers/user_preference_controller.rb
@@ -1,6 +1,8 @@
 # Update and read user preferences, which are arbitrayr key/val pairs
 class UserPreferenceController < ApplicationController
   before_filter :authorize
+  before_filter :require_allow_read_prefs, :only => [:read_one, :read]
+  before_filter :require_allow_write_prefs, :except => [:read_one, :read]
 
   def read_one
     pref = UserPreference.find(@user.id, params[:preference_key])
@@ -52,7 +54,7 @@ class UserPreferenceController < ApplicationController
 
   # update the entire set of preferences
   def update
-    do
+    begin
       p = XML::Parser.string(request.raw_post)
     rescue LibXML::XML::Error, ArgumentError => ex
       raise OSM::APIBadXMLError.new("preferences", xml, ex.message)