api fixes

[rails.git] / app / models / node.rb

diff --git a/app/models/node.rb b/app/models/node.rb
index 0df3689e274b0b13d4a00ad12114eac2c130fe80..6eecc853d12a585577a95e36c3a1e87331bf5fd4 100644 (file)
--- a/app/models/node.rb
+++ b/app/models/node.rb
@@ -61,6 +61,7 @@ class Node < ActiveRecord::Base
   def save_with_history
     begin
       Node.transaction do
   def save_with_history
     begin
       Node.transaction do

+        self.timestamp = Time.now

         self.save
         old_node = OldNode.from_node(self)
         old_node.save
         self.save
         old_node = OldNode.from_node(self)
         old_node.save


@@ -77,12 +78,22 @@ class Node < ActiveRecord::Base
     return doc
   end
 
     return doc
   end
 

-  def to_xml_node
+  def to_xml_node(user_display_name_cache = nil)

     el1 = XML::Node.new 'node'
     el1['id'] = self.id.to_s
     el1['lat'] = self.latitude.to_s
     el1['lon'] = self.longitude.to_s
     el1 = XML::Node.new 'node'
     el1['id'] = self.id.to_s
     el1['lat'] = self.latitude.to_s
     el1['lon'] = self.longitude.to_s

-    el1['user'] = self.user.display_name if self.user.data_public?
+
+    # el['user'] = self.user.display_name if self.user.data_public?
+    user_display_name_cache = {} if user_display_name_cache.nil?
+    if user_display_name_cache and user_display_name_cache[self.user_id]
+      # use the cache if available
+    else
+      user_display_name_cache[self.user_id] = self.user.display_name
+    end
+
+    el1['user'] = user_display_name_cache[self.user_id]
+

     Node.split_tags(el1, self.tags)
     el1['visible'] = self.visible.to_s
     el1['timestamp'] = self.timestamp.xmlschema
     Node.split_tags(el1, self.tags)
     el1['visible'] = self.visible.to_s
     el1['timestamp'] = self.timestamp.xmlschema