Merge remote-tracking branch 'upstream/pull/5053'

[rails.git] / app / helpers / open_graph_helper.rb

diff --git a/app/helpers/open_graph_helper.rb b/app/helpers/open_graph_helper.rb
index 0ce4d626707a49c5d6737cc8f578d8b8d52cbf5b..ad24c73b2fb3c2115d3b0a19b4c3809f18cd0638 100644 (file)
--- a/app/helpers/open_graph_helper.rb
+++ b/app/helpers/open_graph_helper.rb
@@ -1,16 +1,38 @@
 module OpenGraphHelper
-  def opengraph_tags(title = nil, og_image = nil)
+  require "addressable/uri"
+
+  def opengraph_tags(title = nil, og_image = nil, og_image_alt = nil)
     tags = {
       "og:site_name" => t("layouts.project_name.title"),
-      "og:title" => [title, t("layouts.project_name.title")].compact.join(" | "),
+      "og:title" => title || t("layouts.project_name.title"),
       "og:type" => "website",
-      "og:image" => og_image ? URI.join(root_url, og_image) : image_url("osm_logo_256.png"),
       "og:url" => url_for(:only_path => false),
       "og:description" => t("layouts.intro_text")
-    }
+    }.merge(
+      opengraph_image_properties(og_image, og_image_alt)
+    )
 
     safe_join(tags.map do |property, content|
       tag.meta(:property => property, :content => content)
     end, "\n")
   end
+
+  private
+
+  def opengraph_image_properties(og_image, og_image_alt)
+    begin
+      if og_image
+        properties = {}
+        properties["og:image"] = Addressable::URI.join(root_url, og_image).normalize
+        properties["og:image:alt"] = og_image_alt if og_image_alt
+        return properties
+      end
+    rescue Addressable::URI::InvalidURIError
+      # return default image
+    end
+    {
+      "og:image" => image_url("osm_logo_256.png"),
+      "og:image:alt" => t("layouts.logo.alt_text")
+    }
+  end
 end