Avoid running integration tests in every locale

[rails.git] / app / models / old_node.rb

diff --git a/app/models/old_node.rb b/app/models/old_node.rb
index 5643a389bc8ad69fb83f7f886b122e97f4cbe8ff..3ec5cd4152939a24bf1816045dfe66bc23b4a262 100644 (file)
--- a/app/models/old_node.rb
+++ b/app/models/old_node.rb
@@ -1,20 +1,54 @@
-class OldNode < ActiveRecord::Base
+# == Schema Information
+#
+# Table name: nodes
+#
+#  node_id      :bigint(8)        not null, primary key
+#  latitude     :integer          not null
+#  longitude    :integer          not null
+#  changeset_id :bigint(8)        not null
+#  visible      :boolean          not null
+#  timestamp    :datetime         not null
+#  tile         :bigint(8)        not null
+#  version      :bigint(8)        not null, primary key
+#  redaction_id :integer
+#
+# Indexes
+#
+#  nodes_changeset_id_idx  (changeset_id)
+#  nodes_tile_idx          (tile)
+#  nodes_timestamp_idx     (timestamp)
+#
+# Foreign Keys
+#
+#  nodes_changeset_id_fkey  (changeset_id => changesets.id)
+#  nodes_redaction_id_fkey  (redaction_id => redactions.id)
+#
+
+class OldNode < ApplicationRecord

   include GeoRecord
   include ConsistencyValidations
   include GeoRecord
   include ConsistencyValidations

-  include Redactable

 
   self.table_name = "nodes"
 
   self.table_name = "nodes"

-  self.primary_keys = "node_id", "version"

 
 

-  validates_presence_of :changeset_id, :timestamp
-  validates_inclusion_of :visible, :in => [ true, false ]
-  validates_numericality_of :latitude, :longitude
+  # NOTE: this needs to be included after the table name changes, or
+  # the queries generated by Redactable will use the wrong table name.
+  include Redactable
+
+  validates :changeset, :associated => true
+  validates :latitude, :presence => true,
+                       :numericality => { :only_integer => true }
+  validates :longitude, :presence => true,
+                        :numericality => { :only_integer => true }
+  validates :timestamp, :presence => true
+  validates :visible, :inclusion => [true, false]
+

   validate :validate_position
   validate :validate_position

-  validates_associated :changeset

 
   belongs_to :changeset
 
   belongs_to :changeset

-  belongs_to :redaction
-  belongs_to :current_node, :class_name => "Node", :foreign_key => "node_id"
+  belongs_to :redaction, :optional => true
+  belongs_to :current_node, :class_name => "Node", :foreign_key => "node_id", :inverse_of => :old_nodes
+
+  has_many :old_tags, :class_name => "OldNodeTag", :query_constraints => [:node_id, :version], :inverse_of => :old_node

 
   def validate_position
     errors.add(:base, "Node is not in the world") unless in_world?
 
   def validate_position
     errors.add(:base, "Node is not in the world") unless in_world?


@@ -30,89 +64,45 @@ class OldNode < ActiveRecord::Base
     old_node.changeset_id = node.changeset_id
     old_node.node_id = node.id
     old_node.version = node.version
     old_node.changeset_id = node.changeset_id
     old_node.node_id = node.id
     old_node.version = node.version

-    return old_node
-  end
-  
-  def to_xml
-    doc = OSM::API.new.get_xml_doc
-    doc.root << to_xml_node()
-    return doc
-  end
-
-  def to_xml_node
-    el1 = XML::Node.new 'node'
-    el1['id'] = self.node_id.to_s
-    el1['lat'] = self.lat.to_s
-    el1['lon'] = self.lon.to_s
-    el1['changeset'] = self.changeset.id.to_s
-    if self.changeset.user.data_public?
-      el1['user'] = self.changeset.user.display_name
-      el1['uid'] = self.changeset.user.id.to_s
-    end
-
-    self.tags.each do |k,v|
-      el2 = XML::Node.new('tag')
-      el2['k'] = k.to_s
-      el2['v'] = v.to_s
-      el1 << el2
-    end
-
-    el1['visible'] = self.visible.to_s
-    el1['timestamp'] = self.timestamp.xmlschema
-    el1['version'] = self.version.to_s
-    return el1
+    old_node

   end
 
   def save_with_dependencies!
     save!
   end
 
   def save_with_dependencies!
     save!

-    #not sure whats going on here
-    clear_aggregation_cache
-    clear_association_cache
-    #ok from here
-    @attributes.update(OldNode.where(:node_id => self.node_id, :timestamp => self.timestamp, :version => self.version).first.instance_variable_get('@attributes'))
-   
-    self.tags.each do |k,v|
+
+    tags.each do |k, v|

       tag = OldNodeTag.new
       tag.k = k
       tag.v = v
       tag = OldNodeTag.new
       tag.k = k
       tag.v = v

-      tag.node_id = self.node_id
-      tag.version = self.version
+      tag.node_id = node_id
+      tag.version = version

       tag.save!
     end
   end
 
   def tags
       tag.save!
     end
   end
 
   def tags

-    unless @tags
-      @tags = Hash.new
-      OldNodeTag.where(:node_id => self.node_id, :version => self.version).each do |tag|
-        @tags[tag.k] = tag.v
-      end
-    end
-    @tags = Hash.new unless @tags
-    @tags
+    @tags ||= old_tags.to_h { |t| [t.k, t.v] }

   end
 
   end
 

-  def tags=(t)
-    @tags = t 
+  attr_writer :tags
+
+  def tags_as_hash
+    tags
+  end
+
+  # Pretend we're not in any ways
+  def ways
+    []

   end
 
   end
 

-  def tags_as_hash 
-    return self.tags
-  end 
- 
-  # Pretend we're not in any ways 
-  def ways 
-    return [] 
-  end 
- 
-  # Pretend we're not in any relations 
-  def containing_relation_members 
-    return [] 
-  end 
+  # Pretend we're not in any relations
+  def containing_relation_members
+    []
+  end

 
   # check whether this element is the latest version - that is,
   # has the same version as its "current" counterpart.
 
   # check whether this element is the latest version - that is,
   # has the same version as its "current" counterpart.

-  def is_latest_version?
-    current_node.version == self.version
+  def latest_version?
+    current_node.version == version

   end
 end
   end
 end