Overpass query to use map precision

[rails.git] / app / assets / javascripts / index / query.js

diff --git a/app/assets/javascripts/index/query.js b/app/assets/javascripts/index/query.js
index b0fdd54ef0f6142fbd10add885d8bc49e6a50b1f..5c6e5817080efe09680a7dccb2564106efe28713 100644 (file)
--- a/app/assets/javascripts/index/query.js
+++ b/app/assets/javascripts/index/query.js
@@ -1,38 +1,38 @@
 //= require jquery.simulate
 //= require jquery.simulate

+//= require querystring

 
 

-OSM.Query = function(map) {
-  var protocol = document.location.protocol === "https:" ? "https:" : "http:",
-    url = protocol + OSM.OVERPASS_URL,
-    queryButton = $(".control-query .control-button"),
-    uninterestingTags = ['source', 'source_ref', 'source:ref', 'history', 'attribution', 'created_by', 'tiger:county', 'tiger:tlid', 'tiger:upload_uuid'],
-    marker;
+OSM.Query = function (map) {
+  var querystring = require("querystring-component");
+
+  var url = OSM.OVERPASS_URL,
+      queryButton = $(".control-query .control-button"),
+      uninterestingTags = ["source", "source_ref", "source:ref", "history", "attribution", "created_by", "tiger:county", "tiger:tlid", "tiger:upload_uuid", "KSJ2:curve_id", "KSJ2:lat", "KSJ2:lon", "KSJ2:coordinate", "KSJ2:filename", "note:ja"],
+      marker;

 
   var featureStyle = {
     color: "#FF6200",
     weight: 4,
     opacity: 1,
     fillOpacity: 0.5,
 
   var featureStyle = {
     color: "#FF6200",
     weight: 4,
     opacity: 1,
     fillOpacity: 0.5,

-    clickable: false
+    interactive: false

   };
 
   queryButton.on("click", function (e) {
     e.preventDefault();
     e.stopPropagation();
 
   };
 
   queryButton.on("click", function (e) {
     e.preventDefault();
     e.stopPropagation();
 

-    if (queryButton.hasClass("disabled")) return;
-

     if (queryButton.hasClass("active")) {
       disableQueryMode();
     if (queryButton.hasClass("active")) {
       disableQueryMode();

-    } else {
+    } else if (!queryButton.hasClass("disabled")) {

       enableQueryMode();
     }
       enableQueryMode();
     }

-  }).on("disabled", function (e) {
+  }).on("disabled", function () {

     if (queryButton.hasClass("active")) {
       map.off("click", clickHandler);
       $(map.getContainer()).removeClass("query-active").addClass("query-disabled");
       $(this).tooltip("show");
     }
     if (queryButton.hasClass("active")) {
       map.off("click", clickHandler);
       $(map.getContainer()).removeClass("query-active").addClass("query-disabled");
       $(this).tooltip("show");
     }

-  }).on("enabled", function (e) {
+  }).on("enabled", function () {

     if (queryButton.hasClass("active")) {
       map.on("click", clickHandler);
       $(map.getContainer()).removeClass("query-disabled").addClass("query-active");
     if (queryButton.hasClass("active")) {
       map.on("click", clickHandler);
       $(map.getContainer()).removeClass("query-disabled").addClass("query-active");


@@ -42,23 +42,23 @@ OSM.Query = function(map) {
 
   $("#sidebar_content")
     .on("mouseover", ".query-results li.query-result", function () {
 
   $("#sidebar_content")
     .on("mouseover", ".query-results li.query-result", function () {

-      var geometry = $(this).data("geometry")
+      var geometry = $(this).data("geometry");

       if (geometry) map.addLayer(geometry);
       $(this).addClass("selected");
     })
     .on("mouseout", ".query-results li.query-result", function () {
       if (geometry) map.addLayer(geometry);
       $(this).addClass("selected");
     })
     .on("mouseout", ".query-results li.query-result", function () {

-      var geometry = $(this).data("geometry")
+      var geometry = $(this).data("geometry");

       if (geometry) map.removeLayer(geometry);
       $(this).removeClass("selected");
     })
       if (geometry) map.removeLayer(geometry);
       $(this).removeClass("selected");
     })

-    .on("mousedown", ".query-results li.query-result", function (e) {
+    .on("mousedown", ".query-results li.query-result", function () {

       var moved = false;
       $(this).one("click", function (e) {
         if (!moved) {
       var moved = false;
       $(this).one("click", function (e) {
         if (!moved) {

-          var geometry = $(this).data("geometry")
+          var geometry = $(this).data("geometry");

           if (geometry) map.removeLayer(geometry);
 
           if (geometry) map.removeLayer(geometry);
 

-          if (!$(e.target).is('a')) {
+          if (!$(e.target).is("a")) {

             $(this).find("a").simulate("click", e);
           }
         }
             $(this).find("a").simulate("click", e);
           }
         }


@@ -67,7 +67,7 @@ OSM.Query = function(map) {
       });
     });
 
       });
     });
 

-  function interestingFeature(feature, origin, radius) {
+  function interestingFeature(feature) {

     if (feature.tags) {
       for (var key in feature.tags) {
         if (uninterestingTags.indexOf(key) < 0) {
     if (feature.tags) {
       for (var key in feature.tags) {
         if (uninterestingTags.indexOf(key) < 0) {


@@ -83,23 +83,32 @@ OSM.Query = function(map) {
     var tags = feature.tags;
     var prefix = "";
 
     var tags = feature.tags;
     var prefix = "";
 

-    if (tags.boundary === "administrative") {
-      prefix = I18n.t("geocoder.search_osm_nominatim.admin_levels.level" + tags.admin_level)
+    if (tags.boundary === "administrative" && tags.admin_level) {
+      prefix = I18n.t("geocoder.search_osm_nominatim.admin_levels.level" + tags.admin_level, {
+        defaultValue: I18n.t("geocoder.search_osm_nominatim.prefix.boundary.administrative")
+      });

     } else {
       var prefixes = I18n.t("geocoder.search_osm_nominatim.prefix");
     } else {
       var prefixes = I18n.t("geocoder.search_osm_nominatim.prefix");

+      var key, value;

 
 

-      for (var key in tags) {
-        var value = tags[key];
+      for (key in tags) {
+        value = tags[key];

 
         if (prefixes[key]) {
           if (prefixes[key][value]) {
             return prefixes[key][value];
 
         if (prefixes[key]) {
           if (prefixes[key][value]) {
             return prefixes[key][value];

-          } else {
-            var first = value.substr(0, 1).toUpperCase(),
+          }
+        }
+      }
+
+      for (key in tags) {
+        value = tags[key];
+
+        if (prefixes[key]) {
+          var first = value.substr(0, 1).toUpperCase(),

               rest = value.substr(1).replace(/_/g, " ");
 
               rest = value.substr(1).replace(/_/g, " ");
 

-            return first + rest;
-          }
+          return first + rest;

         }
       }
     }
         }
       }
     }


@@ -112,12 +121,19 @@ OSM.Query = function(map) {
   }
 
   function featureName(feature) {
   }
 
   function featureName(feature) {

-    var tags = feature.tags;
+    var tags = feature.tags,
+        locales = I18n.locales.get();

 
 

-    if (tags["name"]) {
-      return tags["name"];
-    } else if (tags["ref"]) {
-      return tags["ref"];
+    for (var i = 0; i < locales.length; i++) {
+      if (tags["name:" + locales[i]]) {
+        return tags["name:" + locales[i]];
+      }
+    }
+
+    if (tags.name) {
+      return tags.name;
+    } else if (tags.ref) {
+      return tags.ref;

     } else if (tags["addr:housename"]) {
       return tags["addr:housename"];
     } else if (tags["addr:housenumber"] && tags["addr:street"]) {
     } else if (tags["addr:housename"]) {
       return tags["addr:housename"];
     } else if (tags["addr:housenumber"] && tags["addr:street"]) {


@@ -132,7 +148,7 @@ OSM.Query = function(map) {
 
     if (feature.type === "node" && feature.lat && feature.lon) {
       geometry = L.circleMarker([feature.lat, feature.lon], featureStyle);
 
     if (feature.type === "node" && feature.lat && feature.lon) {
       geometry = L.circleMarker([feature.lat, feature.lon], featureStyle);

-    } else if (feature.type === "way" && feature.geometry) {
+    } else if (feature.type === "way" && feature.geometry && feature.geometry.length > 0) {

       geometry = L.polyline(feature.geometry.filter(function (point) {
         return point !== null;
       }).map(function (point) {
       geometry = L.polyline(feature.geometry.filter(function (point) {
         return point !== null;
       }).map(function (point) {


@@ -140,14 +156,14 @@ OSM.Query = function(map) {
       }), featureStyle);
     } else if (feature.type === "relation" && feature.members) {
       geometry = L.featureGroup(feature.members.map(featureGeometry).filter(function (geometry) {
       }), featureStyle);
     } else if (feature.type === "relation" && feature.members) {
       geometry = L.featureGroup(feature.members.map(featureGeometry).filter(function (geometry) {

-        return geometry !== undefined;
+        return typeof geometry !== "undefined";

       }));
     }
 
     return geometry;
   }
 
       }));
     }
 
     return geometry;
   }
 

-  function runQuery(latlng, radius, query, $section, compare) {
+  function runQuery(latlng, radius, query, $section, merge, compare) {

     var $ul = $section.find("ul");
 
     $ul.empty();
     var $ul = $section.find("ul");
 
     $ul.empty();


@@ -165,23 +181,38 @@ OSM.Query = function(map) {
       url: url,
       method: "POST",
       data: {
       url: url,
       method: "POST",
       data: {

-        data: "[timeout:5][out:json];" + query,
+        data: "[timeout:10][out:json];" + query

       },
       },

-      success: function(results) {
+      success: function (results) {

         var elements;
 
         $section.find(".loader").stopTime("loading").hide();
 
         var elements;
 
         $section.find(".loader").stopTime("loading").hide();
 

-        if (compare) {
-          elements = results.elements.sort(compare);
+        if (merge) {
+          elements = results.elements.reduce(function (hash, element) {
+            var key = element.type + element.id;
+            if ("geometry" in element) {
+              delete element.bounds;
+            }
+            hash[key] = $.extend({}, hash[key], element);
+            return hash;
+          }, {});
+
+          elements = Object.keys(elements).map(function (key) {
+            return elements[key];
+          });

         } else {
           elements = results.elements;
         }
 
         } else {
           elements = results.elements;
         }
 

+        if (compare) {
+          elements = elements.sort(compare);
+        }
+

         for (var i = 0; i < elements.length; i++) {
           var element = elements[i];
 
         for (var i = 0; i < elements.length; i++) {
           var element = elements[i];
 

-          if (interestingFeature(element, latlng, radius)) {
+          if (interestingFeature(element)) {

             var $li = $("<li>")
               .addClass("query-result")
               .data("geometry", featureGeometry(element))
             var $li = $("<li>")
               .addClass("query-result")
               .data("geometry", featureGeometry(element))


@@ -197,13 +228,19 @@ OSM.Query = function(map) {
           }
         }
 
           }
         }
 

-        if ($ul.find("li").length == 0) {
+        if (results.remark) {
+          $("<li>")
+            .text(I18n.t("javascripts.query.error", { server: url, error: results.remark }))
+            .appendTo($ul);
+        }
+
+        if ($ul.find("li").length === 0) {

           $("<li>")
             .text(I18n.t("javascripts.query.nothing_found"))
             .appendTo($ul);
         }
       },
           $("<li>")
             .text(I18n.t("javascripts.query.nothing_found"))
             .appendTo($ul);
         }
       },

-      error: function(xhr, status, error) {
+      error: function (xhr, status, error) {

         $section.find(".loader").stopTime("loading").hide();
 
         $("<li>")
         $section.find(".loader").stopTime("loading").hide();
 
         $("<li>")


@@ -215,11 +252,11 @@ OSM.Query = function(map) {
 
   function compareSize(feature1, feature2) {
     var width1 = feature1.bounds.maxlon - feature1.bounds.minlon,
 
   function compareSize(feature1, feature2) {
     var width1 = feature1.bounds.maxlon - feature1.bounds.minlon,

-      height1 = feature1.bounds.maxlat - feature1.bounds.minlat,
-      area1 = width1 * height1,
-      width2 = feature2.bounds.maxlat - feature2.bounds.minlat,
-      height2 = feature2.bounds.maxlat - feature2.bounds.minlat,
-      area2 = width2 * height2;
+        height1 = feature1.bounds.maxlat - feature1.bounds.minlat,
+        area1 = width1 * height1,
+        width2 = feature2.bounds.maxlat - feature2.bounds.minlat,
+        height2 = feature2.bounds.maxlat - feature2.bounds.minlat,
+        area2 = width2 * height2;

 
     return area1 - area2;
   }
 
     return area1 - area2;
   }


@@ -245,16 +282,20 @@ OSM.Query = function(map) {
    * for each object.
    */
   function queryOverpass(lat, lng) {
    * for each object.
    */
   function queryOverpass(lat, lng) {

-    var latlng = L.latLng(lat, lng),
-      bounds = map.getBounds(),
-      bbox = bounds.getSouth() + "," + bounds.getWest() + "," + bounds.getNorth() + "," + bounds.getEast(),
-      radius = 10 * Math.pow(1.5, 19 - map.getZoom()),
-      around = "around:" + radius + "," + lat + "," + lng,
-      nodes = "node(" + around + ")",
-      ways = "way(" + around + ")",
-      relations = "relation(" + around + ")",
-      nearby = "(" + nodes + ";" + ways + ");out tags geom(" + bbox + ");" + relations + ";out geom(" + bbox + ");",
-      isin = "is_in(" + lat + "," + lng + ")->.a;way(pivot.a);out tags geom(" + bbox + ");relation(pivot.a);out tags bb;";
+    var latlng = L.latLng(lat, lng).wrap(),
+        bounds = map.getBounds().wrap(),
+        precision = OSM.zoomPrecision(map.getZoom()),
+        bbox = bounds.getSouth().toFixed(precision) + "," +
+               bounds.getWest().toFixed(precision) + "," +
+               bounds.getNorth().toFixed(precision) + "," +
+               bounds.getEast().toFixed(precision),
+        radius = 10 * Math.pow(1.5, 19 - map.getZoom()),
+        around = "around:" + radius + "," + lat + "," + lng,
+        nodes = "node(" + around + ")",
+        ways = "way(" + around + ")",
+        relations = "relation(" + around + ")",
+        nearby = "(" + nodes + ";" + ways + ";);out tags geom(" + bbox + ");" + relations + ";out geom(" + bbox + ");",
+        isin = "is_in(" + lat + "," + lng + ")->.a;way(pivot.a);out tags bb;out ids geom(" + bbox + ");relation(pivot.a);out tags bb;";

 
     $("#sidebar_content .query-intro")
       .hide();
 
     $("#sidebar_content .query-intro")
       .hide();


@@ -263,24 +304,25 @@ OSM.Query = function(map) {
     marker = L.circle(latlng, radius, featureStyle).addTo(map);
 
     $(document).everyTime(75, "fadeQueryMarker", function (i) {
     marker = L.circle(latlng, radius, featureStyle).addTo(map);
 
     $(document).everyTime(75, "fadeQueryMarker", function (i) {

-      if (i == 10) {
+      if (i === 10) {

         map.removeLayer(marker);
       } else {
         marker.setStyle({
         map.removeLayer(marker);
       } else {
         marker.setStyle({

-          opacity: 1 - i * 0.1,
-          fillOpacity: 0.5 - i * 0.05
+          opacity: 1 - (i * 0.1),
+          fillOpacity: 0.5 - (i * 0.05)

         });
       }
     }, 10);
 
         });
       }
     }, 10);
 

-    runQuery(latlng, radius, nearby, $("#query-nearby"));
-    runQuery(latlng, radius, isin, $("#query-isin"), compareSize);
+    runQuery(latlng, radius, nearby, $("#query-nearby"), false);
+    runQuery(latlng, radius, isin, $("#query-isin"), true, compareSize);

   }
 
   function clickHandler(e) {
     var precision = OSM.zoomPrecision(map.getZoom()),
   }
 
   function clickHandler(e) {
     var precision = OSM.zoomPrecision(map.getZoom()),

-      lat = e.latlng.lat.toFixed(precision),
-      lng = e.latlng.lng.toFixed(precision);
+        latlng = e.latlng.wrap(),
+        lat = latlng.lat.toFixed(precision),
+        lng = latlng.lng.toFixed(precision);

 
     OSM.router.route("/query?lat=" + lat + "&lon=" + lng);
   }
 
     OSM.router.route("/query?lat=" + lat + "&lon=" + lng);
   }


@@ -300,15 +342,15 @@ OSM.Query = function(map) {
 
   var page = {};
 
 
   var page = {};
 

-  page.pushstate = page.popstate = function(path) {
+  page.pushstate = page.popstate = function (path) {

     OSM.loadSidebarContent(path, function () {
       page.load(path, true);
     });
   };
 
     OSM.loadSidebarContent(path, function () {
       page.load(path, true);
     });
   };
 

-  page.load = function(path, noCentre) {
-    var params = querystring.parse(path.substring(path.indexOf('?') + 1)),
-      latlng = L.latLng(params.lat, params.lon);
+  page.load = function (path, noCentre) {
+    var params = querystring.parse(path.substring(path.indexOf("?") + 1)),
+        latlng = L.latLng(params.lat, params.lon);

 
     if (!window.location.hash && !noCentre && !map.getBounds().contains(latlng)) {
       OSM.router.withoutMoveListener(function () {
 
     if (!window.location.hash && !noCentre && !map.getBounds().contains(latlng)) {
       OSM.router.withoutMoveListener(function () {


@@ -319,7 +361,7 @@ OSM.Query = function(map) {
     queryOverpass(params.lat, params.lon);
   };
 
     queryOverpass(params.lat, params.lon);
   };
 

-  page.unload = function(sameController) {
+  page.unload = function (sameController) {

     if (!sameController) {
       disableQueryMode();
     }
     if (!sameController) {
       disableQueryMode();
     }