Prefer string interpolation to concatenation

[rails.git] / app / views / diary_entries / index.html.erb

diff --git a/app/views/diary_entries/index.html.erb b/app/views/diary_entries/index.html.erb
index 63a805b3c5be2679740e5a5b74f81142946584de..96c052da69fd940ff16c7e7f374017fbde99ed6c 100644 (file)
--- a/app/views/diary_entries/index.html.erb
+++ b/app/views/diary_entries/index.html.erb
@@ -1,62 +1,52 @@
 <% content_for :heading do %>
 <% content_for :heading do %>

-  <div <% if @user %> id="userinformation"<% end %> >
+  <div <% if @user %> id="userinformation"<% end %>>

     <% if @user %>
       <%= user_image @user %>
     <% end %>
     <% if @user %>
       <%= user_image @user %>
     <% end %>

-    <h1><%= h(@title) %></h1>
+    <h1><%= @title %></h1>

 
     <ul class='secondary-actions clearfix'>
       <% unless params[:friends] or params[:nearby] -%>
 
     <ul class='secondary-actions clearfix'>
       <% unless params[:friends] or params[:nearby] -%>

-        <li><%= rss_link_to :action => 'rss', :language => params[:language] %></li>
+        <li><%= rss_link_to :action => "rss", :language => params[:language] %></li>

       <% end -%>
 
       <% end -%>
 

-      <% if @user %>
-        <% if @user == current_user %>
-          <div>
-            <li><%= link_to image_tag("new.png", :class => "small_icon", :border=>0) + t('.new'), diary_new_path, {:title => t('.new_title')} %></li>
-          </div>
-        <% end %>
-      <% else %>
-        <% if current_user %>
-          <div>
-            <li><%= link_to image_tag("new.png", :class => "small_icon", :border=>0) + t('.new'), diary_new_path, {:title => t('.new_title')} %></li>
-          </div>
-        <% end %>
+      <% if @user && @user == current_user || !@user && current_user %>
+        <li><%= link_to image_tag("new.png", :class => "small_icon") + t(".new"), new_diary_entry_path, :title => t(".new_title") %></li>
+      <% end %>
+
+      <% if !@user && current_user %>
+        <li><%= link_to t(".my_diary"), :controller => "diary_entries", :action => "index", :display_name => current_user.display_name %></li>

       <% end %>
     </ul>
   </div>
 <% end %>
 
 <% if @entries.empty? %>
       <% end %>
     </ul>
   </div>
 <% end %>
 
 <% if @entries.empty? %>

-  <h4><%= t '.no_entries' %></h4>
+  <h4><%= t ".no_entries" %></h4>

 <% else %>
 <% else %>

-  <h4><%= t '.recent_entries' %></h4>
+  <h4><%= t ".recent_entries" %></h4>

 
 

-  <% if @user %>
-    <%= render :partial => 'diary_entry', :collection => @entries %>
-  <% else %>
-    <%= render :partial => 'diary_index_entry', :collection => @entries %>
-  <% end %>
+  <%= render @entries %>

 
   <div class="pagination">
     <% if @entries.size < @page_size -%>
 
   <div class="pagination">
     <% if @entries.size < @page_size -%>

-      <%= t('.older_entries') %>
+      <%= t(".older_entries") %>

     <% else -%>
     <% else -%>

-      <%= link_to t('.older_entries'), @params.merge(:page => @page + 1 ) %>
+      <%= link_to t(".older_entries"), @params.merge(:page => @page + 1) %>

     <% end -%>
 
     |
 
     <% if @page > 1 -%>
     <% end -%>
 
     |
 
     <% if @page > 1 -%>

-      <%= link_to t('.newer_entries'), @params.merge(:page => @page - 1) %>
+      <%= link_to t(".newer_entries"), @params.merge(:page => @page - 1) %>

     <% else -%>
     <% else -%>

-      <%= t('.newer_entries') %>
+      <%= t(".newer_entries") %>

     <% end -%>
   </div>
 <% end %>
 
 <% unless params[:friends] or params[:nearby] -%>
   <% content_for :auto_discovery_link_tag do -%>
     <% end -%>
   </div>
 <% end %>
 
 <% unless params[:friends] or params[:nearby] -%>
   <% content_for :auto_discovery_link_tag do -%>

-  <%= auto_discovery_link_tag :rss, :action => 'rss', :language => params[:language] %>
+  <%= auto_discovery_link_tag :rss, :action => "rss", :language => params[:language] %>

   <% end -%>
 <% end -%>
   <% end -%>
 <% end -%>