-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2015-02-25 00:27:05 +0000 using RuboCop version 0.29.1.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-09-07 11:03:27 +0100 using RuboCop version 0.41.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
-# Offense count: 13
+# Offense count: 34
Lint/AmbiguousOperator:
- Enabled: false
+ Exclude:
+ - 'test/controllers/amf_controller_test.rb'
+ - 'test/controllers/changeset_controller_test.rb'
+ - 'test/lib/bounding_box_test.rb'
+ - 'test/lib/country_test.rb'
-# Offense count: 107
+# Offense count: 117
Lint/AmbiguousRegexpLiteral:
Enabled: false
-# Offense count: 29
+# Offense count: 30
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
- Enabled: false
+ Exclude:
+ - 'app/controllers/application_controller.rb'
+ - 'app/controllers/geocoder_controller.rb'
+ - 'app/controllers/notes_controller.rb'
+ - 'app/controllers/trace_controller.rb'
+ - 'app/controllers/user_controller.rb'
+ - 'app/controllers/user_preference_controller.rb'
+ - 'app/helpers/application_helper.rb'
+ - 'app/helpers/browse_helper.rb'
+ - 'app/models/client_application.rb'
+ - 'app/models/notifier.rb'
+ - 'lib/nominatim.rb'
+ - 'lib/osm.rb'
+ - 'script/deliver-message'
# Offense count: 5
Lint/HandleExceptions:
- Enabled: false
+ Exclude:
+ - 'app/controllers/amf_controller.rb'
+ - 'app/controllers/user_controller.rb'
+ - 'config/initializers/session.rb'
-# Offense count: 8
-Lint/ParenthesesAsGroupedExpression:
- Enabled: false
+# Offense count: 2
+Lint/ShadowingOuterLocalVariable:
+ Exclude:
+ - 'app/views/changeset/list.atom.builder'
-# Offense count: 542
+# Offense count: 626
Metrics/AbcSize:
- Max: 194
+ Max: 277
# Offense count: 12
Metrics/BlockNesting:
Max: 5
-# Offense count: 60
+# Offense count: 62
# Configuration parameters: CountComments.
Metrics/ClassLength:
- Max: 1515
+ Max: 1650
# Offense count: 68
Metrics/CyclomaticComplexity:
- Max: 21
+ Max: 20
-# Offense count: 2092
-# Configuration parameters: AllowURI, URISchemes.
+# Offense count: 2561
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
Metrics/LineLength:
- Max: 520
+ Max: 962
-# Offense count: 520
+# Offense count: 604
# Configuration parameters: CountComments.
Metrics/MethodLength:
Max: 179
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+ Max: 139
+
# Offense count: 4
# Configuration parameters: CountKeywordArgs.
Metrics/ParameterLists:
# Offense count: 70
Metrics/PerceivedComplexity:
- Max: 24
+ Max: 23
-# Offense count: 164
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, Include.
-Rails/ActionFilter:
- Enabled: false
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb
+Rails/Exit:
+ Exclude:
+ - 'lib/**/*.rake'
+ - 'lib/daemons/gpx_import.rb'
# Offense count: 2
# Configuration parameters: Include.
+# Include: app/models/**/*.rb
Rails/HasAndBelongsToMany:
- Enabled: false
+ Exclude:
+ - 'app/models/changeset.rb'
+ - 'app/models/user.rb'
# Offense count: 17
-# Cop supports --auto-correct.
-# Configuration parameters: Include.
-Rails/ReadWriteAttribute:
- Enabled: false
-
-# Offense count: 123
-# Configuration parameters: Include.
-Rails/Validation:
+Rails/OutputSafety:
+ Exclude:
+ - 'app/controllers/user_controller.rb'
+ - 'app/helpers/application_helper.rb'
+ - 'app/helpers/changeset_helper.rb'
+ - 'app/helpers/geocoder_helper.rb'
+ - 'app/helpers/note_helper.rb'
+ - 'app/helpers/open_graph_helper.rb'
+ - 'app/helpers/user_blocks_helper.rb'
+ - 'app/helpers/user_roles_helper.rb'
+ - 'lib/rich_text.rb'
+ - 'test/helpers/application_helper_test.rb'
+
+# Offense count: 65
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: strict, flexible
+Rails/TimeZone:
Enabled: false
# Offense count: 5
Style/AccessorMethodName:
- Enabled: false
+ Exclude:
+ - 'app/controllers/application_controller.rb'
+ - 'app/helpers/title_helper.rb'
+ - 'app/models/old_way.rb'
+ - 'lib/osm.rb'
+ - 'lib/potlatch.rb'
# Offense count: 1
Style/AsciiComments:
- Enabled: false
+ Exclude:
+ - 'test/models/message_test.rb'
-# Offense count: 305
+# Offense count: 218
Style/Documentation:
Enabled: false
-# Offense count: 39
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
- Enabled: false
-
# Offense count: 60
# Cop supports --auto-correct.
Style/LineEndConcatenation:
- Enabled: false
-
-# Offense count: 53
+ Exclude:
+ - 'db/migrate/008_remove_segments.rb'
+ - 'db/migrate/020_populate_node_tags_and_remove.rb'
+ - 'db/migrate/023_add_changesets.rb'
+ - 'lib/bounding_box.rb'
+ - 'lib/diff_reader.rb'
+ - 'lib/osm.rb'
+ - 'test/controllers/changeset_controller_test.rb'
+ - 'test/controllers/node_controller_test.rb'
+ - 'test/controllers/relation_controller_test.rb'
+ - 'test/controllers/way_controller_test.rb'
+
+# Offense count: 69
# Cop supports --auto-correct.
Style/NumericLiterals:
MinDigits: 11
-# Offense count: 44
+# Offense count: 38
# Cop supports --auto-correct.
Style/PerlBackrefs:
- Enabled: false
+ Exclude:
+ - 'app/controllers/amf_controller.rb'
+ - 'app/helpers/browse_helper.rb'
+ - 'config/initializers/paperclip.rb'
+ - 'lib/id.rb'
+ - 'lib/potlatch.rb'
+ - 'test/lib/i18n_test.rb'
# Offense count: 8
-# Configuration parameters: NamePrefix, NamePrefixBlacklist.
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
Style/PredicateName:
- Enabled: false
-
-# Offense count: 95
+ Exclude:
+ - 'spec/**/*'
+ - 'app/models/changeset.rb'
+ - 'app/models/old_node.rb'
+ - 'app/models/old_relation.rb'
+ - 'app/models/old_way.rb'
+ - 'app/models/user.rb'
+ - 'lib/classic_pagination/pagination.rb'
+
+# Offense count: 97
+# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: compact, exploded
Style/RaiseArgs:
Enabled: false
# Offense count: 2
+# Cop supports --auto-correct.
Style/RescueModifier:
- Enabled: false
+ Exclude:
+ - 'app/helpers/browse_helper.rb'
# Offense count: 8
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
- Enabled: false
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
-Style/TrivialAccessors:
- Enabled: false
+ Exclude:
+ - 'app/controllers/amf_controller.rb'
+ - 'app/models/node.rb'
+ - 'app/models/way.rb'
+ - 'lib/migrate.rb'
+ - 'test/controllers/changeset_controller_test.rb'